rot1024

rot1024

JavaScript / TypeScript / Node.js / Go / Rust

Member Since 8 years ago

Japan

Experience Points
47
follower
Lessons Completed
31
follow
Lessons Completed
1.8k
stars
Best Reply Awards
28
repos

1715 contributions in the last year

Pinned
⚡ Free, open, highly extensible WebGIS platform
⚡ React components for 🌏 Cesium
⚡ ニコニコ風実況アプリ(メンテナンス停止中)
Activity
Nov
29
2 days ago
pull request

rot1024 merge to reearth/reearth-backend

rot1024
rot1024

feat: user verification

Overview

What I've done

What I haven't done

create email content

How I tested

Which point I want you to review particularly

Memo

pull request

rot1024 merge to reearth/reearth-backend

rot1024
rot1024

feat: user verification

Overview

What I've done

What I haven't done

create email content

How I tested

Which point I want you to review particularly

Memo

Nov
26
5 days ago
started
started time in 4 days ago
open pull request

rot1024 wants to merge reearth/reearth-backend

rot1024
rot1024

feat: password reset

rot1024
rot1024

Use github.com/google/uuid (use a well-maintained library for security reasons)

open pull request

rot1024 wants to merge reearth/reearth-backend

rot1024
rot1024

feat: password reset

rot1024
rot1024

Sorry, I made a mistake and thought this method was just a simple getter, but it accepts an arg and has logic. I think Validate is better name

func (pr *PasswordReset) Validate(token string) bool {
open pull request

rot1024 wants to merge reearth/reearth-backend

rot1024
rot1024

feat: password reset

rot1024
rot1024
func TestPasswordReset_Validate(t *testing.T) {
started
started time in 4 days ago
push

rot1024 push reearth/reearth-web

rot1024
rot1024

feat: enhance terrain feature (type selection, exaggeration) (#138)

commit sha: dae13762fe2cd42116f65b7e82b902d99df8372e

push time in 4 days ago
Activity icon
delete

rot1024 in reearth/reearth-web delete branch terrain

deleted time in 4 days ago
pull request

rot1024 pull request reearth/reearth-web

rot1024
rot1024

feat: enhance terrain feature (type selection, exaggeration)

Enhance terrain feature:

  • Support selecting terrain type
    • Cesium World Terrain, ArcGIS Terrain
    • Default is cesium
  • Support terrain exaggeration

Backend is already implemented by https://github.com/reearth/reearth-backend/commit/8693b4833399c06958bab2c553f19bd4e0341603 and https://github.com/reearth/reearth-backend/commit/5e3d253ea63f2aaa356d7af528fbb8556d4b40d8

image

push

rot1024 push reearth/reearth-backend

rot1024
rot1024

refactor: make property.Value and dataset.Value independent in pkg/value (#77)

commit sha: 73143b7bb598af04d0ce84177eaa1b91cb1468b5

push time in 4 days ago
Activity icon
delete

rot1024 in reearth/reearth-backend delete branch refactor/value

deleted time in 4 days ago
pull request

rot1024 pull request reearth/reearth-backend

rot1024
rot1024

refactor: make property.Value and dataset.Value independent in pkg/value

Refactoring has been done to facilitate the various Re:Earth property enhancements planned for the future:

Tasks

  • Move logic of property.Value and dataset.Value to pkg/value
  • Refactor pkg/property, pkg/dataset, pkg/layer
  • Change some layer encoder output (e.g. style ID of KMLs)

How does this change tested

  • Unit tests confirmed that no degreasing had occurred
  • I confirmed properties are correctly fetched and updated at local env

Review point

You don't need check all files, but check pkg/value/*.go.

  • property.Value and dataset.Value wraps value.Value, property.ValueType and dataset.ValueType wraps value.Type, property.OptionalValue and dataset.OptionalValue wraps value.OptionalValue.
  • value.TypeProperty can define a new value type for value.Value. It is used by pkg/property. typography and camera type are defined at pkg/property/value.go because they are never used as dataset values.
  • pkg/dataset does not define any new type. Types of dataset values are the same as default types of pkg/value.
  • value.OptionalValue provides a way to treat optional (nullable) values safety. If either type or value of an value.OptionalValue is invalid, it will turn into nil and any operation for it will not be succeeded. value.OptionalValue is used by property.Field and dataset.Field.
push

rot1024 push reearth/reearth-backend

rot1024
rot1024

chore: fix plugin manifest JSON schema

rot1024
rot1024

feat: add fields of scene property for terrain

rot1024
rot1024

fix: terrain fields of scene property

rot1024
rot1024

Merge branch 'main' into refactor/value

commit sha: 33d5674ba4e990594d3fd6623131d8e22fce1918

push time in 4 days ago
Activity icon
issue

rot1024 issue reearth/reearth

rot1024
rot1024

Header height changes when entity is selected in editor page

Describe the bug

Header height changes when entity is selected in editor page

Confirmed with Google Chrome on MacOS

To Reproduce

Select an entity in the editor page

Expected behavior

Header height should be fixed

Screenshots

Kapture 2021-11-26 at 17 22 02

pull request

rot1024 pull request reearth/reearth-web

rot1024
rot1024

feat: enhance terrain feature (type, exaggeration)

Enhance terrain feature:

  • Support selecting terrain type
    • Cesium World Terrain, ArcGIS Terrain)
    • Default is cesium
  • Support terrain exaggeration

Backend is already implemented by https://github.com/reearth/reearth-backend/commit/8693b4833399c06958bab2c553f19bd4e0341603 and https://github.com/reearth/reearth-backend/commit/5e3d253ea63f2aaa356d7af528fbb8556d4b40d8

image

Activity icon
created branch

rot1024 in reearth/reearth-web create branch terrain

createdAt 5 days ago
push

rot1024 push reearth/reearth-backend

rot1024
rot1024

fix: terrain fields of scene property

commit sha: 5e3d253ea63f2aaa356d7af528fbb8556d4b40d8

push time in 5 days ago
push

rot1024 push reearth/reearth-backend

rot1024
rot1024

chore: fix plugin manifest JSON schema

rot1024
rot1024

feat: add fields of scene property for terrain

commit sha: 8693b4833399c06958bab2c553f19bd4e0341603

push time in 5 days ago
Nov
25
6 days ago
open pull request

rot1024 wants to merge reearth/reearth-backend

rot1024
rot1024

feat: password reset

rot1024
rot1024
func (pr *PasswordReset) Valid(token string) bool {

Short method name will be liked by Go developers

open pull request

rot1024 wants to merge reearth/reearth-backend

rot1024
rot1024

feat: password reset

rot1024
rot1024
func (u *User) SetPasswordReset(pr *PasswordReset) {
	u.passwordReset = pr.Clone()
}

This implementation is one of answer.

My way is using setter that simplifies User struct because the internal concerns of password reset can be completely transferred to PasswordReset struct. Copying is required to prevent changing internal values by outside without methods.

open pull request

rot1024 wants to merge reearth/reearth-backend

rot1024
rot1024

feat: password reset

rot1024
rot1024

You can add another func for conversion between domain model and mongo doc:

func PasswordResetFrom(token string, createdAt time.Time) *PasswordReset {
	return &PasswordReset{
		Token:     token,
		CreatedAt: createdAt,
	}
}

Of course, unit test is required

open pull request

rot1024 wants to merge reearth/reearth-backend

rot1024
rot1024

feat: password reset

rot1024
rot1024
func (b *Builder) PasswordReset(pr *PasswordReset) *Builder {

Accepting PasswordReset struct directly make codes simple

open pull request

rot1024 wants to merge reearth/reearth-backend

rot1024
rot1024

feat: password reset

rot1024
rot1024
	Email    string `json:"email"`
	Token    string `json:"token"`
	Password string `json:"password"`

Empty string is almost same as nil