ryanmcdermott

ryanmcdermott

Occasional open source developer. I'm sorry for my slow responses to issues and PRs.

Member Since 8 years ago

@google , Bay Area

Experience Points
2.2k
follower
Lessons Completed
4
follow
Lessons Completed
494
stars
Best Reply Awards
36
repos

348 contributions in the last year

Pinned
⚡ :bathtub: Clean Code concepts adapted for JavaScript
⚡ :microscope: Common problems to look for in a code review
⚡ A guide on how to write readable, reusable, and refactorable software
⚡ Mocking library to create mock objects with fake data for TypeScript interfaces
⚡ :school: Coding katas
⚡ :iphone: An example React Native project for client login authentication
Activity
Aug
31
1 month ago
Activity icon
issue

ryanmcdermott issue comment google/intermock

ryanmcdermott
ryanmcdermott

Hey there! Would you be able to sign the CLA before I review this?

Aug
18
2 months ago
started
started time in 2 months ago
Aug
7
2 months ago
Activity icon
issue

ryanmcdermott issue comment ryanmcdermott/code-review-tips

ryanmcdermott
ryanmcdermott

Correct some minor typos in readme

A small update to correct some minor typos.

Thanks for all your hard work!

ryanmcdermott
ryanmcdermott
push

ryanmcdermott push ryanmcdermott/code-review-tips

ryanmcdermott
ryanmcdermott

Merge pull request #10 from lobaak/typo

Correct some minor typos in readme

commit sha: 06990811b92ad04a717ad30b8aa45289b99a469a

push time in 2 months ago
pull request

ryanmcdermott pull request ryanmcdermott/code-review-tips

ryanmcdermott
ryanmcdermott

Correct some minor typos in readme

A small update to correct some minor typos.

Thanks for all your hard work!

Activity icon
issue

ryanmcdermott issue google/intermock

ryanmcdermott
ryanmcdermott

Support Relative Imported Interfaces

I have:

import {Bar,Fizz} from './'

interface Foo {
 bar: Bar,
 fizz: Fizz
}

output becomes:

{
  "Foo": {
    bar: {},
    fizz: {}
  }
}

expected:

{
  "Foo": {
    bar: // Bar's mock data ,
    fizz: // Fizz's mock data 
  }
}

Can I open a PR to support this feature ? 😃

Activity icon
issue

ryanmcdermott issue comment google/intermock

ryanmcdermott
ryanmcdermott

Support Relative Imported Interfaces

Hello! I have fixed the problem References to objects between files fake as empty objects and passed ci and format. I want to know your thoughts and will focus on this project. Thanks!

ryanmcdermott
ryanmcdermott
pull request

ryanmcdermott pull request google/intermock

ryanmcdermott
ryanmcdermott

Support Relative Imported Interfaces

Hello! I have fixed the problem References to objects between files fake as empty objects and passed ci and format. I want to know your thoughts and will focus on this project. Thanks!

push

ryanmcdermott push google/intermock

ryanmcdermott
ryanmcdermott

Support Relative Imported Interfaces (#58)

Support relative imported interfaces with a new option callback to resolve imports.

commit sha: 017f52c7d71d8e9cb91c26e8d08962b32118787e

push time in 2 months ago
Activity icon
issue

ryanmcdermott issue comment google/intermock

ryanmcdermott
ryanmcdermott

Support Relative Imported Interfaces

Hello! I have fixed the problem References to objects between files fake as empty objects and passed ci and format. I want to know your thoughts and will focus on this project. Thanks!

ryanmcdermott
ryanmcdermott

Excellent work, thank you so much! One last administrative thing, can you resolve this? https://github.com/google/intermock/pull/58#issuecomment-891848287

Aug
6
2 months ago
Activity icon
issue

ryanmcdermott issue comment google/intermock

ryanmcdermott
ryanmcdermott

Support Relative Imported Interfaces

Hello! I have fixed the problem References to objects between files fake as empty objects and passed ci and format. I want to know your thoughts and will focus on this project. Thanks!

ryanmcdermott
ryanmcdermott

Thanks for modifying the webpack config! I should clarify my prior statement which is that I'm not sure how other users of this package are utilizing it and by adding a filesystem API to Intermock we will automatically make the module Node only by default. At the very least, it will require users to modify their own build settings, and it warrants bumping Intermock all the way to 1.0.

I'm leaning strongly towards keeping Intermock web compatible by default. While that necessitates the expense of bundling in an entire compiler, there could be lots of use cases out in the wild like that. An import resolver function passed in through the Options could be a happy middleground.

What are your thoughts given the opinion expressed above?

Aug
5
2 months ago
Activity icon
issue

ryanmcdermott issue comment google/intermock

ryanmcdermott
ryanmcdermott

Support Relative Imported Interfaces

Hello! I have fixed the problem References to objects between files fake as empty objects and passed ci and format. I want to know your thoughts and will focus on this project. Thanks!

ryanmcdermott
ryanmcdermott

Thanks for your contribution, this is an absolutely fantastic start! One issue I see is that because this change uses file system modules that aren't available in a browser, then this would likely break the documentation site (google.github.io/intermock/)

Another approach is to pass a function (for discussion sake we can call it resolution) which does the resolution of file imports. Essentially this could live on the Options object passed into mock. https://github.com/google/intermock/blob/1cde0067e1098243016d5f96f42f4d1e3d0c0e97/src/cli/index.ts#L73

I think your code would not need too many modifications other than to move it to the cli file and then use setImportExportSpecifier as the resolution function, I believe. https://github.com/google/intermock/blob/master/src/cli/index.ts

What are your thoughts?