saad-ali

saad-ali

Software Engineer @Google working on #Kubernetes

Member Since 7 years ago

Google, Sunnyvale

Experience Points
355
follower
Lessons Completed
1
follow
Lessons Completed
5
stars
Best Reply Awards
29
repos

47 contributions in the last year

Pinned
⚡ Container Cluster Manager
⚡ Container Storage Interface (CSI) Specification.
⚡ Sidecar container that 1) registers the CSI driver with kubelet, and 2) adds the drivers custom NodeId to a label on the Kubernetes Node API Object
⚡ Sidecar container that watches Kubernetes VolumeAttachment objects and triggers ControllerPublish/Unpublish against a CSI endpoint
⚡ Sidecar container that watches Kubernetes PersistentVolumeClaim objects and triggers CreateVolume/DeleteVolume against a CSI endpoint
⚡ Saad Ali - Misc
Activity
Apr
8
1 month ago
push

saad-ali push container-storage-interface/spec

saad-ali
saad-ali

Bump master version to 1.7 for next release

saad-ali
saad-ali

Merge pull request #506 from saad-ali/release16

Bump master version to 1.7 for next release

commit sha: ad238e5cad5a27188fcdae1ff3ace3f612638ca5

push time in 1 month ago
pull request

saad-ali pull request container-storage-interface/spec

saad-ali
saad-ali

Bump master version to 1.7 for next release

Now that CSI v1.6.0 has been cut (https://github.com/container-storage-interface/spec/releases/tag/v1.6.0), bumping version for 1.7 release. We have to do this until https://github.com/container-storage-interface/spec/issues/324 is resolved.

/assign @jdef

Apr
7
1 month ago
pull request

saad-ali merge to kubernetes/community

saad-ali
saad-ali

Fix typo in sig-storage/annual-report-2021.md

  • Remove extraneous space resulting in bad formatting in KEP work in 2021 section
  • Remove broken link in Continuing sub-section of Working groups section

/sig storage /assign @xing-yang @saad-ali

saad-ali
saad-ali

/lgtm /approve

Thanks for the PR. Please fix commit messages.

Apr
5
1 month ago
pull request

saad-ali pull request container-storage-interface/spec

saad-ali
saad-ali

Bump master version to 1.7 for next release

Now that CSI v1.6.0 has been cut (https://github.com/container-storage-interface/spec/releases/tag/v1.6.0), bumping version for 1.7 release. We have to do this until https://github.com/container-storage-interface/spec/issues/324 is resolved.

/assign @jdef

Activity icon
created branch

saad-ali in saad-ali/spec create branch release16

createdAt 1 month ago
push

saad-ali push saad-ali/spec

saad-ali
saad-ali

Bump master version to 1.6 for next release

saad-ali
saad-ali

Merge pull request #483 from saad-ali/relase15

Bump master version to 1.6 for next release

saad-ali
saad-ali

Change required capability for published_node_ids in GetVolume

Instead of PUBLISH_UNPUBLISH_VOLUME, use the LIST_VOLUMES_PUBLISHED_NODES capability to control the published_node_ids field in ControllerGetVolume. This change is to be more consistent with the existing behavior. It is a backwards-incompatible change, but the API is alpha.

Also clarify the LIST_VOLUMES_PUBLISHED_NODES docs.

saad-ali
saad-ali

Merge pull request #487 from bswartz/get-volume-published-nodes-fix

Change required capability for published_node_ids in GetVolume

saad-ali
saad-ali

GetCapacityResponse: promote maximum_volume_size

Kubernetes and several CSI drivers have been using that field for a while now and no changes to the semantic are expected, therefore the alpha status can and should be removed.

The minimum_volume_size field is not used by Kubernetes. The semantic is probably stable, but further practical experience with it might be desirable before promoting it.

saad-ali
saad-ali

fix refresh of generated Go files

"make build" did not rebuild csi.pb.go because the file existed and make wasn't told that the file depends on spec.proto.

saad-ali
saad-ali

Merge pull request #499 from pohly/maximum-volume-size

GetCapacityResponse: promote maximum_volume_size

saad-ali
saad-ali

Merge pull request #500 from pohly/fix-refresh-go

fix refresh of generated Go files

saad-ali
saad-ali

test: add github action build test

saad-ali
saad-ali

test: remove .travis.yml and fix comments

fix

fix

saad-ali
saad-ali

Merge pull request #502 from andyzhangx/build-test

test: add github action build test

saad-ali
saad-ali

test: add codespell github action

saad-ali
saad-ali

doc: set github action badge

fix

saad-ali
saad-ali

Merge pull request #503 from andyzhangx/codespell

test: add codespell github action

saad-ali
saad-ali

Merge pull request #505 from andyzhangx/set-badge

doc: set github action badge

commit sha: 1de425b860085fa0e987d8ece6fe36ed47cdebb3

push time in 1 month ago
Activity icon
created tag
createdAt 1 month ago
Activity icon
published release v1.6.0

saad-ali in container-storage-interface/spec create published release v1.6.0

createdAt 1 month ago
pull request

saad-ali merge to container-storage-interface/spec

saad-ali
saad-ali

doc: add issue and PR templates

It's better have a template for issues and PRs, we could refine the templates later. /assign @jdef @saad-ali

saad-ali
saad-ali
Mar
31
1 month ago
Activity icon
published release v1.6.0-rc1

saad-ali in container-storage-interface/spec create published release v1.6.0-rc1

createdAt 1 month ago
Activity icon
created tag
createdAt 1 month ago
Activity icon
created branch
createdAt 1 month ago
Mar
30
1 month ago
Activity icon
issue

saad-ali issue container-storage-interface/spec

saad-ali
saad-ali

Pre-submit testing and CI for CSI

CSI was previously using travis-ci for PR pre-submit testing and CI for this project. However travis-ci.org has been turned down and https://travis-ci.org/github/container-storage-interface/spec shows:

Since June 15th, 2021, the building on [travis-ci.org](http://www.travis-ci.org/) is ceased. Please use [travis-ci.com](http://www.travis-ci.com/) from now on.

We need a replacement pre-submit and CI solution. Opening this bug to track that work.

Activity icon
issue

saad-ali issue comment container-storage-interface/spec

saad-ali
saad-ali

Pre-submit testing and CI for CSI

CSI was previously using travis-ci for PR pre-submit testing and CI for this project. However travis-ci.org has been turned down and https://travis-ci.org/github/container-storage-interface/spec shows:

Since June 15th, 2021, the building on [travis-ci.org](http://www.travis-ci.org/) is ceased. Please use [travis-ci.com](http://www.travis-ci.com/) from now on.

We need a replacement pre-submit and CI solution. Opening this bug to track that work.

saad-ali
saad-ali
push

saad-ali push container-storage-interface/spec

saad-ali
saad-ali

doc: set github action badge

fix

saad-ali
saad-ali

Merge pull request #505 from andyzhangx/set-badge

doc: set github action badge

commit sha: 1de425b860085fa0e987d8ece6fe36ed47cdebb3

push time in 1 month ago
push

saad-ali push container-storage-interface/spec

saad-ali
saad-ali

test: add codespell github action

saad-ali
saad-ali

Merge pull request #503 from andyzhangx/codespell

test: add codespell github action

commit sha: c52853cb03d6d213fb156b50cb4a90303cb357c6

push time in 1 month ago
pull request

saad-ali pull request container-storage-interface/spec

saad-ali
saad-ali

test: add codespell github action

Mar
29
1 month ago
push

saad-ali push container-storage-interface/spec

saad-ali
saad-ali

test: add github action build test

saad-ali
saad-ali

test: remove .travis.yml and fix comments

fix

fix

saad-ali
saad-ali

Merge pull request #502 from andyzhangx/build-test

test: add github action build test

commit sha: de56b07ea45aa36edf6f6c5df5d001619a4ea73f

push time in 1 month ago
pull request

saad-ali pull request container-storage-interface/spec

saad-ali
saad-ali

test: add github action build test

It seems that build test result won't show in the first github action PR, and it should show in the next PR after this PR merged.

Activity icon
issue

saad-ali issue comment container-storage-interface/spec

saad-ali
saad-ali

test: add github action build test

It seems that build test result won't show in the first github action PR, and it should show in the next PR after this PR merged.

saad-ali
saad-ali

Thank you both. Let's merge and see.

Activity icon
issue

saad-ali issue comment kubernetes/community

saad-ali
saad-ali

SIG Storage annual report 2021

Which issue(s) this PR fixes:

Fixes #

Activity icon
issue

saad-ali issue comment container-storage-interface/spec

saad-ali
saad-ali

test: add github action build test

It seems that build test result won't show in the first github action PR, and it should show in the next PR after this PR merged.

Mar
18
2 months ago
Activity icon
issue

saad-ali issue comment container-storage-interface/spec

saad-ali
saad-ali

Pre-submit testing and CI for CSI

CSI was previously using travis-ci for PR pre-submit testing and CI for this project. However travis-ci.org has been turned down and https://travis-ci.org/github/container-storage-interface/spec shows:

Since June 15th, 2021, the building on [travis-ci.org](http://www.travis-ci.org/) is ceased. Please use [travis-ci.com](http://www.travis-ci.com/) from now on.

We need a replacement pre-submit and CI solution. Opening this bug to track that work.

push

saad-ali push container-storage-interface/spec

saad-ali
saad-ali

fix refresh of generated Go files

"make build" did not rebuild csi.pb.go because the file existed and make wasn't told that the file depends on spec.proto.

saad-ali
saad-ali

Merge pull request #500 from pohly/fix-refresh-go

fix refresh of generated Go files

commit sha: b09ca9e903260a0d715c6cb7766417f47b0057c6

push time in 2 months ago
pull request

saad-ali pull request container-storage-interface/spec

saad-ali
saad-ali

fix refresh of generated Go files

"make build" did not rebuild csi.pb.go because the file existed and make wasn't told that the file depends on spec.proto.

Activity icon
issue

saad-ali issue comment container-storage-interface/spec

saad-ali
saad-ali

Pre-submit testing and CI for CSI

CSI was previously using travis-ci for PR pre-submit testing and CI for this project. However travis-ci.org has been turned down and https://travis-ci.org/github/container-storage-interface/spec shows:

Since June 15th, 2021, the building on [travis-ci.org](http://www.travis-ci.org/) is ceased. Please use [travis-ci.com](http://www.travis-ci.com/) from now on.

We need a replacement pre-submit and CI solution. Opening this bug to track that work.

saad-ali
saad-ali

Sorry, kind of busy right now...

No worries, thanks for the reply @pohly

Previous