savv

savv

Member Since 10 years ago

Zurich

Experience Points
17
follower
Lessons Completed
16
follow
Lessons Completed
49
stars
Best Reply Awards
18
repos

1090 contributions in the last year

Pinned
⚡ Demo on strange webpack behavior.
⚡ Restful API on Heroku
⚡ Run NGINX in front of your app server on Heroku
⚡ Buildpack for vouch-proxy
Activity
Jan
23
2 days ago
Activity icon
created tag
createdAt 2 days ago
push

savv push greentriangle/react-native-leveldb

savv
savv

check e.message exists in install catch

commit sha: d507feb6af30326a5269cd9bc71a277fd33ce2f4

push time in 2 days ago
Activity icon
created tag
createdAt 2 days ago
Activity icon
published release Release 3.0.2

savv in greentriangle/react-native-leveldb create published release Release 3.0.2

createdAt 2 days ago
Activity icon
created tag
createdAt 2 days ago
push

savv push greentriangle/react-native-leveldb

savv
savv

Android: statically load lib, so that destruct() always works, even if no Leveldb has been initialized

commit sha: 330e960f1e4f3cd3936b04485dc0da1609019ec3

push time in 2 days ago
Jan
22
3 days ago
Activity icon
delete
deleted time in 3 days ago
push

savv push greentriangle/react-native-leveldb

savv
savv

Add sync installation method, called on the JS thread (#12)

commit sha: a2bae146657084c161905270ecf9aa9ca3ea13f1

push time in 3 days ago
pull request

savv pull request greentriangle/react-native-leveldb

savv
savv

Add sync installation method, called on the JS thread

pull request

savv pull request greentriangle/react-native-leveldb

savv
savv

Add sync installation method, called on the JS thread

push

savv push greentriangle/react-native-leveldb

savv
savv

Initialize leveldb on the JS thread to avoid race conditions in Hermes (#11)

  • Initialize leveldb on the JS thread to avoid race conditions in Hermes

  • leveldbReadFileBuf should read directly into ArrayBuffer, without using the stack

  • chore: release 2.2.2

  • chore: release v3.0.0

savv
savv

Add sync installation method, called on the JS thread

commit sha: f79d816edd3e155285d4984672945fee3042c222

push time in 3 days ago
Activity icon
created branch
createdAt 3 days ago
Activity icon
created tag
createdAt 3 days ago
Jan
21
4 days ago
Activity icon
issue

savv issue comment teslamotors/react-native-camera-kit

savv
savv

Upgrade dependencies to latest stable; show square on tap-to-focus

Summary

The goals of this change are to use the latest stable versions of the camera X API; and to bring the iOS and Android versions closer together, by showing a square on focus.

How did you test this change?

No iOS changes, but let me know if I should anyway test.

Android test: image

savv
savv

FYI - also tested on a Galaxy S7 Edge.

Activity icon
issue

savv issue comment teslamotors/react-native-camera-kit

savv
savv

Upgrade dependencies to latest stable; show square on tap-to-focus

Summary

The goals of this change are to use the latest stable versions of the camera X API; and to bring the iOS and Android versions closer together, by showing a square on focus.

How did you test this change?

No iOS changes, but let me know if I should anyway test.

Android test: image

savv
savv
Jan
20
5 days ago
pull request

savv pull request teslamotors/react-native-camera-kit

savv
savv

Upgrade dependencies to latest stable; show square on tap-to-focus

Summary

The goals of this change are to use the latest stable versions of the camera X API; and to bring the iOS and Android versions closer together, by showing a square on focus.

How did you test this change?

No iOS changes, but let me know if I should anyway test.

Android test: image

push

savv push savv/react-native-camera-kit

savv
savv

Upgrade dependencies to latest stable; show square on tap-to-focus

commit sha: 1e6d4e3192880eb1c2e04f0d29e67108e1a4f9a7

push time in 4 days ago
Activity icon
issue

savv issue comment mrousavy/react-native-vision-camera

savv
savv

🐛 Focus on tap

What were you trying to do?

Hello,

I am trying to simulate focus on tap, but the location where I tapped is newer focussed correctly.

Fresh project - ("react-native": "0.66.4", "react-native-vision-camera": "^2.12.0", ...android device) Locked portrait orientation, Camera component has marginTop:60, marginLeft:60 to better check of tap coordinates. I am using coordinates relative to Camera component rectangle as mentiond here https://mrousavy.com/react-native-vision-camera/docs/guides/focusing/

I made demo project where this problem is ilustrated. https://github.com/TasigurIshtar/RNVisionCameraTest

Thanks for your time.

Reproduceable Code

const touchII = async (event: NativeTouchEvent) => {
    let point: Point = {
      x: Math.round(event.pageX - camLocation.x),
      y: Math.round(event.pageY - camLocation.y),
    };
    await cameraRef?.current?.focus(point)     
  };

.....
 <Camera
      ref={cameraRef}
      style={{
        marginTop: 60,
        marginLeft: 60,
        width: window.width - 60,
        height: window.height - 60,
      }}
      onLayout={event => {
        const layout = event.nativeEvent.layout;
        setCamLocation({x: layout.x, y: layout.y});
      }}
      device={device}
      isActive={true}
      onTouchEnd={x => device.supportsFocus && touchII(x.nativeEvent)}
    />

What happened instead?

after tapping to the top of the bottle .focus({"x": 53, "y": 393}) -> the bottle doesn't seems to be focused. (when I was tapping more on the right site around the grayish mat, occasionaly the top of the bottle was super sharp. )

image

Relevant log output

No response

Device

Samsung Galaxy S10

VisionCamera Version

2.12.0

Additional information

savv
savv

Are you sure you are getting the coordinates right? Try:

    <TapGestureHandler onHandlerStateChange={({nativeEvent}) => {
      camera.current?.focus({x: nativeEvent.x, y: nativeEvent.y});}}>
  (your camera here)
    </TapGestureHandler>
Activity icon
issue

savv issue comment teslamotors/react-native-camera-kit

savv
savv

bug: Android v9 or lower doesn't work

Describe the bug Capture doesn't work on devices with Android version lower than 10. It literally doesn't do anything, no picture, no error either. Logging the capture function (either onBottomButtonPressed on CameraScreen, or capture() on Camera component) returns the taken picture details on Android 10 and higher versions, whereas on lower versions nothing happens.

To Reproduce Basic camera screen tested on S7 which has Android 8, on S8 with Android 9, also on emulators of Pixel 5 with all versions.

Additional context "react-native": "0.66.4", "react-native-camera-kit": "^12.0.0"

savv
savv

(Not a maintainer, just reporting back for others.)

The example app works fine for me on the following emulators:

  • Pixel XL, Android 8.1 or 9 (API 27/28, x86)
Activity icon
issue

savv issue mrousavy/react-native-vision-camera

savv
savv

🐛 takePhoto does not return on example/ app, in specific emulator

What were you trying to do?

I wanted to take a picture :)

Reproduceable Code

https://github.com/mrousavy/react-native-vision-camera/tree/main/example using
this emulator:
Device: "Pixel XL"
Image: "Android API 31 (Google APIs) x86_64"

What happened instead?

 DEBUG  state: ACTIVE
 DEBUG  state: END
 LOG  Taking photo...

and it hangs there forever.

Relevant log output

No response

Device

Emulator for "Pixel XL" using Image "Android API 31 (Google APIs) x86_64"

VisionCamera Version

HEAD

Additional information

Activity icon
issue

savv issue comment mrousavy/react-native-vision-camera

savv
savv

🐛 takePhoto does not return on example/ app, in specific emulator

What were you trying to do?

I wanted to take a picture :)

Reproduceable Code

https://github.com/mrousavy/react-native-vision-camera/tree/main/example using
this emulator:
Device: "Pixel XL"
Image: "Android API 31 (Google APIs) x86_64"

What happened instead?

 DEBUG  state: ACTIVE
 DEBUG  state: END
 LOG  Taking photo...

and it hangs there forever.

Relevant log output

No response

Device

Emulator for "Pixel XL" using Image "Android API 31 (Google APIs) x86_64"

VisionCamera Version

HEAD

Additional information

Activity icon
delete
deleted time in 5 days ago
push

savv push greentriangle/react-native-leveldb

savv
savv

Initialize leveldb on the JS thread to avoid race conditions in Hermes (#11)

  • Initialize leveldb on the JS thread to avoid race conditions in Hermes

  • leveldbReadFileBuf should read directly into ArrayBuffer, without using the stack

  • chore: release 2.2.2

  • chore: release v3.0.0

commit sha: ab246ce005784d18519c42836225ee2d0a1402a5

push time in 5 days ago
pull request

savv pull request greentriangle/react-native-leveldb

savv
savv

Initialize leveldb on the JS thread to avoid race conditions in Hermes

pull request

savv pull request teslamotors/react-native-camera-kit

savv
savv

package.json should have source path

This is required by the example's babel config.

Summary

This makes it easier to run the example, see babel.config.js.

How did you test this change?

I ran the example.

push

savv push savv/react-native-camera-kit

savv
savv

package.json should have source path

This is required by the example's babel config.

commit sha: 6506669062cc3874ef57a1fe2164eea0f873e014

push time in 5 days ago
Previous