sous-chefs

sous-chefs

Community of @chef cookbook maintainers

Member Since 6 years ago

Worldwide

Experience Points
0
follower
Lessons Completed
0
follow
Best Reply Awards
169
repos
Jun
23
7 hours ago
started
started time in 1 hour ago
pull request

ramereth merge to sous-chefs/terraform-github-membership

ramereth
ramereth

Add detjensrobert to maintainers

Signed-off-by: Robert Detjens detjensrobert@osuosl.org

Description

Adds @detjensrobert (me) to Sous Chefs maintainers.

Jun
22
1 day ago
pull request

detjensrobert pull request sous-chefs/terraform-github-membership

detjensrobert
detjensrobert

Add detjensrobert to maintainers

Signed-off-by: Robert Detjens detjensrobert@osuosl.org

Description

Adds me (@detjensrobert) to Sous Chefs maintainers.

Activity icon
fork

detjensrobert forked sous-chefs/terraform-github-membership

⚡ Membership for the Sous-Chefs GitHub Organisation
detjensrobert Apache License 2.0 Updated
fork time in 9 hours ago
Activity icon
issue

ramereth issue comment sous-chefs/traefik

ramereth
ramereth

Add unified_mode to resources and complete Sous-Chefs adoption

Description

Add unified_mode to resources and complete Sous-Chefs adoption.

Issues Resolved

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
ramereth
ramereth

@damacus this should probably lose the dep on the systemd cookbook and switch to using the systemd_unit native resource.

Activity icon
fork

newatlantis forked sous-chefs/yum

⚡ Development repository for the yum cookbook
newatlantis Apache License 2.0 Updated
fork time in 10 hours ago
Activity icon
issue

ramereth issue comment sous-chefs/users

ramereth
ramereth

Allow a user to be in a group of the same name

Description

Allows a given user to be in a group of the same name, that is already created or explicitly defined in its 'groups' key.

Additionally fixes an issue with a test expecting nil but finding ""

Issues Resolved

https://github.com/sous-chefs/users/pull/452

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
ramereth
ramereth

@cgunther does this properly resolve your issue that you described in #452?

Activity icon
issue

kitchen-porter issue comment sous-chefs/vcruntime

kitchen-porter
kitchen-porter

Issue 47

Description

Correctly installs and removes packages.

Issues Resolved

#47

Check List

  • [] All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
kitchen-porter
kitchen-porter
1 Warning
:warning: This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

pull request

derekgroh pull request sous-chefs/vcruntime

derekgroh
derekgroh

Issue 47

Description

Correctly installs and removes packages.

Issues Resolved

#47

Check List

  • [] All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
pull request

Wicaeed merge to sous-chefs/haproxy

Wicaeed
Wicaeed

Adding Prom Exporter compile flag

Description

HAProxy 2.4 adds a Makefile argument to enable the HAProxy built-in Prometheus exporter. Previously this was a multi-step process. Only works in HAProxy versions 2.4+

Issues Resolved

None

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
open pull request

Wicaeed wants to merge sous-chefs/haproxy

Wicaeed
Wicaeed

Adding Prom Exporter compile flag

Description

HAProxy 2.4 adds a Makefile argument to enable the HAProxy built-in Prometheus exporter. Previously this was a multi-step process. Only works in HAProxy versions 2.4+

Issues Resolved

None

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
Wicaeed
Wicaeed

Overzealous application of markdown lint, it looks like :)

pull request

JHBoricua pull request sous-chefs/sql_server

JHBoricua
JHBoricua

set env flag to allow chef install to complete in ci jobs

Signed-off-by: Jose Hernandez jhboricua@gmail.com

Description

The CI jobs that install chef are failing due to the add-path deprecation as explained here: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands

This PR is to set the ENV var that should allow the chef-install action in the ci jobs to complete.

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
Activity icon
issue

JHBoricua issue sous-chefs/sql_server

JHBoricua
JHBoricua

SQL fails to install when defining domain accounts for services?

:ghost: Brief Description

Hello. I'm testing a cookbook via kitchen that calls the sql_server_install resource. The installation of SQL fails when I define a domain account to run the Sql server and Agent services, but succeeds when I don't.

:pancakes: Cookbook version

6.2.1

:woman_cook: Chef-Infra Version

17.1.35

:tophat: Platform details

Windows Server 2016

Steps To Reproduce

  • Create test kitchen instance, instance is domain joined as part of the creation process
  • converge cookbook

The cookbook does the following:

  • Maps network share containing setup files to X:
  • Calls the sql_server_install resource with the following params:
sql_server_install do
  accept_eula true
  agent_account 'mydomain\\sqlagent'
  agent_account_pwd '******'
  agent_startup 'Automatic'
  feature %w(SQLENGINE FULLTEXT CONN BC)
  install_dir 'S:\\Program Files\\Microsoft SQL Server'
  instance_dir 'S:\\Program Files\\Microsoft SQL Server'
  instance_name 'MSSQLSERVER'
  netfx35_install false
  product_key '88888-88888-88888-88888-88888'
  sa_password '***********'
  security_mode 'Mixed Mode Authentication'
  source_url 'X:\\setup.exe'
  sql_account 'mydomain\\sqlsrvr'
  sql_account_pwd '******'
  sql_backup_dir 'R:\\Backups'
  sql_collation 'SQL_Latin1_General_CP1_CI_AS'
  sql_temp_db_dir 'T:\\Data'
  sql_temp_db_log_dir 'G:\\Logs'
  sql_user_db_dir 'D:\\Data'
  sql_user_db_log_dir 'G:\\Logs'
  sysadmins ['mydomain\\dba', 'mydomain\\sqldm']
  version '2017'
end

:police_car: Expected behavior

SQL should install successfully and the defined domain accounts above should be running the SQL server and Agent services. Instead the install fails.

If I call the install resource above without the agent_account, agent_account_pwd, sql_account and sql_account_pwd defined, which causes the install to use the built-in local accounts instead to run the services, the installation is successful.

The SQL bootstrap log (full output in link below) shows an access denied error:

Overall summary:
  Final result:                  Failed: see details below
  Exit code (Decimal):           -2061762559
  Exit facility code:            1308
  Exit error code:               1
  Exit message:                  Access is denied.  
  Start time:                    2021-05-21 23:26:41
  End time:                      2021-05-21 23:27:40
  Requested action:              Install

:heavy_plus_sign: Additional context

  • I've verified the validity of the passwords for the domain service accounts
  • I've looked at the generated ConfigurationFile.ini that the cookbook generates and it looks correct when compared to one generated by a manual installation.
  • The chef run output is here: https://pastebin.com/6Qn6jUwr
  • The SQL bootstrap log is here: https://pastebin.com/JeDaqGKW
started
started time in 17 hours ago
Activity icon
issue

StanislavBabkin issue comment sous-chefs/mysql

StanislavBabkin
StanislavBabkin

autoconfiguration hangs on cookbooks/mysql/libraries/mysql_service_base.rb line 91

autoconfiguration hangs on cookbooks/mysql/libraries/mysql_service_base.rb line 91

Cookbook version mysql 10.1.3 Version of chef-client 17.0.242 OS Ubuntu 20.04

Steps to reproduce the behavior:

mysql_service 'epc' do
  initial_root_password node.run_state['root_pass']
  bind_address node['rds_epc']['bind_address']
  action [:create, :start]
end

ruby_block 'wait for service start' do
  block do
    sleep(30)
  end
  action :run
end

if node.run_state['rds_mode'] == 'service'
  mariadb_database node.run_state['db_name'] do
    password node.run_state['root_pass']
    host '127.0.0.1'
    user 'root'
    action :create
  end

  mariadb_user node.run_state['db_user'] do
    ctrl_password node.run_state['root_pass']
    database_name node.run_state['db_name']
    password node.run_state['user_pass']
    ctrl_host '127.0.0.1'
    host '%'
    action [:create, :grant]
  end
end
StanislavBabkin
StanislavBabkin

also when I try to use custom mysql_service

mysql_service 'epc' do
  initial_root_password node.run_state['root_pass']
  bind_address node['rds_epc']['bind_address']
  action [:create, :start]
end
 

    Compiled Resource:
    ------------------
    

    mysql_service("epc") do
      action [:create, :start]
      updated true
      updated_by_last_action true
      default_guard_interpreter :default
      declared_type :mysql_service
      cookbook_name "rds_epc"
      recipe_name "mysql"
      initial_root_password "1J0cChMOhBEuO46G"
      bind_address "0.0.0.0"
      install_method "auto"
      service_manager "auto"
    end

auto-configuration hangs on resource bash[epc initial records] (mysql/libraries/mysql_service_base.rb line 91 )

image

and after 3600s get error

* service[epc apparmor] action nothing[2021-06-22T12:09:42+00:00] INFO: Processing service[epc apparmor] action nothing (/var/chef/cache/cookbooks/mysql/libraries/mysql_service_base.rb line 175)
 (skipped due to action :nothing)
      * bash[epc initial records] action run[2021-06-22T12:09:42+00:00] INFO: Processing bash[epc initial records] action run (/var/chef/cache/cookbooks/mysql/libraries/mysql_service_base.rb line 91)


        ================================================================================
        Error executing action `run` on resource 'bash[epc initial records]'
        ================================================================================

        Mixlib::ShellOut::CommandTimeout
        --------------------------------
        Command timed out after 3600s:
        Command exceeded allowed execution time, process terminated
        ---- Begin output of "bash"  ----
        STDOUT:
        STDERR:
        ---- End output of "bash"  ----
        Ran "bash"  returned

        Resource Declaration:
        ---------------------
        # In /var/chef/cache/cookbooks/mysql/libraries/mysql_service_base.rb

         91:         bash "#{new_resource.name} initial records" do
         92:           code init_records_script
         93:           umask '022'
         94:           returns [0, 1, 2] # facepalm
         95:           not_if { db_initialized? }
         96:           action :run
         97:         end
         98:       end

        Compiled Resource:
        ------------------
        # Declared in /var/chef/cache/cookbooks/mysql/libraries/mysql_service_base.rb:91:in `initialize_database'

        bash("epc initial records") do
          action [:run]
          default_guard_interpreter :default
          interpreter "bash"
          declared_type :bash
          cookbook_name "rds_epc"
          code "        set -e\n        rm -rf /tmp/mysql-epc\n        mkdir /tmp/mysql-epc\n        cat > /tmp/mysql-epc/my.sql <<-'EOSQL'\nALTER USER 'root'@'localhost' IDENTIFIED BY '1J0cChMOhBEuO46G';\nDELETE FROM mysql.user WHERE USER LIKE '';\nDELETE FROM mysql.user WHERE user = 'root' and host NOT IN ('127.0.0.1', 'localhost');\nFLUSH PRIVILEGES;\nDELETE FROM mysql.db WHERE db LIKE 'test%';\nDROP DATABASE IF EXISTS test ;\nEOSQL\n       /usr/sbin/mysqld --defaults-file=/etc/mysql-epc/my.cnf --initialize --explicit_defaults_for_timestamp\n       /usr/sbin/mysqld --defaults-file=/etc/mysql-epc/my.cnf --init-file=/tmp/mysql-epc/my.sql --explicit_defaults_for_timestamp &\n       while [ ! -f /run/mysql-epc/mysqld.pid ] ; do sleep 1 ; done\n       kill `cat /run/mysql-epc/mysqld.pid`\n       while [ -f /run/mysql-epc/mysqld.pid ] ; do sleep 1 ; done\n       rm -rf /tmp/mysql-epc\n"
          umask "022"
          returns [0, 1, 2]
          domain nil
          user nil
          not_if { #code block }
        end

        System Info:
        ------------
        chef_version=17.0.242
        platform=ubuntu
        platform_version=20.04
        ruby=ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x86_64-linux]
        program_name=/usr/bin/chef-client
        executable=/opt/chef/bin/chef-client

[2021-06-22T13:10:42+00:00] INFO: Running queued delayed notifications before re-raising exception

      ================================================================================
      Error executing action `create` on resource 'mysql_service_manager_systemd[epc]'
      ================================================================================

      Mixlib::ShellOut::CommandTimeout
      --------------------------------
      bash[epc initial records] (/var/chef/cache/cookbooks/mysql/libraries/mysql_service_base.rb line 91) had an error: Mixlib::ShellOut::CommandTimeout: Command timed out after 3600s:
      Command exceeded allowed execution time, process terminated
      ---- Begin output of "bash"  ----
      STDOUT:
      STDERR:
      ---- End output of "bash"  ----
      Ran "bash"  returned

      Resource Declaration:
      ---------------------
      # In /var/chef/cache/cookbooks/mysql/libraries/mysql_service.rb

       51:           svc = mysql_service_manager(new_resource.name, &block)
       52:         when 'sysvinit'

      Compiled Resource:
      ------------------
      # Declared in /var/chef/cache/cookbooks/mysql/libraries/mysql_service.rb:51:in `svc_manager'

      mysql_service_manager_systemd("epc") do
        action [:create]
        updated true
        updated_by_last_action true
        default_guard_interpreter :default
        declared_type :mysql_service_manager
        cookbook_name "rds_epc"
        bind_address "0.0.0.0"
        initial_root_password "1J0cChMOhBEuO46G"
        instance "epc"
        include_dir "/etc/mysql-epc/conf.d"
        data_dir "/var/lib/mysql-epc"
        run_user "mysql"
        run_group "mysql"
        version "8.0"
        pid_file "/run/mysql-epc/mysqld.pid"
        charset "utf8"
        port "3306"
        socket "/run/mysql-epc/mysqld.sock"
        error_log "/var/log/mysql-epc/error.log"
      end

      System Info:
      ------------
      chef_version=17.0.242
      platform=ubuntu
      platform_version=20.04
      ruby=ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x86_64-linux]
      program_name=/usr/bin/chef-client
      executable=/opt/chef/bin/chef-client

[2021-06-22T13:10:42+00:00] INFO: Running queued delayed notifications before re-raising exception

    ================================================================================
    Error executing action `create` on resource 'mysql_service[epc]'
    ================================================================================

    Mixlib::ShellOut::CommandTimeout
    --------------------------------
    mysql_service_manager_systemd[epc] (/var/chef/cache/cookbooks/mysql/libraries/mysql_service.rb line 51) had an error: Mixlib::ShellOut::CommandTimeout: bash[epc initial records] (/var/chef/cache/cookbooks/mysql/libraries/mysql_service_base.rb line 91) had an error: Mixlib::ShellOut::CommandTimeout: Command timed out after 3600s:
    Command exceeded allowed execution time, process terminated
    ---- Begin output of "bash"  ----
    STDOUT:
    STDERR:
    ---- End output of "bash"  ----
    Ran "bash"  returned

    Resource Declaration:
    ---------------------
    # In /var/chef/cache/cookbooks/rds_epc/recipes/mysql.rb

     10: mysql_service 'epc' do
     11:   initial_root_password node.run_state['root_pass']
     12:   bind_address node['rds_epc']['bind_address']
     13:   action [:create, :start]
     14: end
     15:

    Compiled Resource:
    ------------------
    # Declared in /var/chef/cache/cookbooks/rds_epc/recipes/mysql.rb:10:in `from_file'

    mysql_service("epc") do
      action [:create, :start]
      updated true
      updated_by_last_action true
      default_guard_interpreter :default
      declared_type :mysql_service
      cookbook_name "rds_epc"
      recipe_name "mysql"
      initial_root_password "1J0cChMOhBEuO46G"
      bind_address "0.0.0.0"
      install_method "auto"
      service_manager "auto"
    end

    System Info:
    ------------
    chef_version=17.0.242
    platform=ubuntu
    platform_version=20.04
    ruby=ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x86_64-linux]
    program_name=/usr/bin/chef-client
    executable=/opt/chef/bin/chef-client

at the same time, there are errors in the mysql error logs image

I think the problem is that when installing mysql, mysql service run by default and block custom

I use: Cookbook version mysql 10.1.3 Version of chef-client 17.0.242 OS Ubuntu 20.04

push

Xorima push sous-chefs/terraform-github-repository

Xorima
Xorima

Delete tf-import.ps1

This file is not required and should not have been checked in.

commit sha: e1d0f49ae26eba6bb073711c75fbacfd2188799b

push time in 19 hours ago
push

damacus push sous-chefs/traefik

damacus
damacus

Add unified_mode to resources and complete Sous-Chefs adoption

Signed-off-by: Dan Webb dan.webb@damacus.io

commit sha: 8d08338fb05d32741e292fa773aaa8c7b66344e1

push time in 20 hours ago
Activity icon
issue

kitchen-porter issue comment sous-chefs/traefik

kitchen-porter
kitchen-porter

Add unified_mode to resources and complete Sous-Chefs adoption

Description

Add unified_mode to resources and complete Sous-Chefs adoption.

Issues Resolved

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
kitchen-porter
kitchen-porter
1 Error
:no_entry_sign: Please include a CHANGELOG entry.
1 Warning
:warning: This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

pull request

damacus pull request sous-chefs/traefik

damacus
damacus

Add unified_mode to resources and complete Sous-Chefs adoption

Description

Add unified_mode to resources and complete Sous-Chefs adoption.

Issues Resolved

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
Activity icon
issue

bmhughes issue comment sous-chefs/firewall

bmhughes
bmhughes

CentOS 8 default firewall provider is firewalld not iptables

:ghost: Brief Description

CentOS 8 configures iptables instead of firewalld. Breaking any existing configuration from 2.7.1 version of this cookbook.

:pancakes: Cookbook version

3.0.0

:woman_cook: Chef-Infra Version

16.13.16

:tophat: Platform details

CentOS/RHEL 8

Steps To Reproduce

Steps to reproduce the behavior:

Install firewall by this cookbook on CentOS 8 platform will install iptables instead of firewalld.

:police_car: Expected behavior

Configure firewalld.

:heavy_plus_sign: Additional context

In Version 2.7.1 of this cookbook, CentOS 8 will be configured with firewalld.

Question

This change is not compatible with the CentOS 8, why was firewalld support for RHEL 8 dropped?

bmhughes
bmhughes

RedHat documentation 48.1.1 Actually recommends nftables which is a derivative of iptables and installs/configures the same as iptables.

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/configuring_and_managing_networking/getting-started-with-nftables_configuring-and-managing-networking

The firewall cookbook previously was updated in 2018 when RHEL7 was out and way before RHEL8 came out in 2019. In RHEL7 firewalld was the default installed firewall but in RHEL8 and above default install doesn't install any and expects you to choose one at which they recommend nftables then unless you have a lot of scripts and automation built around firewalld. The cookbooks resources used a lot of version constraints and resources had version constraints simply set to >= rhel7, my guess due to expecting firewalld to be the default for future rhel versions.

firewalld wasn't dropped but default was updated to reflect current recommended firewall. The firewall resources in here need to be updated to modern chef resource patterns and should be split into seperate iptables, firewalld, nftables, ufw, windows firewall, etc... and let users choose which firewall to install and configure. you can lock version to ~>2.x to maintain previous functionality and default.

On the subject of firewalld it's my understanding that it's just a wrapper around iptables to provide a basic zone-based functionality rather than being a firewall itself and hooking into netfilter so it should apply to nftables as well as iptables at a higher level rather than being a replacement so it's not mutually exclusive there and you could still use it. (Personally it's the first thing I uninstall)

I looked at nftables a while ago (for the waiting PR on iptables) and it's probably a slight improvement over iptables from a cookbook perspective as you can accumulate a single configuration file but annoyingly it's still a custom format.

Activity icon
created branch

damacus in sous-chefs/traefik create branch unified-mode

createdAt 21 hours ago
open pull request

bmhughes wants to merge sous-chefs/haproxy

bmhughes
bmhughes

Adding Prom Exporter compile flag

Description

HAProxy 2.4 adds a Makefile argument to enable the HAProxy built-in Prometheus exporter. Previously this was a multi-step process. Only works in HAProxy versions 2.4+

Issues Resolved

None

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
pull request

bmhughes merge to sous-chefs/haproxy

bmhughes
bmhughes

Adding Prom Exporter compile flag

Description

HAProxy 2.4 adds a Makefile argument to enable the HAProxy built-in Prometheus exporter. Previously this was a multi-step process. Only works in HAProxy versions 2.4+

Issues Resolved

None

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
pull request

bmhughes merge to sous-chefs/haproxy

bmhughes
bmhughes

Adding Prom Exporter compile flag

Description

HAProxy 2.4 adds a Makefile argument to enable the HAProxy built-in Prometheus exporter. Previously this was a multi-step process. Only works in HAProxy versions 2.4+

Issues Resolved

None

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
Activity icon
issue

StanislavBabkin issue comment sous-chefs/mysql

StanislavBabkin
StanislavBabkin

autoconfiguration hangs on cookbooks/mysql/libraries/mysql_service_base.rb line 91

autoconfiguration hangs on cookbooks/mysql/libraries/mysql_service_base.rb line 91

Cookbook version mysql 10.1.3 Version of chef-client 17.0.242 OS Ubuntu 20.04

Steps to reproduce the behavior:

mysql_service 'epc' do
  initial_root_password node.run_state['root_pass']
  bind_address node['rds_epc']['bind_address']
  action [:create, :start]
end

ruby_block 'wait for service start' do
  block do
    sleep(30)
  end
  action :run
end

if node.run_state['rds_mode'] == 'service'
  mariadb_database node.run_state['db_name'] do
    password node.run_state['root_pass']
    host '127.0.0.1'
    user 'root'
    action :create
  end

  mariadb_user node.run_state['db_user'] do
    ctrl_password node.run_state['root_pass']
    database_name node.run_state['db_name']
    password node.run_state['user_pass']
    ctrl_host '127.0.0.1'
    host '%'
    action [:create, :grant]
  end
end
StanislavBabkin
StanislavBabkin

@ramereth, here is my recipe

mysql_service 'default' do
  bind_address node['rds_epc']['bind_address']
  port node['rds_epc']['mysqld']['port']
  initial_root_password node.run_state['root_pass']
  action [:create, :start]
end

ruby_block 'wait for service start' do
  block do
    sleep(30)
  end
  action :run
end

if node.run_state['rds_mode'] == 'service'

  mysql_database node.run_state['db_name'] do
    host '127.0.0.1'
    port node['rds_epc']['mysqld']['port'].to_i
    user 'root'
    password node.run_state['root_pass']
    action :create
  end

  mysql_user node.run_state['db_user'] do
    ctrl_password node.run_state['root_pass']
    ctrl_host '127.0.0.1'
    ctrl_port node['rds_epc']['mysqld']['port'].to_i
    password node.run_state['user_pass']
    database_name node.run_state['db_name']
    host '%'
    privileges [:select,:update,:insert]
    action [:create, :grant]
  end
end

when I use this I get error image

push

damacus push sous-chefs/sc_vscode

damacus
damacus

Unified Mode and MacOS testing

Signed-off-by: Dan Webb dan.webb@damacus.io

commit sha: b31c2fbb035a3d8a1379178d4164ee557f6a67d4

push time in 22 hours ago
pull request

damacus pull request sous-chefs/sc_vscode

damacus
damacus

Unified Mode and MacOS testing

Description

Adds unified_mode to all resources Add MacOs testing

Issues Resolved

Cookbook does not work on Chef 17

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
Activity icon
created branch

damacus in sous-chefs/sc_vscode create branch unified-mode-macos-testing

createdAt 22 hours ago
Activity icon
issue

kitchen-porter issue comment sous-chefs/samba

kitchen-porter
kitchen-porter

Remove delayed_action, action and cookbook settings

from the share resource as these are not required

Signed-off-by: Dan Webb dan.webb@damacus.io

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.
kitchen-porter
kitchen-porter
1 Warning
:warning: This Pull Request is probably missing tests.

Generated by :no_entry_sign: Danger

push

damacus push sous-chefs/samba

damacus
damacus

Update CHANGELOG.md

Co-authored-by: Lance Albertson lance@osuosl.org

commit sha: 38c27ccbc83aa74f92bec2ce4a86b43cdc8fdf63

push time in 23 hours ago