Without investing it thoroughly, my best guess is that two different dependencies Viper imports each specify a different protobuf library and Go is ok with satisfying both requirements without creating a diamond dependency problem.
Pinned
Activity
spf13 issue comment spf13/cobra
Rename 'master' branch to 'main'
I suggest that we follow the wider git/github community trend and rename Cobra's 'master' branch to 'main'. Renaming a branch is well handled by Github. Github will even automatically redirect requests made to the old branch towards the new branch. Details can be found here: https://github.com/github/renaming
The helm organisation has renamed all its repos' main branches and it has been a very smooth effort.
How do the maintainers and community feel about that?
100% support this. I didn’t realize it was so easy to do now. I should do it for all my projects. I’m on holiday now but will do it when I return.
On Fri, Feb 25, 2022 at 8:40 AM Marc Khouzam ***@wrote:
I just did it on one of my repos, it took 20 seconds but it does require each local clone to be updated, but Github tells each user how to do it when they visit the projet page.
Here is what I did: 1- On the projet Github page go to Settings -> Branches and click the pencil on the top box to rename to main
[image: Screen Shot 2022-02-25 at 8 26 50 AM] https://user-images.githubusercontent.com/414402/155724164-c5106385-19d6-4cd9-963f-6efa19ee2af3.png
2- When visiting the main project page Github tells each user how to fix their clone:
[image: Screen Shot 2022-02-25 at 8 28 18 AM] https://user-images.githubusercontent.com/414402/155724704-bee2864c-17d6-4642-8a86-411eb4da42c5.png
@spf13 https://github.com/spf13 what do you think?
— Reply to this email directly, view it on GitHub https://github.com/spf13/cobra/issues/1611#issuecomment-1050862624, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABKKZHK6UZMTW7Y2C7WYHTU46BDVANCNFSM5PIKLNAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
Why all the new dependencies?
Why do I need GRPC for configuration?
The commit that did this, https://github.com/spf13/viper/commit/b5bf975e5823809fb22c7644d008757f78a4259e, added
24
dependencies, while only removing5
to thego.mod
and a rather large148
additions to5
deletions in thego.sum
I believe it is the "remote" feature that is causing all of these imports, but I'm not sure. Perhaps that feature should be behind a build tag? Or perhaps it's introduction should be considered a breaking change?
cc @spf13