spf13

spf13

13x engineer • @golang Product Lead @Google • Prior EVP @Docker, @MongoDB, @Drupal board • @gohugoio, Cobra & spf13-vim creator

Member Since 12 years ago

@Google, NYC

Experience Points
1.17w
follower
Lessons Completed
78
follow
Lessons Completed
801
stars
Best Reply Awards
104
repos

155 contributions in the last year

Pinned
⚡ The Go programming language
⚡ The world’s fastest framework for building websites.
⚡ The ultimate vim distribution
⚡ A Commander for modern Go CLI interactions
⚡ Go configuration with fangs
⚡ A FileSystem Abstraction System for Go
Activity
May
16
3 days ago
started
started time in 3 days ago
May
12
1 week ago
started
started time in 1 week ago
started
started time in 1 week ago
Apr
28
3 weeks ago
started
started time in 3 weeks ago
Mar
5
2 months ago
Activity icon
issue

spf13 issue comment spf13/viper

spf13
spf13

Why all the new dependencies?

module github.com/spf13/viper

require (
	github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6 // indirect
	github.com/coreos/bbolt v1.3.2 // indirect
	github.com/coreos/etcd v3.3.10+incompatible // indirect
	github.com/coreos/go-semver v0.2.0 // indirect
	github.com/coreos/go-systemd v0.0.0-20190321100706-95778dfbb74e // indirect
	github.com/coreos/pkg v0.0.0-20180928190104-399ea9e2e55f // indirect
	github.com/dgrijalva/jwt-go v3.2.0+incompatible // indirect
	github.com/fsnotify/fsnotify v1.4.7
	github.com/gogo/protobuf v1.2.1 // indirect
	github.com/golang/groupcache v0.0.0-20190129154638-5b532d6fd5ef // indirect
	github.com/google/btree v1.0.0 // indirect
	github.com/gorilla/websocket v1.4.0 // indirect
	github.com/grpc-ecosystem/go-grpc-middleware v1.0.0 // indirect
	github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0 // indirect
	github.com/grpc-ecosystem/grpc-gateway v1.9.0 // indirect
	github.com/hashicorp/hcl v1.0.0
	github.com/jonboulle/clockwork v0.1.0 // indirect
	github.com/magiconair/properties v1.8.0
	github.com/mitchellh/mapstructure v1.1.2
	github.com/pelletier/go-toml v1.2.0
	github.com/prometheus/client_golang v0.9.3 // indirect
	github.com/soheilhy/cmux v0.1.4 // indirect
	github.com/spf13/afero v1.1.2
	github.com/spf13/cast v1.3.0
	github.com/spf13/jwalterweatherman v1.0.0
	github.com/spf13/pflag v1.0.3
	github.com/stretchr/testify v1.2.2
	github.com/tmc/grpc-websocket-proxy v0.0.0-20190109142713-0ad062ec5ee5 // indirect
	github.com/ugorji/go v1.1.4 // indirect
	github.com/xiang90/probing v0.0.0-20190116061207-43a291ad63a2 // indirect
	github.com/xordataexchange/crypt v0.0.3-0.20170626215501-b2862e3d0a77
	go.etcd.io/bbolt v1.3.2 // indirect
	go.uber.org/atomic v1.4.0 // indirect
	go.uber.org/multierr v1.1.0 // indirect
	go.uber.org/zap v1.10.0 // indirect
	golang.org/x/net v0.0.0-20190522155817-f3200d17e092 // indirect
	golang.org/x/time v0.0.0-20190308202827-9d24e82272b4 // indirect
	google.golang.org/grpc v1.21.0 // indirect
	gopkg.in/yaml.v2 v2.2.2
)

Why do I need GRPC for configuration?

The commit that did this, https://github.com/spf13/viper/commit/b5bf975e5823809fb22c7644d008757f78a4259e, added 24 dependencies, while only removing 5 to the go.mod and a rather large 148 additions to 5 deletions in the go.sum

I believe it is the "remote" feature that is causing all of these imports, but I'm not sure. Perhaps that feature should be behind a build tag? Or perhaps it's introduction should be considered a breaking change?

cc @spf13

spf13
spf13

Without investing it thoroughly, my best guess is that two different dependencies Viper imports each specify a different protobuf library and Go is ok with satisfying both requirements without creating a diamond dependency problem.

Feb
26
2 months ago
Activity icon
issue

spf13 issue comment spf13/cobra

spf13
spf13

Rename 'master' branch to 'main'

I suggest that we follow the wider git/github community trend and rename Cobra's 'master' branch to 'main'. Renaming a branch is well handled by Github. Github will even automatically redirect requests made to the old branch towards the new branch. Details can be found here: https://github.com/github/renaming

The helm organisation has renamed all its repos' main branches and it has been a very smooth effort.

How do the maintainers and community feel about that?

spf13
spf13

100% support this. I didn’t realize it was so easy to do now. I should do it for all my projects. I’m on holiday now but will do it when I return.

On Fri, Feb 25, 2022 at 8:40 AM Marc Khouzam ***@wrote:

I just did it on one of my repos, it took 20 seconds but it does require each local clone to be updated, but Github tells each user how to do it when they visit the projet page.

Here is what I did: 1- On the projet Github page go to Settings -> Branches and click the pencil on the top box to rename to main

[image: Screen Shot 2022-02-25 at 8 26 50 AM] https://user-images.githubusercontent.com/414402/155724164-c5106385-19d6-4cd9-963f-6efa19ee2af3.png

2- When visiting the main project page Github tells each user how to fix their clone:

[image: Screen Shot 2022-02-25 at 8 28 18 AM] https://user-images.githubusercontent.com/414402/155724704-bee2864c-17d6-4642-8a86-411eb4da42c5.png

@spf13 https://github.com/spf13 what do you think?

— Reply to this email directly, view it on GitHub https://github.com/spf13/cobra/issues/1611#issuecomment-1050862624, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABKKZHK6UZMTW7Y2C7WYHTU46BDVANCNFSM5PIKLNAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

Feb
21
2 months ago