stephensli

stephensli

Software Engineer | Indoor enthusiast

Member Since 7 years ago

Deliveroo, United Kingdom

Experience Points
17
follower
Lessons Completed
35
follow
Lessons Completed
156
stars
Best Reply Awards
33
repos

921 contributions in the last year

Pinned
⚡ 🎄 My solutions for Advent of Code (https://adventofcode.com) and related helpers.
⚡ All my current solutions for problem sets that are hosted at https://open.kattis.com
⚡ Mavic is a CLI application designed to download direct images found on selected reddit subreddits.
⚡ Samsung TV API Wrapper for communicating via Rest, Websocket and Soap (UpNp)
⚡ DevWars Node API
⚡ Javascript bindings for the Solidity compiler
Activity
May
17
3 days ago
Activity icon
issue

stephensli issue comment ethereum/solc-js

stephensli
stephensli

Add common helper file to package.json.

Might fix https://github.com/ethereum/solc-js/issues/622.

I guess this is enough to fix the issue, but maybe better if @cameel and/or @stephensli confirmed.

stephensli
stephensli

@cameel I would not invest much effort as #614 updates the exported files.

Activity icon
issue

stephensli issue comment ethereum/solc-js

stephensli
stephensli

Add common helper file to package.json.

Might fix https://github.com/ethereum/solc-js/issues/622.

I guess this is enough to fix the issue, but maybe better if @cameel and/or @stephensli confirmed.

stephensli
stephensli

@cameel this will do it, please just do a npm build-tarball and check the tarball output to see if the content contains everything required. If anything else is missing (hopefully not) include it in this PR @ekpyron

Activity icon
issue

stephensli issue comment ethereum/solc-js

stephensli
stephensli

`Uncaught Error: Cannot find module './common/helpers'` on 0.8.14

Looks like the helpers added in #603 were not added to the package so trying to import it fails:

npm install [email protected]
node_modules/solc/solc.js --version
Error: Cannot find module './common/helpers'

Also:

node -e 'require("solc")'
Error: Cannot find module './common/helpers'

Also, we need to investigate why this didn't fail any tests. We specifically build the package in CI and install it and that test should have caught it.

stephensli
stephensli

@cameel I will look into this later today or tomorrow.

May
10
1 week ago
started
started time in 1 week ago
May
9
1 week ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Add type support to wrapper.ts and solc module

commit sha: 95ca828113de3b25021b64ac8f1d511fd5a74d40

push time in 1 week ago
May
7
1 week ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability by splitting and documenting

stephensli
stephensli

Add type support to wrapper.ts and solc module

commit sha: 5d1ee39bbef063596fb687692cf46ab842651ddd

push time in 1 week ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability by splitting and documenting

commit sha: 5cce8a2007f7e7856a777334bffd5df658de53b3

push time in 1 week ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability by splitting and documenting

commit sha: 2c276a9333f7c8c111eab33ed25d00ec4977983c

push time in 1 week ago
open pull request

stephensli wants to merge ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

pull request

stephensli merge to ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

May
5
2 weeks ago
May
4
2 weeks ago
May
1
2 weeks ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability by splitting and documenting

stephensli
stephensli

Add type support to wrapper.ts and solc module

commit sha: d6632e49f8df796deb323c06b73c63868517176c

push time in 2 weeks ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability by splitting and documenting

commit sha: d8769f20a92c511e1bafd09a26af4980d01a58b8

push time in 2 weeks ago
open pull request

stephensli wants to merge ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

pull request

stephensli merge to ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

open pull request

stephensli wants to merge ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

pull request

stephensli merge to ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

open pull request

stephensli wants to merge ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

pull request

stephensli merge to ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

open pull request

stephensli wants to merge ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

pull request

stephensli merge to ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

pull request

stephensli merge to ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

open pull request

stephensli wants to merge ethereum/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability

Why?

This change works on refactoring out the wrapper.ts file to allow improved maintainability, extensibility with support of easy typing. The current implementation is one continuous function call which allocates all the bindings with hard to follow scoping.

Any bindings of methods have been split out into the binding directly, currently containing the core (anything not compiler related) and compiler related bound functions.

Whats Next?

Since the wrapper is the main entry point for most consumers of the service, this should allow cleanly defined types to be exported with the package. Allowing language servers and IDEs to consume the types and expose them to the user for an improved experience.

  • The callback implementation to apply changes based on some additional input arguments can now be tackled as it can be harder to follow. I was going to do it in this PR but it was outside of the scope.

This has been done here #615

stephensli
stephensli

@cameel this creates a lot of additional implementation detail that adds more complexity than required. Taking those out results in passing another set of values deep into the callback code which is already complex.

Apr
25
3 weeks ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Add type support to wrapper.ts and solc module

Conflicts:

tsconfig.json

commit sha: 3e12976de19307e2c4fe1d008f9aa61ca6c8788a

push time in 3 weeks ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability by splitting and documenting

stephensli
stephensli

Refactor wrapper.ts to improve maintainability by splitting and documenting

stephensli
stephensli

Add type support to wrapper.ts and solc module

commit sha: 8264412e2830f4b8a6a3b28a1d8d757a7bca1bca

push time in 3 weeks ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability by splitting and documenting

commit sha: 61a96ade4fafc2135efb7066d39afc4ec01e17cc

push time in 3 weeks ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Add type support to wrapper.ts and solc module

commit sha: 3344a1c6304532129035b1f3e7f655b773e12bc9

push time in 3 weeks ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability by splitting and documenting

stephensli
stephensli

Refactor wrapper.ts to improve maintainability by splitting and documenting

stephensli
stephensli

Add type support to wrapper.ts and solc module

commit sha: 797afe4d728b7f7c3ac2841566e1083abb323f57

push time in 3 weeks ago
push

stephensli push stephensli/solc-js

stephensli
stephensli

Refactor wrapper.ts to improve maintainability by splitting and documenting

commit sha: 051f0f647168ca9980db4984ecbaf2ea43f11feb

push time in 3 weeks ago
Previous