cortex_m: add armv8m special registers

Change-Id: I1942f375a5f4282ad1fe4a2ff3b8f3cbc64d8f7f Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: http://openocd.zylin.com/6016 Tested-by: jenkins Reviewed-by: Tomas Vanek [email protected]

rtos: Add support for Zephyr RTOS

With this patch, the Zephyr[1] RTOS is supported by OpenOCD.

As usual with support for other RTOSes, Zephyr must be compiled with the DEBUG_THREAD_INFO option. This will generate some symbols with information needed in order to build the list of threads.

The current implementation is limited to Zephyr running on ARM Cortex-M processors. This is the only ARM variant supported by Zephyr at the moment and is used on most of the officially supported boards.

[1] https://www.zephyrproject.org/

Change-Id: I22afdbec91562f3a22cf5b88cd4ea3a7a59ba0b4 Signed-off-by: Evgeniy Didin [email protected] Signed-off-by: Leandro Pereira [email protected] Signed-off-by: Daniel Glöckner [email protected] Reviewed-on: http://openocd.zylin.com/4988 Tested-by: jenkins Reviewed-by: Oleksij Rempel [email protected] Reviewed-by: Antonio Borneo [email protected]

target/armv7m.h: [style] replace tab with space between variable type and name

Change-Id: I9740c25857295a2a655d3046322a3f23f0ee7f78 Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: http://openocd.zylin.com/6230 Reviewed-by: Marc Schink [email protected] Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

server: gdb_server: Add colon for target extended-remote

Both GDB commands "target remote" and "target extended-remote" require to have ":" right before port number.

e.g. (gdb) target extended-remote :3333

Add ":" to the warning message so that users can copy & past it.

Change-Id: Id6d8ec1e4dfd3c12cb7f3b314064f2c35fa7ab55 Signed-off-by: Yasushi SHOJI [email protected] Reviewed-on: http://openocd.zylin.com/6237 Reviewed-by: Tarek BOCHKATI [email protected] Tested-by: jenkins Reviewed-by: Marc Schink [email protected] Reviewed-by: Antonio Borneo [email protected]

jimtcl: restrict memory leak workaround on Linux only

The workaround for jimtcl 0.80 in commit 36ae487ed04b ("jimtcl: add temporary workaround for memory leak in jimtcl 0.80") issues a compile time error on macOS: ../src/helper/command.c:157:22: error: aliases are not supported on darwin attribute((weak, alias("workaround_createcommand"))); The OS is x86_64-apple-darwin19.6.0 and the compiler used is x86_64-apple-darwin13.4.0-clang.

Restrict the workaround on Linux host only. The fix for 'expr' syntax change is already merged and the workaround will be dropped soon.

Change-Id: I925109a9c57c05f8c95b70bc7d6604eb1172cd79 Signed-off-by: Antonio Borneo [email protected] Reported-by: Adam Jeliński [email protected] Fixes: 36ae487ed04b ("jimtcl: add temporary workaround for memory leak in jimtcl 0.80") Fixes: https://sourceforge.net/p/openocd/tickets/304/ Reviewed-on: http://openocd.zylin.com/6241 Tested-by: jenkins

target/armv7m: fix static analyzer warning

Despite of assert(is_packed) clang static analyser complains on use of the uninitialized offset variable.

Cross compiling with latest x86_64-w64-mingw32-gcc hits warnings src/target/armv7m.c: In function ‘armv7m_read_core_reg’: src/target/armv7m.c:337:54: error: ‘reg32_id’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

It happens because mingw32 defines assert() without the attribute "noreturn", whatever NDEBUG is defined or not.

Replace assert(is_packed) by if (is_packed) conditional and call assert(false) in the else branch.

Change-Id: Id3c7dcccb65106e28be200b9a4d2b642f4d31019 Signed-off-by: Tomas Vanek [email protected] Reviewed-on: http://openocd.zylin.com/6256 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected] Reviewed-by: Tarek BOCHKATI [email protected] Reviewed-by: Andrzej Sierżęga [email protected]

cmsis_dap: fix build on macOS

Compile fails with error: src/jtag/drivers/cmsis_dap.c:683:28: error: format specifies type 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] " received 0x%" PRIx8, CMD_DAP_TFER, resp[0]); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^

Fix the format specifier.

Change-Id: I0a5a1a35452d634019989d14d849501fb8a7e93a Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6255 Tested-by: jenkins Reviewed-by: Tomas Vanek [email protected]

cortex_m: do not perform soft_reset_halt on targets without VECTRESET

Change-Id: Ib3df457e0afe4e342c82ad1af25e03aad6979d87 Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: http://openocd.zylin.com/6209 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected] Reviewed-by: Tomas Vanek [email protected]

cortex_m: fix VECTRESET detection for ARMv6-M cores

VECTRESET check should be done after verifying if the core is an ARMv6-M core, and not before that.

Fixes: 2dc9c1df81b6 ("cortex_m: [FIX] ARMv8-M does not support VECTRESET") Change-Id: I8306affd332b3a35cea69bba39ef24ca71244273 Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: http://openocd.zylin.com/6232 Tested-by: jenkins Reviewed-by: Tomas Vanek [email protected] Reviewed-by: Antonio Borneo [email protected]

target/arm_dpm: rename 'wp_pc' as 'wp_addr'

The field 'wp_pc' was originally introduced in commit 55eeea7fceb6 ("ARMv7a/Cortex-A8: report watchpoint trigger insn") in end 2009 to contain the address of the instruction which triggered a watchpoint. Later on with commit 651b861d5d5f ("target/aarch64: Add watchpoint support") it has been reused in to hold directly the memory address that triggered a watchpoint.

Rename 'wp_pc' as 'wp_addr' and change its doxygen description. While there, fix the format string to print the field.

Change-Id: I2e5ced1497e4a6fb6b38f91e881807512e8d8c47 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6204 Tested-by: jenkins Reviewed-by: Liming Sun [email protected]

target/aarch64: fix watchpoint management

The early documentation for armv8a report the debug register WFAR as containing the address of the instruction that triggered the watchpoint. More recent documentation report the register EDWAR as containing the data memory address that triggered the watchpoint.

The name of macros CPUV8_DBG_WFAR0 and CPUV8_DBG_WFAR1 is not correct as they point to the debug register EDWAR, so reading such register returns directly the data memory address that triggered the watchpoint. The code incorrectly passes this address value to the function armv8_dpm_report_wfar(); this function is supposed to adjust the PC value, decrementing it to remove the effects of the CPU pipeline. This pipeline offset, that has no meaning on the value in EDWAR, caused commit 651b861d5d5f ("target/aarch64: Add watchpoint support") to add back the offset while comparing the address with the watchpoint enabled.

The upper 32 bits of EDWAR are not valid in aarch32 mode and have to be ignored.

Rename CPUV8_DBG_WFAR0/1 as CPUV8_DBG_EDWAR0/1. Remove the function armv8_dpm_report_wfar(). Remove the offset while searching the matching watchpoint. Ignore the upper 32 bits of EDWAR in aarch32 mode. Fix a comment and the LOG text.

Change-Id: I7cbdbeb766fa18e31cc72be098ca2bc501877ed1 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6205 Tested-by: jenkins Reviewed-by: Liming Sun [email protected]

flash/stm32l4x: add missing break statement

this is not a bug fix, this for loop will issue only one match adding the break will save unnecessary more loops.

Change-Id: Ic1484ea8cdea1b284eb570f9e3e7818e07daf5cd Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: http://openocd.zylin.com/6248 Reviewed-by: Oleksij Rempel [email protected] Tested-by: jenkins

github/action: create a permanent 'latest' release

this commit extends the existing snapshot action to create a release named 'latest' with the built binaries for windows.

this 'latest' release will be updated after every push to github.

Change-Id: I75a64c598169241743add3ac9aa7a0337fbab7f2 Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: http://openocd.zylin.com/6127 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

tcl/rp2040: remove empty line at end of file

Change-Id: I212a96b77282b151a8ecbd46a6436e2bbbda4161 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6221 Tested-by: jenkins

tcl: fix some minor typo

Minor typos found by the new checkpatch boosted by the dictionary provided by 'codespell'. While there, fix one indentation.

Change-Id: I72369ed26f363bacd760b40b8c83dd95e89d28a4 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6214 Tested-by: jenkins

flash: fix some minor typo

Minor typos found by the new checkpatch boosted by the dictionary provided by 'codespell'.

Change-Id: Ia5f134c91beb483fd865df9e4877e0ec3e789478 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6215 Tested-by: jenkins

jtag: fix some minor typo

Minor typos found by the new checkpatch boosted by the dictionary provided by 'codespell'.

Change-Id: I101c76a638805d77c1ff356cf0f027552389e5d3 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6216 Tested-by: jenkins

target: fix some minor typo

Minor typos found by the new checkpatch boosted by the dictionary provided by 'codespell'.

Change-Id: I548581247db72e683249749d1b8725035530b06e Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6217 Tested-by: jenkins

openocd: fix some minor typo

Minor typos found by the new checkpatch boosted by the dictionary provided by 'codespell'.

Change-Id: I7b4cae1798ff5ea048fcbc671a397af763fdc605 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6218 Tested-by: jenkins

arm_coresight: add include file and use it

Several magic numbers related to ARM CoreSight specification IHI0029E are spread around OpenOCD code.

Define through macros the ARM CoreSight magic numbers and collect them in a single include file. Use the new macros wherever possible.

Change-Id: I9b0c1c651ce4ffbaf08d31791ef16e95983ee4cb Signed-off-by: Antonio Borneo [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6446 Tested-by: jenkins Reviewed-by: Tarek BOCHKATI [email protected] Reviewed-by: Daniel Goehring [email protected]

arm_adi_v5: simplify handling of AP type

The complete AP type should include 'class' and 'manufacturer'.

Cleanup the definition of AP type from AP_REG_IDR register. Include the check of 'class', together with manufacturer and type. Add the new MEM-AP from ARM IHI0074C.

Change-Id: Ic8db7c040108ba237b54f73b1abe24b8b853699b Signed-off-by: Antonio Borneo [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6447 Tested-by: jenkins Reviewed-by: Tarek BOCHKATI [email protected] Reviewed-by: Daniel Goehring [email protected]

arm_adi_v5: move in a separate function devtype decode/display

For readability, move in a separate function the decoding and the display of devtype register. The function will be reused with ADIv6.

Split from change https://review.openocd.org/6077/

Change-Id: I7a26a2c9759d5db5f9acfae5c169b90b3deb2f18 Signed-off-by: Kevin Burke [email protected] Signed-off-by: Daniel Goehring [email protected] Signed-off-by: Antonio Borneo [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6448 Tested-by: jenkins Reviewed-by: Tarek BOCHKATI [email protected]

arm_adi_v5: add helper to search for part number

Improve code readability and prepare to re-use the helper.

Change-Id: Iee5e01047c82be3dd86707f5c283f0b20cc4070d Signed-off-by: Antonio Borneo [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6449 Tested-by: jenkins Reviewed-by: Daniel Goehring [email protected] Reviewed-by: Tarek BOCHKATI [email protected]

arm_adi_v5: add arm SoC-600 part numbers

Extract new part numbers from ARM CoreSight System-on-Chip SoC-600 Technical Reference Manual Revision r4p1 and add them to the array dap_partnums.

Change-Id: I88d8aa3c084f6e832b75032e75bfb6d377a08360 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6450 Tested-by: jenkins Reviewed-by: Daniel Goehring [email protected] Reviewed-by: Tarek BOCHKATI [email protected]

arm_adi_v5: add arm Cortex-R52 part numbers

Extract new part numbers from Arm Cortex-R52 Processor Technical Reference Manual Revision r1p3 and add them to the array dap_partnums.

Change-Id: I8020f36de587951af60422ef33d7e438dc7d9d53 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6451 Tested-by: jenkins Reviewed-by: Daniel Goehring [email protected] Reviewed-by: Tarek BOCHKATI [email protected]

arm_adi_v5: add arm Neoverse N1 part numbers

Split from change https://review.openocd.org/6077/

Change-Id: I5e3d3736beb741de3940ea6e23b0ccbf47e8dec7 Signed-off-by: Kevin Burke [email protected] Signed-off-by: Daniel Goehring [email protected] Signed-off-by: Antonio Borneo [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6452 Tested-by: jenkins Reviewed-by: Tarek BOCHKATI [email protected]

arm_adi_v5: add arm Neoverse N2 part numbers

Change-Id: Ib7a8c9d460f12762f6d106e9331e84b6d2dec213 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6453 Tested-by: jenkins Reviewed-by: Daniel Goehring [email protected] Reviewed-by: Tarek BOCHKATI [email protected]

arm_adi_v5: drop ANY_ID from table dap_part_nums

The initial version of the table dap_part_nums contains only the part number of the device and not the manufacturer ID. This causes collisions between devices with same part number but from different manufacturer. The table has been extended to include the manufacturer JEDEC code in commit 2f131d3c3004 ("ARM ADIv5: CoreSight ROM decode part number and designer id"). For two old/legacy table's entries reported without manufacturer code it was defined a special ANY_ID manufacturer, meaning skip the check for manufacturer! The two legacy entries report the comment "from OMAP3 memmap", and thanks to the associated string has been possible through Google to identify a Master Report [1] about using OpenOCD with the OMAP3 in a BeagleBoard. The ROM table is printed with OpenOCD command "dap info 1" at page 8 and reports the Peripheral ID required to extract the manufacturer ID that, out of any surprise, belong to Texas Instruments.

Set the two missing manufacturer ID to Texas Instruments JEDEC code.

Remove the now redundant definition and use of ANY_ID.

While revisiting this old code, remove also the useless comment "0x113: what?". It was introduced in commit ddade10d4a93 ("ARM ADIv5: "dap info" gets more readable") and from the same dump in [1] it's clearly another element in OMAP3. It is listed as entry 0x8 in the ROM table and there is no further info available. OpenOCD will anyway list it as: Designer is 0x017, Texas Instruments Part is 0x113, Unrecognized Another link https://elinux.org/BeagleBoardOpenOCD reports the text "Part number 0x113: This is ????", which sounds familiar! No public document from Texas Instruments reports what is this device at address 0x54012000.

[1] Warren Clay Grant - University of Texas at Austin "Implementation of an Open Source JTAG Debugging Development Chain for the BeagleBoard ARM® Cortex A-8" - May 2012 Link: https://repositories.lib.utexas.edu/bitstream/handle/2152/ETD-UT-2012-05-5478/GRANT-MASTERS-REPORT.pdf

Change-Id: I7e007addbb5c6e90303e4e8c110c7d27810fbe9c Signed-off-by: Antonio Borneo [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6454 Tested-by: jenkins Reviewed-by: Daniel Goehring [email protected]

arm_tpiu_swo: fix support for deprecated 'tpiu' command before 'init'

Commit dc7b32ea4a00 ("armv7m_trace: get rid of the old tpiu code") is not handling correctly the old 'tpiu' command if it is run during the config phase (before command 'init').

Move the call to the old event handler 'trace-config' in function jim_arm_tpiu_swo_enable(), so it is correctly executed after 'init'.

Add the call to the old event handler 'trace-config' also during jim_arm_tpiu_swo_disable(), to match the old behaviour.

Add more information while alerting that the event 'trace-config' is deprecated.

Change-Id: If831d9159b4634c74e19c04099d041a6e2be3f2a Signed-off-by: Antonio Borneo borneo.anton[email protected] Fixes: dc7b32ea4a00 ("armv7m_trace: get rid of the old tpiu code") Reviewed-on: https://review.openocd.org/c/openocd/+/6561 Tested-by: jenkins Reviewed-by: Karl Palsson [email protected]

openocd: prevent jimtcl error message while testing commands

The jimtcl API Jim_GetCommand() sets an error message when the command is not found and flag JIM_ERRMSG is set. OpenOCD is checking if the command has already been registered, thus 'command not found' is the desired case.

Pass flag JIM_NONE to prevent jimtcl from setting the error message.

Change-Id: I3329c2f8722eda0cc9a5f9cbd888a37915b46107 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6562 Tested-by: jenkins

Speed up remote bitbang.

1. Use TCP_NODELAY, which makes things twice as fast.
2. Get rid of a bunch of unnecessary socket block/non-block calls, which improves speed another 10% or so.

Change-Id: I415db5746d55374a14564b1973b81e3517f5cb67 Signed-off-by: Tim Newsome [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6534 Tested-by: jenkins Reviewed-by: Jan Matyas [email protected] Reviewed-by: Antonio Borneo [email protected]

driver/linuxgpiod: add support for opendrain srst

Some MCUs (e.g. the STM32F3) directly expose the internal reset line to an external pin. When this signal is driven by a push/pull line, it can actually be inhibited by the external driver. This results in a setup where the MCU cannot reset itself, for example, by a watchdog timeout or a sysreset request. To fix this condition, support for open drain output on the SRST line is required.

Note that because reset_config srst_open_drain is the default, all users of this adapter will switch over to an open drain output unless explicitly configured otherwise.

Signed-off-by: Alex Crawford [email protected] Change-Id: I89b39b03aa03f826ed3c45793412780448940bcc Reviewed-on: https://review.openocd.org/c/openocd/+/6559 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

tcl/stm32wlx.cfg: comply with new jimtcl expr syntax

Change-Id: I2e9fd528817b14396c7643801aeea5c8dde668e0 Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: https://review.openocd.org/c/openocd/+/6557 Reviewed-by: Antonio Borneo [email protected] Tested-by: jenkins

target/cortex_m: enhance multi-core examine logs

Giving the example of STM32WL55x the examine log is the following: Info : stm32wlx.cpu0: hardware has 6 breakpoints, 4 watchpoints Info : stm32wlx.cpu1: hardware has 4 breakpoints, 2 watchpoints

After this change the examine log becomes: Info : stm32wlx.cpu0: Cortex-M4 r0p1 processor detected Info : stm32wlx.cpu0: target has 6 breakpoints, 4 watchpoints Info : stm32wlx.cpu1: Cortex-M0+ r0p1 processor detected Info : stm32wlx.cpu1: target has 4 breakpoints, 2 watchpoints

Change-Id: I1873a75eb76f0819342c441129427b38e984f0df Signed-off-by: Tarek BOCHKATI [email protected]

target: reset target examined flag if target::examine() fails

For example: before this change in cortex_m_examine, if we fail reading CPUID we return a failure code but target was set to examined which is not consistent.

Change-Id: I9f0ebe8f811849e54d1b350b0db506cb3fdd58f4 Signed-off-by: Tarek BOCHKATI [email protected]

buildmgr: Set cbuildgen.rc encoding to UTF-8 (#9)

Source code documentation for RteModel: remaining classes RteCallback and RteProject (#10)

buildmgr: Fix files and components layer assignment matching recognition (#11)

Source code documentation for ErrLog (#14)

Source code documentation for XmlReader (#15)

Sdcmsis 1576 parent (#17)

• SDCMSIS-1576 Source code documentation for RteModel

Co-authored-by: Evgueni Driouk [email protected]

Corrected document links (#13)

Updated packchk reference name in packgen (#12)

Fix: Auto Copyright Notice checker only checks for specific copyright (#20)

Resolved Unused warning (#18)

buildmgr: Add layer compose options (#19)

• Add layer compose options for setting project name and description
• Set info name field in extracted layer
• Update tests and documentation

GH Actions: Enable CI triggered on all branches (#24)

This enables us to trigger the CI in any PR, not only against main branch.

GH Actions: Enable a global workflow (#25)

This workflow is not associated with any product.

Fix issues with filesystem::perms in Windows-GCC (#23)

On Windows a file/dir with full access permissions seems not to have perms::all set. This may be caused by permissions available on POSIX but not on Windows. Instead of testing file/dirs with full access for perms::all the test checks specifically for the permissions of interest.

Fixing usage of gtest EXPECT_EQ for better readability of error messages.

Revert "Updated packchk reference name in packgen (#12)" (#26)

This reverts commit 54d7399d7edc39cbecad9e4c4926a1b0a87e6c60.

buildmgr: 'compilers' requirement shall not be mandatory for layers (#28)

tcl/target/eos_s3: fix variable's expansion typo

TCL expands the variables only if preceded by a dollar sign.

Add the missing dollar before the variable's name '_CPUTAPID'.

Change-Id: Icc5d0dddf24f75d12ee63fee69e1b265e842ca43 Signed-off-by: Antonio Borneo [email protected] Reported-by: Wes Cilldhaire [email protected] Fixes: c3166b43e415 ("tcl/target: Add QuickLogic EOS S3 MCU configuration") Reviewed-on: http://openocd.zylin.com/6079 Tested-by: jenkins Reviewed-by: TM [email protected]

The openocd-0.11.0 release

Signed-off-by: Paul Fertser [email protected]

Restore normal development cycle

Signed-off-by: Paul Fertser [email protected]

tcl/target: Add K3 basic support

Add basic connection details for AM654 and J721E SoCs from TI.

See AM65x Technical Reference Manual (SPRUID7, April 2018) for further details: https://www.ti.com/lit/pdf/spruid7

See J721E Technical Reference Manual (SPRUIL1, May 2019) for further details: https://www.ti.com/lit/pdf/spruil1

See J7200 Technical Reference Manual (SPRUIU1, June 2020) for further details: https://www.ti.com/lit/pdf/spruiu1

See AM64X Technical Reference Manual (SPRUIM2, Nov 2020) for further details: https://www.ti.com/lit/pdf/spruim2

Change-Id: Ie5108c6ad6f1304a6bf5b9f81aa9ebd33b8a559d Signed-off-by: Nishanth Menon [email protected] Reviewed-on: http://openocd.zylin.com/5182 Reviewed-by: Antonio Borneo [email protected] Tested-by: jenkins

tcl/board: Add AM654 EVM basic support

Add basic connection details with AM654 evm

Change-Id: Iea2240860e50ae42cf6f1617a10e24f63c6dd988 Signed-off-by: Nishanth Menon [email protected] Reviewed-on: http://openocd.zylin.com/5183 Reviewed-by: Antonio Borneo [email protected] Tested-by: jenkins

tcl/board: Add J721E EVM basic support

Add basic connection details with J721E EVM

Change-Id: I0c2d25252432914d8e371e81761a59c05924bd8e Signed-off-by: Nishanth Menon [email protected] Reviewed-on: http://openocd.zylin.com/5185 Reviewed-by: Antonio Borneo [email protected] Tested-by: jenkins

tcl/board: Add J7200 EVM basic support

Add basic connection details with J7200 EVM

Change-Id: Ia8fa5033a693ac09849d33693c81b8cb206f17c1 Signed-off-by: Nishanth Menon [email protected] Reviewed-on: http://openocd.zylin.com/5951 Reviewed-by: Antonio Borneo [email protected] Tested-by: jenkins

tcl/board: Add AM642 EVM basic support

Add basic connection details with AM642 EVM

Change-Id: I95dcf6afadb61bfd8456b79274eae863b834167d Signed-off-by: Nishanth Menon [email protected] Reviewed-on: http://openocd.zylin.com/5952 Reviewed-by: Antonio Borneo [email protected] Reviewed-by: Vignesh Raghavendra Tested-by: jenkins

eMAG: Add Ampere eMAG config files

Add board and target configuration files for Ampere eMAG8180 board and Ampere eMAG processor.

Tested on an Ampere eMAG8180 development platform.

Change-Id: I222653f0fc12d25202a7e469db3594076cbc38ed Signed-off-by: Anthony Ferranti [email protected] Signed-off-by: Daniel Goehring [email protected] Reviewed-on: http://openocd.zylin.com/5569 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

stlink: separate stlink core from USB functions

the introduced stlink_backend_s struct provides an API to separate USB internals from stlink core.

this separation aims to ease:

• stlink-server integration [1]
• stlink driver split into modules:
  • stlink_core
  • stlink_usb
  • stlink_tcp [1]

[1] refer to http://openocd.zylin.com/#5633/

Change-Id: Iff6790942612ce1769ec4c75990914534e5e9e24 Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: http://openocd.zylin.com/5632 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

stlink: support of ST-LINK TCP server using stlink-dap and hla

Quote: The ST-LINK TCP server is an application to share the debug interface of a single ST-LINK board among several host applications, typically a debugging tool and a monitoring tool.

Note: ST-Link TCP server does not support the SWIM transport.

ST-LINK TCP server allows several applications to connect to the same ST-Link through sockets (TCP).

To use ST-LINK TCP server:

• using stlink-dap : use 'st-link backend tcp [port]'
• using hla : use 'hla_stlink_backend tcp [port]'

the default port value is 7184

Change-Id: I9b79f65267f04b1e978709934892160e65bd2d6d Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: http://openocd.zylin.com/5633 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

tcl/target: add Rockchip RK3399 target

Change-Id: I28f404b1e53fc9dbb04b3f939294ae248bbde183 Signed-off-by: Jiri Kastner [email protected] Reviewed-on: http://openocd.zylin.com/5994 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

rtos: Remove typedef'd struct

The C style guide forbids typedef'd structs, see 'Naming Rules'.

Change-Id: Ia7c8218fb61ff0c74b6dd0d10fb51a77cf059c14 Signed-off-by: Marc Schink [email protected] Reviewed-on: http://openocd.zylin.com/6028 Tested-by: jenkins Reviewed-by: Andreas Fritiofson [email protected] Reviewed-by: Antonio Borneo [email protected]

flash/nand/lpc32xx: Remove typedef'd struct

The C style guide forbids typedef'd structs, see 'Naming Rules'.

Change-Id: I983dd52307136d1b5adb58d8c44c0c14422d31e2 Signed-off-by: Marc Schink [email protected] Reviewed-on: http://openocd.zylin.com/6032 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

target/mips: Remove typedef'd struct

The C style guide forbids typedef'd structs, see 'Naming Rules'.

Change-Id: I449590251056c478c05105cdc18014ab4eb77ed8 Signed-off-by: Marc Schink [email protected] Reviewed-on: http://openocd.zylin.com/6033 Tested-by: jenkins Reviewed-by: Oleksij Rempel [email protected] Reviewed-by: Antonio Borneo [email protected]

target: Remove redundant initialization of endianness

target->endianness is initialized to TARGET_ENDIAN_UNKNOWN at 34 lines below, before calling target_configure. This initialization is redundant and not needed.

Change-Id: Iea2d5e17a13c1a8b0b209ba7c20043736b520ef6 Signed-off-by: Yasushi SHOJI [email protected] Reviewed-on: http://openocd.zylin.com/6039 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

cmsis_dap: remove DAP_MAX_CLOCK

Discussed here:

https://sourceforge.net/p/openocd/mailman/message/35466010/

Change-Id: Ic4d38a872f4b13b794ad0a8a2abdbe5bb21eced3 Signed-off-by: Adrian Negreanu [email protected] Reviewed-on: http://openocd.zylin.com/5964 Tested-by: jenkins Reviewed-by: Bohdan Tymkiv [email protected] Reviewed-by: Antonio Borneo [email protected]

armv7m_trace_itm_config: wait for ITMBusy to be cleared

pg315 of CoreSight Components:

It is recommended that the ITMEn bit is cleared and waits for the ITMBusy bit to be cleared, before changing any fields in the Control Register, otherwise the behavior can be unpredictable.

Change-Id: Ie9a2b842825c98ee5edc9a35776320c668047769 Signed-off-by: Adrian Negreanu [email protected] Reviewed-on: http://openocd.zylin.com/6043 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

drivers/rlink: switch to libusb1

Convert the driver from libusb0 to libusb1.

Change-Id: I17d14522db18b4050d462d23151ec97d3a315a7f Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/5991 Tested-by: jenkins Reviewed-by: Marc Schink [email protected]

flash/stm32l4x: switch to to c loader instead of assembly loader

add loader argument for flash_word_size, to permit using the loader with STM32U5.

Change-Id: I24cafc2ba637a065593a0506eae787b21080a0ba Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: https://gerrit.st.com/c/stm32ide/official/openocd/+/197040 Tested-by: CITOOLS [email protected] Reviewed-by: Tarek BOUCHKATI [email protected]

cortex_m: implement hit_watchpoint function

this change aims to provide a better gdb debugging experience, by making gdb understand what's really happening.

before this change when hitting a watchpoint

• openocd reports "T05" to gdb
• gdb displays: Program received signal SIGTRAP, Trace/breakpoint trap.

after the change

• openocd reports "T05watch:20000000;" to gdb

• gdb displays: Hardware watchpoint 1: *0x20000000

  Old value = 16000000 New value = 170000000 ...

Change-Id: Iac3a85eadd86663617889001dd04513a4211ced9 Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: https://gerrit.st.com/c/stm32ide/official/openocd/+/203072 Tested-by: CITOOLS [email protected] Reviewed-by: Laurent LEMELE [email protected]

fix for unknown device in stm32l4x flash driver

Change-Id: I19547e3275c9e694a81bbd517dcfab552ecff702 Reviewed-on: https://gerrit.st.com/c/stm32ide/official/openocd/+/208362 Tested-by: Tarek BOCHKATI [email protected] Reviewed-by: Tarek BOCHKATI [email protected]

openocd: fix simple cases of NULL comparison

There are more than 1000 NULL comparisons to be aligned to the coding style. For recurrent NULL comparison it's preferable using trivial scripts in order to minimize the review effort.

Patch generated automatically with the command: sed -i PATTERN $(find src/ -type f) where PATTERN is in the list: 's/(([a-z][a-z0-9_]) == NULL)/(!\1)/g' 's/(([a-z][a-z0-9_]->[a-z][a-z0-9_]) == NULL)/(!\1)/g' 's/(([a-z][a-z0-9_].[a-z][a-z0-9_]*) == NULL)/(!\1)/g'

's/(\([a-z][a-z0-9_]*\) != NULL)/(\1)/g'
's/(\([a-z][a-z0-9_]*->[a-z][a-z0-9_]*\) != NULL)/(\1)/g'
's/(\([a-z][a-z0-9_]*\.[a-z][a-z0-9_]*\) != NULL)/(\1)/g'

's/(NULL == \([a-z][a-z0-9_]*\))/(!\1)/g'
's/(NULL == \([a-z][a-z0-9_]*->[a-z][a-z0-9_]*\))/(!\1)/g'
's/(NULL == \([a-z][a-z0-9_]*\.[a-z][a-z0-9_]*\))/(!\1)/g'

's/(NULL != \([a-z][a-z0-9_]*\))/(\1)/g'
's/(NULL != \([a-z][a-z0-9_]*->[a-z][a-z0-9_]*\))/(\1)/g'
's/(NULL != \([a-z][a-z0-9_]*\.[a-z][a-z0-9_]*\))/(\1)/g'

Change-Id: Ida103e325d6d0600fb69c0b7a1557ee969db4417 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6350 Tested-by: jenkins

openocd: remove NULL comparisons with checkpatch [1/2]

Patch generated automatically through the new checkpatch with flags "--types COMPARISON_TO_NULL --fix-inplace". This only fixes the comparisons if (symbol == NULL) if (symbol != NULL) The case of NULL on the left side of the comparison is not tested.

Some automatic fix is incorrect and has been massaged by hands: - if (psig == NULL) + if (!psig) changed as + if (!*psig)

Change-Id: If4a1e2b4e547e223532e8e3d9da89bf9cb382ce6 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6351 Tested-by: jenkins

openocd: remove NULL comparisons with checkpatch [2/2]

Patch generated automatically through a modified checkpatch that detects the patterns if (NULL == symbol) if (NULL != symbol) and through flags "--types COMPARISON_TO_NULL --fix-inplace".

The unmodified checkpatch detects this pattern as Yoda condition, but it's odd fixing it as Yoda condition and then again as NULL comparison. This triggered the modification to the script.

Change-Id: I5fe984a85e9c4fc799f049211797aef891ebce18 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6352 Tested-by: jenkins

openocd: manually remove NULL comparisons

For the remaining NULL comparisons, remove then manually.

While there, make more readable a loop, by moving the assigment out of the loop condition.

Change-Id: I44193aaa95813156a3a79c16b80e1ad333dc1eaf Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6353 Tested-by: jenkins

openocd: fix Yoda conditions with checkpatch

The new checkpatch can automatically fix the code, but this feature is still error prone and not complete.

Patch generated automatically through the new checkpatch with flags "--types CONSTANT_COMPARISON --fix-inplace".

Some Yoda condition is detected by checkpatch but not fixed; it will be fixed manually in a following commit.

Change-Id: Ifaaa1159e63dbd1db6aa3c017125df9874fa9703 Signed-off-by: Antonio Borneo [email protected] Reviewed-on: http://openocd.zylin.com/6355 Tested-by: jenkins

arm_adi_v5: Provide Brahma-B53 identifiers

The Broadcom Brahma-B53 CPUs contains a number of custom ROM table entries for its PMU, Debug unit, and a couple of ROM tables.

Change-Id: I1f21f07ed296579c374f24e781325789bf4ebf51 Signed-off-by: Florian Fainelli [email protected] Reviewed-on: http://openocd.zylin.com/6368 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

arm_adi_v5: Added Cortex-A76 identifiers

Add identifiers of the Cortex-A76 ROM and debug unit.

Change-Id: Ieef0d990189d3c0502e8d530874dc9cbca4417d8 Signed-off-by: Florian Fainelli [email protected] Reviewed-on: http://openocd.zylin.com/6358 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

doc: move the official channel to Libera.Chat

Due to Freenode takeover it's likely that most of our users are going to seek support on Libera in the nearest future.

Change-Id: I98db95bab51f4ef2ac854bf521468d22b2794e56 Signed-off-by: Paul Fertser [email protected] Reviewed-on: http://openocd.zylin.com/6297 Tested-by: jenkins Reviewed-by: Tarek BOCHKATI [email protected] Reviewed-by: Antonio Borneo [email protected] Reviewed-by: Marc Schink [email protected]

jtag/aice: fix build with clang on MacOS

Commit fceb29d03ff9 ("jtag/aice: use macros in place of const variables") replaces some 'static const uint8_t' with macros. This breaks the build on MacOS because the macro values are of 'int' type that doesn't match with the printf format 'PRIx8'.

error: format specifies type 'unsigned char' but the
argument has type 'int' [-Werror,-Wformat]

Replace the printf format 'PRIx8' with 'x'. While there, remove a useless cast to uint32_t and fix the printf format too.

Change-Id: Ib87298a61637b75a2813f209e5209d39ab2745f8 Signed-off-by: Antonio Borneo [email protected] Fixes: fceb29d03ff9 ("jtag/aice: use macros in place of const variables") Reviewed-on: http://openocd.zylin.com/6380 Tested-by: jenkins

drivers/bcm2835: Add support for SWDIO direction control pin

Adds a new, optional configuration "bcm2835gpio_swdio_dir_num" to the BCM2835 driver, to control the direction of an external buffer driver IC in SWD mode. For example, this is needed to use a level- shifting buffer, such as the SN74LVC2T45 used on the JTAG Hat

Change-Id: If5c146f310ecf8ceae85443b3670936467d2786d Signed-off-by: Matthew Mets [email protected] Reviewed-on: http://openocd.zylin.com/6371 Reviewed-by: Antonio Borneo [email protected] Tested-by: jenkins

interface/jtag_hat: Add interface configuration for the JTAG HAT

This adds support for the Blinkinlabs JTAG Hat, a Raspberry Pi expansion board that provides JTAG and SWD connections via level- shifting buffers.

Change-Id: I228bf6a18890b7c3d6679bbc63bfe39f726d8323 Signed-off-by: Matthew Mets [email protected] Reviewed-on: http://openocd.zylin.com/6372 Reviewed-by: Antonio Borneo [email protected] Tested-by: jenkins

doc/openocd.texi: Add documentation for bcm2835 interface

This adds documentation for the bcm2835 interface configuration parameters to the user manual. Documentation format is based on the FTDI interface section, and was taken from the descriptions in the driver source code.

Change-Id: I77b09b8bd44d8e8fe9cc5fb9de3c3a30550d943c Signed-off-by: Matthew Mets [email protected] Reviewed-on: http://openocd.zylin.com/6376 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

drivers/cmsis-dap: update for newest protocol version

The capabilities INFO command can now return two bytes, without this patch, the capabilities would simply not be read and left as 0 (i.e. no capabilities).

cf. https://arm-software.github.io/CMSIS_5/DAP/html/group__DAP__Info.html ; https://github.com/ARM-software/CMSIS_5/blob/116866fd74756c88096e37cbd0066fadad583cad/CMSIS/DAP/Firmware/Source/DAP.c#L100-L111

Change-Id: Ibd894971edf1c120cae08089e5515ce5e9972323 Signed-off-by: PoroCYon [email protected] Reviewed-on: http://openocd.zylin.com/6373 Tested-by: jenkins Reviewed-by: Andrzej Sierżęga [email protected] Reviewed-by: Antonio Borneo [email protected]

Call poll at a fixed interval.

The existing implementation blocks in select() for a fixed amount of time. This change tracks when the next event (likely poll()) wants to be run, and uses a shorter timeout in select() if necessary.

Also track all these timeouts using milliseconds as returned by timeval_ms() instead of struct timeval to simplify the code.

This feature is helpful if poll() wants to do something like sample PCs or memory values for basically the entire time that otherwise OpenOCD would be hung in select(). See https://github.com/riscv/riscv-openocd/pull/541 for an example of that. The RISC-V code using this change will be upstreamed some day, too.

Signed-off-by: Tim Newsome [email protected] Change-Id: I67104a7cf69ed07c8399c14aa55963fc5116a67d Reviewed-on: http://openocd.zylin.com/6363 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

tcl/board: Add Raspberry Pi 3 board

OpenOCD cannot connect to BCM2837's JTAG interface on RPi 3 board until the reset configuration mode is set as trst_only.

According to Table 6-31 GPIO Pins Alternative Function Assignment of Broadcom's BCM2837 ARM Peripherials datasheet [1] and Raspberry Pi's GPIO control in config.txt document [2], only Test Reset (TRST) pin (no System Reset, SRST) is exposed.

[1] https://usermanual.wiki/Datasheet/BCM2837ARMPeripheralsBroadcom.1054296467/view [2] https://www.raspberrypi.org/documentation/configuration/config-txt/gpio.md

Change-Id: I26ff3924039ff7943faf0a5b1ad0427c8dbb88f2 Link: http://openocd.zylin.com/#6364/1 Signed-off-by: Jian-Hong Pan [email protected] Reviewed-on: http://openocd.zylin.com/6366 Tested-by: jenkins Reviewed-by: Florian Fainelli [email protected] Reviewed-by: Antonio Borneo [email protected]

tcl/board: Add Raspberry Pi 4 model B board

OpenOCD cannot connect to BCM2711's JTAG interface on RPi 4B board until the reset configuration mode is set as trst_only.

According to Table 94. GPIO Pins Alternative Function Assignment of Broadcom's BCM2711 ARM Peripherals datasheet [1] and Raspberry Pi's GPIO control in config.txt document [2], only Test Reset (TRST) pin (no System Reset, SRST) is exposed.

[1] https://datasheets.raspberrypi.org/bcm2711/bcm2711-peripherals.pdf [2] https://www.raspberrypi.org/documentation/configuration/config-txt/gpio.md

Change-Id: I806f0be9700fa0f0944b42c8a651a5731adc762b Link: http://openocd.zylin.com/#6364/1 Signed-off-by: Jian-Hong Pan [email protected] Reviewed-on: http://openocd.zylin.com/6367 Tested-by: jenkins Reviewed-by: Florian Fainelli [email protected] Reviewed-by: Antonio Borneo [email protected]

rtos: zephyr: add zephyr_params for cortex r4

Implementation for Cortex-M does works for Cortex-R too, it allows me to fetch thread list and their backtrace on a Cortex-R platforms.

Change-Id: I23e6eb00879587ba36e0bfb560f7002a9653d39b Signed-off-by: Julien Massot [email protected] Reviewed-on: http://openocd.zylin.com/6369 Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]

.github/workflows: Add missing 'apt-get update' to the snapshot workflow

During the build of the OpenOCD snapshot via GitHub Actions, ensure that the local package database is first updated, prior to installing any packages via apt-get install. Otherwise the apt-get install could fail.

Change-Id: If3c29faeb1496d5e2be75350f6352575b1f3a42e Signed-off-by: Jan Matyas [email protected] Reviewed-on: http://openocd.zylin.com/6378 Reviewed-by: Xiaofan [email protected] Tested-by: jenkins Reviewed-by: Tarek BOCHKATI [email protected] Reviewed-by: Tim Newsome [email protected] Reviewed-by: Antonio Borneo [email protected]

github/workflow: upgrade libraries in windows build to latest versions

Change-Id: I11fb6eb948531f1a2e8c0c3926cac52cf92765b9 Reported-by: Xiaofan [email protected] Signed-off-by: Tarek BOCHKATI [email protected] Reviewed-on: http://openocd.zylin.com/6383 Reviewed-by: Xiaofan [email protected] Tested-by: jenkins Reviewed-by: Antonio Borneo [email protected]