tarek-bochkati

tarek-bochkati

Member Since 8 years ago

STMicroelectronics, Tunisia

Experience Points
35
follower
Lessons Completed
12
follow
Lessons Completed
9
stars
Best Reply Awards
13
repos

142 contributions in the last year

Pinned
⚡ My OpenOCD sandbox, things to be up-streamed hopefully
⚡ STMicroelectronics customized version of OpenOCD
⚡ Official OpenOCD Read-Only Mirror (no pull requests)
Activity
May
17
2 days ago
push

tarek-bochkati push tarek-bochkati/devtools

tarek-bochkati
tarek-bochkati

[buildmgr] support translate ctrls options with IAR

Signed-off-by: Tarek BOCHKATI [email protected]

commit sha: 51afed7490a398803c0fe6ef8b003e91b11327ad

push time in 2 days ago
push

tarek-bochkati push tarek-bochkati/devtools

tarek-bochkati
tarek-bochkati

[buildmgr] propagate target options to CMakeLists.txt

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

commit sha: d8322f0ba1a21c2e41ca8ff432f8001cbfb646d2

push time in 2 days ago
push

tarek-bochkati push tarek-bochkati/devtools

tarek-bochkati
tarek-bochkati

[buildmgr] support options parsing (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

commit sha: 9d9765ede7e47a4a1020b8c30ad13af6faa8f572

push time in 2 days ago
push

tarek-bochkati push tarek-bochkati/devtools

tarek-bochkati
tarek-bochkati

[buildmgr] support options parsing (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

commit sha: 05f0395a6046eed05c2ec0a2c2386ed004ee9403

push time in 2 days ago
push

tarek-bochkati push tarek-bochkati/devtools

tarek-bochkati
tarek-bochkati

[projmgr] ProjMgrYamlParser: fix parsing of options:warnings

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[projmgr] ProjMgrGenerator: add GenerateCprjOptions

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[rtemodel] add RteItem::GetChildAttribute(tag, attribute)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

commit sha: 4a61c0d814dc50606e8161f4ab9efb4bc7d76cd1

push time in 2 days ago
Activity icon
issue

tarek-bochkati issue comment Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[csolution] project.optimize ad .debug seems to have no impact on cprj ?

Our cproject.yml files started with:

project:
  optimize: size                   # Code optimization: emphasis code size
  debug: on                        # Enable debug symbols

I would expect some -O3 and -g options in cflags of generated cprj files, but I couldn't see them...

Thx

@fred-r

tarek-bochkati
tarek-bochkati

@jeromecoutant i'm currently working on this Please check #328

Activity icon
issue

tarek-bochkati issue comment Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr,cbuildgen] support options (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

@brondani could you please give some hints on how to fix the buildmgr-cov ?

push

tarek-bochkati push tarek-bochkati/devtools

tarek-bochkati
tarek-bochkati

[projmgr] Expose filtering and validation results

tarek-bochkati
tarek-bochkati

[projmgr] common.schema.json fix missing WarningsType

Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[projmgr] ProjMgrYamlParser: fix parsing of options:warnings

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[projmgr] ProjMgrGenerator: add GenerateCprjOptions

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[rtemodel] add RteItem::GetChildAttribute(tag, attribute)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[buildmgr] support options parsing (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[buildmgr] propagate target options to CMakeLists.txt

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[buildmgr] support translate ctrls options with IAR

Signed-off-by: Tarek BOCHKATI [email protected]

commit sha: a8a5ea48a589dedae0f9a043d4017892f08767d4

push time in 2 days ago
pull request

tarek-bochkati merge to Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr,cbuildgen] support options (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

open pull request

tarek-bochkati wants to merge Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr,cbuildgen] support options (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

done, please check the new tools/projmgr/test/data/TestSolution/test.target_options.cproject.yml

pull request

tarek-bochkati merge to Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr,cbuildgen] support options (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

open pull request

tarek-bochkati wants to merge Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr,cbuildgen] support options (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

I have changed all options names as following OPT_DEBUG, OPT_WARNINGS, OPT_OPTIMIZE

open pull request

tarek-bochkati wants to merge Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr,cbuildgen] support options (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

I added a comment there as suggested

pull request

tarek-bochkati merge to Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr,cbuildgen] support options (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

Activity icon
issue

tarek-bochkati issue comment Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr] [buildmgr] Opportunity to introduce toolchain-independent configuration using the most common generic configurations

Discussion initiated if https://github.com/Open-CMSIS-Pack/devtools/issues/120

https://github.com/Open-CMSIS-Pack/devtools/issues/120#issuecomment-1050612457 https://github.com/Open-CMSIS-Pack/devtools/issues/120#issuecomment-1050634268 https://github.com/Open-CMSIS-Pack/devtools/issues/120#issuecomment-1055457730

Sounds good to me to get dedicated issue to comment / amend on.

Discussion is about following yml schema contributions: https://github.com/Open-CMSIS-Pack/devtools/blob/main/tools/projmgr/schemas/common.schema.json

"OptimizeType": { "enum": [ "max", "size", "speed", "debug" ], "description": "Generic optimize levels (max, size, speed, debug) for code generation." }, "DebugType": { "enum": [ "on", "off" ], "description": "Generic control for the generation of debug information (on, off)." }, "WarningsType": { "enum": [ "no", "all", "Misra", "AC5-like" ], "description": "Control warnings (no, all, Misra, AC5-like)." },

tarek-bochkati
tarek-bochkati

after the translation controls options addition (ie. optimize, debug, warnings), I have started supporting them into projmgr and buildmgr while doing that I had some notes which I need to share with you:

  • WarningsType enum AC5-like is only valid for AC6 compiler, thus I suggest either to remove it from the standart or add a mention in the documentation saying it's for AC6 only
  • OptimizeType
    • I can agree that debug means the lowed optimization possible + plus adding more debug info into the generate ELF file. thus I'm wondering if it is worth replacing it by none and we can use the debug options to add debug information
      if optimize=none
          if debug=on
              use -Og
          else
              use -O0
          endif
      endif
      
    • max is not clear for me:
      • for AC6 it should be linked to LTO: but is it -Omin (minimal size) or -Omax (best performance)
      • what about AC5 does it implies using Cross-Module Optimization ? and the same question as for AC6, is it using -Ospace -O3 or -Otime -O3
      • IAR does not have equivalent for -Omax optimization, but it does have max performance aka -Ohs --no_size_constraints
      • so I can retain the question does this max optimization targets size or performance ?
    • current enumeration values are debug, size, speed and max Comparing these values against to possible compilers optimization options, I'm wondering if it is worth adding low, medium and high values mirroring respectively -O1, -O2 and -O3
  • options precedence: options could come from csolution/cproject and also from build-type/target-type
    • while implementing #328 I avoided to do silent override of options, but the options merger should be discussed and implemented.
push

tarek-bochkati push tarek-bochkati/devtools

tarek-bochkati
tarek-bochkati

[rtemodel] add RteItem::GetChildAttribute(tag, attribute)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[buildmgr] support options parsing (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[buildmgr] propagate target options to CMakeLists.txt

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[buildmgr] support translate ctrls options with IAR

Signed-off-by: Tarek BOCHKATI [email protected]

commit sha: c96a2dfae745e013ff621fc5d95e4e4e2f5cc32c

push time in 2 days ago
May
16
3 days ago
Activity icon
issue

tarek-bochkati issue comment Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr,cbuildgen] support options (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

@brondani there was a bug on tools/projmgr/schemas/common.schema.json related to WarningsType I will come back with another fix for codecov

push

tarek-bochkati push tarek-bochkati/devtools

tarek-bochkati
tarek-bochkati

[projmgr] common.schema.json fix missing WarningsType

Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[projmgr] ProjMgrYamlParser: fix parsing of options:warnings

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[projmgr] ProjMgrGenerator: add GenerateCprjOptions

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[buildmgr] CbuildUtils add GetItemAttribute(item, tag, attrib)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[buildmgr] support options parsing (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[buildmgr] propagate target options to CMakeLists.txt

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

commit sha: 0a7499434acee17a54d553c1b9175b7531ddbd89

push time in 3 days ago
May
12
1 week ago
Activity icon
issue

tarek-bochkati issue comment Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr] propagate options to CPRJ

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

@brondani I have added more commits to propagate the options to CMakeLists.txt now I working on supporting these options on IAR.cmake

open pull request

tarek-bochkati wants to merge Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr] propagate options to CPRJ

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

then for the time being let's keep this as is without overriding as you suggested, let's move this discussion to #179

pull request

tarek-bochkati merge to Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr] propagate options to CPRJ

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

push

tarek-bochkati push tarek-bochkati/devtools

tarek-bochkati
tarek-bochkati

[buildmgr] CbuildUtils add GetItemAttribute(item, tag, attrib)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[buildmgr] support options parsing (optimize, debug, warnings)

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

[cbuildgen] propagate target options to CMakeLists.txt

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

commit sha: 5999e306ef52864fae9a62503d8aee3da5020df3

push time in 1 week ago
open pull request

tarek-bochkati wants to merge Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr] propagate options to CPRJ

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

@brondani I'm wondering if this is the correct build type container ? I have been thinking about the case when there is options like "optimize" in the csolution and not in the cproject IMO this should be propagated here as well. even more, if optimize is specified in both csolution (optimize: size) and cproject(optimize: speed), then I think "speed" should override "size" optimization

pull request

tarek-bochkati merge to Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr] propagate options to CPRJ

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

open pull request

tarek-bochkati wants to merge Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr] propagate options to CPRJ

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

@brondani I have added a test that I expect it to cover this code chunk.

pull request

tarek-bochkati merge to Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr] propagate options to CPRJ

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

push

tarek-bochkati push tarek-bochkati/devtools

tarek-bochkati
tarek-bochkati

[projmgr] ProjMgrGenerator: add GenerateCprjOptions

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

commit sha: 6b0ae6142c848c735f5f2303cd9202efc8d39b20

push time in 1 week ago
May
11
1 week ago
Activity icon
issue

tarek-bochkati issue comment Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr] propagate options to CPRJ

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

tarek-bochkati
tarek-bochkati

@brondani we still have to propagate this to CMakeLists.txt and manage it in .cmake files

pull request

tarek-bochkati pull request Open-CMSIS-Pack/devtools

tarek-bochkati
tarek-bochkati

[projmgr] propagate options to CPRJ

Contributed by STMicroelectronics Signed-off-by: Tarek BOCHKATI [email protected]

Previous