terinjokes

terinjokes

Software Engineer

Member Since 11 years ago

San Francisco, CA

Experience Points
366
follower
Lessons Completed
255
follow
Lessons Completed
1.3k
stars
Best Reply Awards
130
repos

168 contributions in the last year

Pinned
⚡ The Stickers Standard
⚡ A Static Server in Zig
⚡ An OpenRCT2 plugin that implements a Prometheus exporter.
⚡ injects resin into a mold to produce groovy Go programs
⚡ Offline encryption of Kubernetes Secrets
Activity
Nov
26
2 days ago
Activity icon
issue

terinjokes issue comment jellyfin/jellyfin-android

terinjokes
terinjokes

App crashes trying to cast to Google Chromecast

Describe the bug

Since the latest update (v2.4.1) Jellyfin app crashes whenever I try to cast.

  • Select the cast button and choose the chromecast
  • The jellyfin cast page loads on the TV
  • As soon as you press play on any media item the app crashes.

Note this happens on both mine and my wifes phone (both on the same app version) and when trying to cast to both our chromecast ultra and chromecast v3

Logs

No response

Application version

2.4.1

Where did you install the app from?

Google Play

Device information

Google Pixel 4a

Android version

Android 12

Jellyfin server version

10.7.7

Which video player implementations does this bug apply to?

  • Web player (default)
  • Integrated player (ExoPlayer)
  • External player (VLC, mpv, MX Player)
terinjokes
terinjokes

Same issue from a Pixel 6 Pro to a Chromecast Ultra. Stacktrace from Android says:

java.lang.IllegalArgumentException: org.jellyfin.mobile: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.

This looks very similar to #559, so maybe there's a PendingIntent specific to Google Cast that was missed?

Nov
25
3 days ago
Activity icon
issue

terinjokes issue comment cloudflare/origin-ca-issuer

terinjokes
terinjokes

failed to sign certificate request - error parsing time

Hello .

I am getting this error while trying to sign a certificate :

default 0s Warning Failed certificate/example-com The certificate request has failed to complete and will be retried: Failed to sign certificate request: unable to sign request: parsing time "" as "2006-01-02T15:04:05Z07:00": cannot parse "" as "2006"

The originissuer and everything is in place as per installation instructions :

kubectl get originissuer.cert-manager.k8s.cloudflare.com prod-issuer -n default -o json | jq .status.conditions [ { "lastTransitionTime": "2021-11-25T13:27:32Z", "message": "OriginIssuer verified and ready to sign certificates", "reason": "Verified", "status": "True", "type": "Ready" } ]

The issue seems to be related to this :

https://github.com/cloudflare/cloudflare-go/issues/190

My setup :

cert-manager-v1.5.4 kubernetes : v1.21.5 origin-ca-issuer : cloudflare/origin-ca-issuer:v0.6.0

terinjokes
terinjokes

This is a different bug than the linked issue. You're getting an error from the API, but this parse error is shown instead. I'll fix and make a new release.

push

terinjokes push terinjokes/home.nix

terinjokes
terinjokes

module: add easyeffects

EasyEffects has been added to the unstable branch of home-manager. Temporarily add it here until the next version of NixOS is released.

terinjokes
terinjokes
terinjokes
terinjokes

trial git-branchless

I'm currently comparing git-branchless against Stacked Git in a few repositories.

commit sha: 4af38ba153fd1cf1e2499b17bd1e14fae440575a

push time in 3 days ago
Nov
24
4 days ago
started
started time in 4 days ago
started
started time in 4 days ago
started
started time in 4 days ago
Nov
23
5 days ago
started
started time in 4 days ago
Activity icon
published release v0.8.0

terinjokes in cloudflare/ipvs create published release v0.8.0

createdAt 4 days ago
Activity icon
created tag
createdAt 4 days ago
Activity icon
delete

terinjokes in cloudflare/ipvs delete branch patches/update-netlink

deleted time in 5 days ago
push

terinjokes push cloudflare/ipvs

terinjokes
terinjokes

chore(deps): update netlink module

There's several significant improvements to the netlink module since we last updated, that take better advantage of changes to the Go runtime.

commit sha: d4fed141355c00be7690ebadc5b00be549b6565c

push time in 5 days ago
pull request

terinjokes pull request cloudflare/ipvs

terinjokes
terinjokes

chore(deps): update netlink module

There's several significant improvements to the netlink module since we last updated, that take better advantage of changes to the Go runtime.

started
started time in 5 days ago
pull request

terinjokes pull request cloudflare/ipvs

terinjokes
terinjokes

chore(deps): update netlink module

There's several significant improvements to the netlink module since we last updated, that take better advantage of changes to the Go runtime.

Activity icon
created branch

terinjokes in cloudflare/ipvs create branch patches/update-netlink

createdAt 5 days ago
Nov
22
6 days ago
started
started time in 6 days ago
Nov
20
1 week ago
started
started time in 1 week ago
Nov
18
1 week ago
started
started time in 1 week ago
started
started time in 1 week ago
Nov
17
1 week ago
started
started time in 1 week ago
Nov
16
1 week ago
Activity icon
issue

terinjokes issue comment arxanas/git-branchless

terinjokes
terinjokes

Documentation enhancements

  • README: Put installation at the top/make it easier to get started
  • README: Mention that it scales to large monorepos.
  • README: Add a link to the lightning-fast rebase demo.
  • README: Once git undo has a non-interactive mode, add an inline-playing demo to the README, so that the user doesn't have to visit another page to view the demo.
  • Finish unfinished workflow documentation items:
    • Stashing
    • Divergent development
  • Possible new workflow documentation items:
    • Making commits
    • Editing an old commit's contents
    • Editing an old commit's message
    • Reordering commits
    • Creating branches
    • Updating branches
    • Syncing branches with a Github pull request
    • Deleting branches
    • Updating local work on top of the remote main branch
  • Add documentation about git next/git prev --all/--branch flags.
  • Add documentation for git amend command.
terinjokes
terinjokes

It's a noop if the local branch and the remote branch have no commits. Otherwise it effectively fast-forwards to match the remote branch.

Nov
15
1 week ago
Activity icon
issue

terinjokes issue comment arxanas/git-branchless

terinjokes
terinjokes

Documentation enhancements

  • README: Put installation at the top/make it easier to get started
  • README: Mention that it scales to large monorepos.
  • README: Add a link to the lightning-fast rebase demo.
  • README: Once git undo has a non-interactive mode, add an inline-playing demo to the README, so that the user doesn't have to visit another page to view the demo.
  • Finish unfinished workflow documentation items:
    • Stashing
    • Divergent development
  • Possible new workflow documentation items:
    • Making commits
    • Editing an old commit's contents
    • Editing an old commit's message
    • Reordering commits
    • Creating branches
    • Updating branches
    • Syncing branches with a Github pull request
    • Deleting branches
    • Updating local work on top of the remote main branch
  • Add documentation about git next/git prev --all/--branch flags.
  • Add documentation for git amend command.
terinjokes
terinjokes

fwiw, git move -d origin/main doesn't seem to work if there are currently no commits on the stack, as it instead tries to create a cyclical loop. I'm used to running stg pull -m which handles both cases.

Activity icon
issue

terinjokes issue comment jetstack/cert-manager

terinjokes
terinjokes

cert-manager ignores existing controller OwnerReferences on secrets

Describe the bug:

If a Certificate resource is created with a secretName set to a secret that already exists, cert-manager will unconditionally update it, regardless if the secret is owned by another controller. If --enable-certificate-owner-ref=false this update does not reset the owner reference, leading the other controller to believe it is still the controlling owner. This other controller will reset the secret to the values it expects, causing cert-manager to reissue and update. This loop will continue, potentially tightly, until a human intervenes.

Expected behaviour:

Even if --enable-certificate-owner-ref=false, cert-manager should refuse to update a Secret where there is already a controlling owner reference.

Environment details::

  • Kubernetes version:
  • Cloud-provider/provisioner:
  • cert-manager version: 1.5.1
  • Install method: yaml manifests

/kind bug

terinjokes
terinjokes
started
started time in 1 week ago
Nov
11
2 weeks ago
started
started time in 2 weeks ago
Nov
10
2 weeks ago
started
started time in 2 weeks ago
Activity icon
issue

terinjokes issue comment NixOS/nixpkgs

terinjokes
terinjokes

[DRAFT] Add 1Password-GUI with BrowserHelper & KeyringHelper-Support

Motivation for this change

Getting 1password-gui working with browser-helper (unlocks browser-integration if GUI is unlocked and browser was closed) and system-authentication e.g. fingerprint (which is already working for sudo/i3lock-color via pam)

Things done

Translate install-scripts from release-tar (for debian) to nixos-module, tried to make Helper working with secruity-wrapper but still failing with:

Running build-output (1Password-KeyringHelper through wrapper as sudo):

INFO 2021-07-19T20:36:34.911 main(ThreadId(1)) [1P:foundation/op-linux/src/bin/keyring_helper.rs:144] initalizing keyring helper WARN 2021-07-19T20:36:35.180 main(ThreadId(1)) [1P:foundation/op-sys-info/src/process_verification.rs:124] binary permission verification failed for /nix/store/6krkl5ka31qd8ll1801w5z32cbm6k838-1password-8.1.2-10.BETA/share/1password/1Password-KeyringHelper2 ERROR 2021-07-19T20:36:35.182 main(ThreadId(1)) [1P:foundation/op-linux/src/bin/keyring_helper.rs:174] failed to verify keyring helper process permissions, aborting: BinaryPermissions

Running 1password which would start helper & browser-support:

INFO 2021-07-19T20:36:34.911 main(ThreadId(1)) [1P:foundation/op-linux/src/bin/keyring_helper.rs:144] initalizing keyring helper WARN 2021-07-19T20:36:35.180 main(ThreadId(1)) [1P:foundation/op-sys-info/src/process_verification.rs:124] binary permission verification failed for /nix/store/6krkl5ka31qd8ll1801w5z32cbm6k838-1password-8.1.2-10.BETA/share/1password/1Password-KeyringHelper2 ERROR 2021-07-19T20:36:35.182 main(ThreadId(1)) [1P:foundation/op-linux/src/bin/keyring_helper.rs:174] failed to verify keyring helper process permissions, aborting: BinaryPermissions ❯ 1password INFO 2021-07-19T20:39:11.057 ThreadId(1) [client:typescript] Client starting. INFO 2021-07-19T20:39:11.106 ThreadId(1) [1P:op-localization/src/lib.rs:155] system locale detected as 'en_US' INFO 2021-07-19T20:39:11.106 tokio-runtime-worker(ThreadId(3)) [1P:native-messaging/op-native-core-integration/src/lib.rs:201] Starting IPC listener on 1Password-BrowserSupport INFO 2021-07-19T20:39:11.106 ThreadId(1) [1P:op-localization/src/lib.rs:181] selected translations for EN_US based on detected locale en-US INFO 2021-07-19T20:39:11.106 ThreadId(1) [status:op-app/src/app.rs:201] App::new(1Password for Linux/80102010 (EN_US), /home/sebtm/.config/1Password/1password.sqlite) INFO 2021-07-19T20:39:11.106 tokio-runtime-worker(ThreadId(15)) [1P:native-messaging/op-native-core-integration/src/lib.rs:218] Active native core integration is awaiting messages INFO 2021-07-19T20:39:11.106 ThreadId(1) [1P:op-db/src/db.rs:94] Starting DB at version: 20 INFO 2021-07-19T20:39:11.107 op_executor:invocation_loop(ThreadId(20)) [1P:native-messaging/op-nm-installer/src/nix_utils.rs:70] Created NMH manifest at /home/sebtm/.config/google-chrome/NativeMessagingHosts/com.1password.1password.json INFO 2021-07-19T20:39:11.107 op_executor:invocation_loop(ThreadId(20)) [1P:native-messaging/op-nm-installer/src/nix_utils.rs:70] Created NMH manifest at /home/sebtm/.config/google-chrome-beta/NativeMessagingHosts/com.1password.1password.json INFO 2021-07-19T20:39:11.107 op_executor:invocation_loop(ThreadId(20)) [1P:native-messaging/op-nm-installer/src/nix_utils.rs:70] Created NMH manifest at /home/sebtm/.config/google-chrome-unstable/NativeMessagingHosts/com.1password.1password.json INFO 2021-07-19T20:39:11.107 op_executor:invocation_loop(ThreadId(20)) [1P:native-messaging/op-nm-installer/src/nix_utils.rs:70] Created NMH manifest at /home/sebtm/.config/chromium/NativeMessagingHosts/com.1password.1password.json INFO 2021-07-19T20:39:11.108 op_executor:invocation_loop(ThreadId(20)) [1P:native-messaging/op-nm-installer/src/nix_utils.rs:70] Created NMH manifest at /home/sebtm/.config/microsoft-edge-dev/NativeMessagingHosts/com.1password.1password.json INFO 2021-07-19T20:39:11.108 op_executor:invocation_loop(ThreadId(20)) [1P:native-messaging/op-nm-installer/src/nix_utils.rs:70] Created NMH manifest at /home/sebtm/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts/com.1password.1password.json INFO 2021-07-19T20:39:11.108 op_executor:invocation_loop(ThreadId(20)) [1P:native-messaging/op-nm-installer/src/nix_utils.rs:70] Created NMH manifest at /home/sebtm/.config/vivaldi/NativeMessagingHosts/com.1password.1password.json INFO 2021-07-19T20:39:11.108 op_executor:invocation_loop(ThreadId(20)) [1P:native-messaging/op-nm-installer/src/nix_utils.rs:70] Created NMH manifest at /home/sebtm/.config/vivaldi-snapshot/NativeMessagingHosts/com.1password.1password.json INFO 2021-07-19T20:39:11.108 op_executor:invocation_loop(ThreadId(20)) [1P:native-messaging/op-nm-installer/src/nix_utils.rs:70] Created NMH manifest at /home/sebtm/.mozilla/native-messaging-hosts/com.1password.1password.json INFO 2021-07-19T20:39:11.108 op_executor:invocation_loop(ThreadId(20)) [1P:native-messaging/op-nm-installer/src/nix_utils.rs:85] Successfully installed all native messaging manifests. INFO 2021-07-19T20:39:11.283 main(ThreadId(1)) [1P:foundation/op-linux/src/bin/keyring_helper.rs:144] initalizing keyring helper WARN 2021-07-19T20:39:11.503 main(ThreadId(1)) [1P:foundation/op-sys-info/src/process_verification.rs:124] binary permission verification failed for /nix/store/6krkl5ka31qd8ll1801w5z32cbm6k838-1password-8.1.2-10.BETA/share/1password/1Password-KeyringHelper2 ERROR 2021-07-19T20:39:11.506 main(ThreadId(1)) [1P:foundation/op-linux/src/bin/keyring_helper.rs:174] failed to verify keyring helper process permissions, aborting: BinaryPermissions WARN 2021-07-19T20:39:11.506 op_executor:invocation_loop(ThreadId(20)) [1P:foundation/op-linux/src/kernel_keyring.rs:824] failed to initialize keyring helper, its functionality will be unavailable: Io(Error { kind: UnexpectedEof, message: "failed to fill whole buffer" }) WARN 2021-07-19T20:39:11.506 op_executor:invocation_loop(ThreadId(20)) [1P:op-app/src/app/backend.rs:175] operation blocking event loop invoke Invocation(External(LockScreen())) took more than 50 ms (226 ms) INFO 2021-07-19T20:39:20.653 tokio-runtime-worker(ThreadId(15)) [1P:op-data-layer/src/load.rs:145] loaded 489 items in 8 vaults for account: INFO 2021-07-19T20:39:20.658 op_executor:invocation_loop(ThreadId(20)) [1P:op-app/src/app/backend/unlock.rs:81] Lock state changed: Unlocked INFO 2021-07-19T20:39:22.203 tokio-runtime-worker(ThreadId(14)) [1P:op-syncer/src/sync_job.rs:269] synced account <secret?> (0.135227973s) INFO 2021-07-19T20:39:22.203 tokio-runtime-worker(ThreadId(14)) [1P:op-data-layer/src/file.rs:501] find_and_complete_pending_uploads: '' INFO 2021-07-19T20:39:22.467 tokio-runtime-worker(ThreadId(14)) [1P:op-data-layer/src/sync.rs:475] The B5 Notifier for () has connected, now monitoring for events.

So I will try to contact 1Password through their forum :)


  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.
terinjokes
terinjokes

FWIW, I spent a while trying to get this to work with security wrappers including stracing the helper, and reviewing the kernel code. In the end, I couldn't get the keyctl stuff working correctly.

It seemed the helper was using a "special keyring id" to resolve the user's keyring id, then trying to open it by the resolved id, and failed because the effective uid didn't match. If instead it opened the keyring using the special keyring id itself, it would progress farther.

Activity icon
issue

terinjokes issue comment terinjokes/StickersStandard

terinjokes
terinjokes

Half-sized triangles & rectangles ftw.

When I read https://github.com/terinjokes/StickerConstructorSpec/pull/11 I just had to think of the awesome possibilities that half-diagonal sized mini-stickers would allow:

screenshot 2014-12-28 05 13 10

What do you think?

terinjokes
terinjokes

None yet, but I think I'm happy to include them. I'll try to write something up.

Previous