terinjokes

terinjokes

Software Engineer

Member Since 11 years ago

San Francisco, CA

Experience Points
367
follower
Lessons Completed
262
follow
Best Reply Awards
130
repos
Activity
Jan
15
1 week ago
started
started time in 1 week ago
Jan
14
1 week ago
started
started time in 1 week ago
started
started time in 1 week ago
started
started time in 1 week ago
push

terinjokes push terinjokes/home.nix

terinjokes
terinjokes

pkgs: khinsider 1.11.1 -> 2.0.1

commit sha: d465722b9c4c7bf222ace8e13ce8bcf976f62831

push time in 1 week ago
Jan
13
1 week ago
push

terinjokes push terinjokes/home.nix

terinjokes
terinjokes
terinjokes
terinjokes

commit sha: 6c3aa873a6bb0f89fc29fca320369ec7d4acf7cf

push time in 1 week ago
push

terinjokes push terinjokes/home.nix

terinjokes
terinjokes

global: add pasystray service

terinjokes
terinjokes

hosts: add alamo

Adds the "alamo" host, which is a modified copy of "telegraph".

terinjokes
terinjokes

packages: add khinisder at 1.11.1

commit sha: 63e06ddb57b5d6d37504864d34b7b6b15a126fb6

push time in 1 week ago
open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

To avoid accidentally persisting truncated files in the case of crashing or power failure, consider saving to a download file, then rename to the final filename the after writing is complete.

open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes
		trackCount := i + 1
		if trackNumEndLastCD != 0 {
			trackCount = trackCount - trackNumEndLastCD
		}
		trackFmt = fmt.Sprintf("%0*d %s", padLength, trackCount, trackFmt)
open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

This (and songMeta[i] below) might be clearer with a switch.

open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes
	switch {
	  case isUnderHomebrew():
		return "brew upgrade khinsider"
	  case runtime.GOOS == "windows":
		cmd := "iwr https://utf9k.net/khinsider/install.ps1 -useb | iex"
		if version != "" {
			cmd = fmt.Sprintf("$v=\"%s\"; ", version) + cmd
		}
		return cmd
	  default:
		return "curl -L \"https://utf9k.net/khinsider/install.sh\" | sh -s " + version
	}
open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

Should this be wrapping util.MakeRequest?

open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

Is there a reason not to do for i, track := album.Tracks { }?

pull request

terinjokes merge to marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

Without nitpicking too much, I've left a few comments for things that jump out at me.

open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

Double negative, consider rewording.

open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes
open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

Some albums have WAV, OGG, and M4A that might be worth tracking as well.

pull request

terinjokes merge to marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

Without nitpicking too much, I've left a few comments for things that jump out at me.

open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

Following XDG recommendations, this might be better at ~/.cacge/khinider/ (and this should probably be renamed getCachePath)

open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

If CheckForUpdates returns false then it always returns an empty string for remoteVersion.

open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

You can panic with a string. I don't think wrapping in an error is providing anything?

open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes

Might be worth considering combining this and the next if conditional?

open pull request

terinjokes wants to merge marcus-crane/khinsider

terinjokes
terinjokes

Rewrite khinsider

A full rewrite with a changelog coming sometime soon

Closes: #5 Closes: #1

terinjokes
terinjokes
		// Some of the numbering can be quite bad on khinsider so we shouldn't
started
started time in 1 week ago
Jan
12
1 week ago
started
started time in 1 week ago
started
started time in 1 week ago
started
started time in 1 week ago