thephpleague

thephpleague

A group of developers who have banded together to build solid, well tested PHP packages using modern coding standards.

Member Since 10 years ago

Worldwide

Experience Points
0
follower
Lessons Completed
0
follow
Best Reply Awards
154
repos
Activity
Oct
16
3 hours ago
push

colinodell push thephpleague/config

colinodell
colinodell

jekyll build from Action 041e508f1e0885a3e0f40092ec0fc4bda22adf4f

commit sha: 68e4eae8f33be58898e389ad1047903fe27f75e8

push time in 2 hours ago
push

colinodell push thephpleague/commonmark

colinodell
colinodell

jekyll build from Action 796a3dcbfae8cb6e6a41de492517f7a3cdf572f0

commit sha: effd9685017ad3404ec78657ede0483d1c3354ae

push time in 3 hours ago
Oct
15
1 day ago
started
started time in 3 hours ago
push

colinodell push thephpleague/commonmark

colinodell
colinodell

jekyll build from Action 796a3dcbfae8cb6e6a41de492517f7a3cdf572f0

commit sha: c919ae0dea0ecb8cc3749185b8c083683e589879

push time in 4 hours ago
push

colinodell push thephpleague/commonmark

colinodell
colinodell
colinodell
colinodell

Merge pull request #733 from pdelre/patch-1

Use github/super-linter/slim

commit sha: 796a3dcbfae8cb6e6a41de492517f7a3cdf572f0

push time in 4 hours ago
pull request

colinodell pull request thephpleague/commonmark

colinodell
colinodell

Use `github/super-linter/slim`

While reading SuperLinter's latest README, they now have a slim image available that can reduce build times. The linters they drop have no impact on markdownlint.

pull request

colinodell merge to thephpleague/commonmark

colinodell
colinodell

Use `github/super-linter/slim`

While reading SuperLinter's latest README, they now have a slim image available that can reduce build times. The linters they drop have no impact on markdownlint.

colinodell
colinodell

This is awesome - thank you so much!

started
started time in 6 hours ago
started
started time in 6 hours ago
started
started time in 7 hours ago
Activity icon
issue

pdelre issue comment thephpleague/csv

pdelre
pdelre

Are the maintainers interested in markdownlinting for Hacktoberfest?

Q A
Version n/a

Question

Would the maintainers be interested in PRs to improve the consistency of the markdown for Hacktoberfest? I had worked previously with thephpleague/commonmark to introduce markdownlint Action and take passes on correcting any discovered issues (Change List).

If so, I'd be happy to submit similar changes over the next few weeks. More information on Hacktoberfest and how they've improved the experience for maintainers this year is available here: https://hacktoberfest.digitalocean.com/resources/maintainers.

Checks before submitting

  • Be sure that there isn't already an issue about this. See: Issues list
  • Be sure that there isn't already a pull request about this. See: Pull requests
  • I have read, search and not found the information on the documentation website.
  • I have read, search and not found the information on PHP related forums and/or websites.
  • This issue is about 1 question around the package with no business or domain specific logic related to a specific situation.
  • The question has a descriptive title. For example: "Can I use the library with compressed CSV documents ?".
push

nyamsprod push thephpleague/csv

nyamsprod
nyamsprod
nyamsprod
nyamsprod

bump github/super-linter to v4 & use the slim image

nyamsprod
nyamsprod

Merge pull request #446 from pdelre/pdelre_pr_issue-437-add-markdownlint-action

Add Lint Docs GitHub Action

commit sha: 776e1731a7df3213207c4046c03dac4e5d45bf3b

push time in 7 hours ago
pull request

nyamsprod pull request thephpleague/csv

nyamsprod
nyamsprod

Add Lint Docs GitHub Action

Adds running markdownlint on pushes/PRs to ensure markdown is consistent across contributors.

An example failure can be seen here (errors already resolved in previous PRs): https://github.com/pdelre/csv/runs/3908903455?check_suite_focus=true

image

Activity icon
issue

nyamsprod issue comment thephpleague/csv

nyamsprod
nyamsprod

Are the maintainers interested in markdownlinting for Hacktoberfest?

Q A
Version n/a

Question

Would the maintainers be interested in PRs to improve the consistency of the markdown for Hacktoberfest? I had worked previously with thephpleague/commonmark to introduce markdownlint Action and take passes on correcting any discovered issues (Change List).

If so, I'd be happy to submit similar changes over the next few weeks. More information on Hacktoberfest and how they've improved the experience for maintainers this year is available here: https://hacktoberfest.digitalocean.com/resources/maintainers.

Checks before submitting

  • Be sure that there isn't already an issue about this. See: Issues list
  • Be sure that there isn't already a pull request about this. See: Pull requests
  • I have read, search and not found the information on the documentation website.
  • I have read, search and not found the information on PHP related forums and/or websites.
  • This issue is about 1 question around the package with no business or domain specific logic related to a specific situation.
  • The question has a descriptive title. For example: "Can I use the library with compressed CSV documents ?".
nyamsprod
nyamsprod

@pdelre I added the labels let me know if I forgot any of the PR ... thanks for your work

Activity icon
issue

pdelre issue thephpleague/csv

pdelre
pdelre

Are the maintainers interested in markdownlinting for Hacktoberfest?

Q A
Version n/a

Question

Would the maintainers be interested in PRs to improve the consistency of the markdown for Hacktoberfest? I had worked previously with thephpleague/commonmark to introduce markdownlint Action and take passes on correcting any discovered issues (Change List).

If so, I'd be happy to submit similar changes over the next few weeks. More information on Hacktoberfest and how they've improved the experience for maintainers this year is available here: https://hacktoberfest.digitalocean.com/resources/maintainers.

Checks before submitting

  • Be sure that there isn't already an issue about this. See: Issues list
  • Be sure that there isn't already a pull request about this. See: Pull requests
  • I have read, search and not found the information on the documentation website.
  • I have read, search and not found the information on PHP related forums and/or websites.
  • This issue is about 1 question around the package with no business or domain specific logic related to a specific situation.
  • The question has a descriptive title. For example: "Can I use the library with compressed CSV documents ?".
Activity icon
issue

pdelre issue comment thephpleague/csv

pdelre
pdelre

Are the maintainers interested in markdownlinting for Hacktoberfest?

Q A
Version n/a

Question

Would the maintainers be interested in PRs to improve the consistency of the markdown for Hacktoberfest? I had worked previously with thephpleague/commonmark to introduce markdownlint Action and take passes on correcting any discovered issues (Change List).

If so, I'd be happy to submit similar changes over the next few weeks. More information on Hacktoberfest and how they've improved the experience for maintainers this year is available here: https://hacktoberfest.digitalocean.com/resources/maintainers.

Checks before submitting

  • Be sure that there isn't already an issue about this. See: Issues list
  • Be sure that there isn't already a pull request about this. See: Pull requests
  • I have read, search and not found the information on the documentation website.
  • I have read, search and not found the information on PHP related forums and/or websites.
  • This issue is about 1 question around the package with no business or domain specific logic related to a specific situation.
  • The question has a descriptive title. For example: "Can I use the library with compressed CSV documents ?".
pdelre
pdelre

@nyamsprod Thank you for working with me on these PRs! I have one final request, that you consider adding the label hacktoberfest-accepted to the PRs which will give me credit for the contributions. I promise to not ask again. 😆

Related PRs: #442 #443 #444 #445 #446

Activity icon
issue

pdelre issue comment thephpleague/csv

pdelre
pdelre

Add markdownlint

RE: #437

This adds the .markdownlint.yml configuration from thephpleague/commonmark. I've run the configuration through a smaller subset of the docs/ directory as a sample of the likely changes in the larger directories (docs/7.0/, docs/8.0/, & docs/9.0/).

The most common violation is the code fense style (``` vs ~~~). Backticks were preferred for thephpleague/commonmark, but if this project would rather use tilde, I will adjust the configuration.

If this sample looks good, please let me know if you'd prefer one large PR or several medium sized PRs. Below are a breakdown of the remaining violations that can be addressed.

docs/9.0/

$ markdownlint 9.0 2>&1 | awk '{print $2}' | sort | uniq -c | sort -r
 188 MD048/code-fence-style
  13 MD012/no-multiple-blanks
  13 MD010/no-hard-tabs
  10 MD004/ul-style
   9 MD024/no-duplicate-heading/no-duplicate-header
   5 MD009/no-trailing-spaces
   3 MD047/single-trailing-newline
   2 MD040/fenced-code-language
   2 MD031/blanks-around-fences
   2 MD007/ul-indent
   1 MD046/code-block-style
   1 MD038/no-space-in-code
   1 MD026/no-trailing-punctuation
   1 MD014/commands-show-output
   1 MD001/heading-increment/header-increment

docs/8.0/

$ markdownlint 8.0 2>&1 | awk '{print $2}' | sort | uniq -c | sort -r
 128 MD048/code-fence-style
  47 MD004/ul-style
  35 MD010/no-hard-tabs
  18 MD024/no-duplicate-heading/no-duplicate-header
   8 MD012/no-multiple-blanks
   7 MD007/ul-indent
   2 MD047/single-trailing-newline
   2 MD040/fenced-code-language
   2 MD026/no-trailing-punctuation
   2 MD014/commands-show-output

docs/7.0/

$ markdownlint 7.0 2>&1 | awk '{print $2}' | sort | uniq -c | sort -r
  71 MD048/code-fence-style
  64 MD004/ul-style
  29 MD010/no-hard-tabs
   9 MD007/ul-indent
   5 MD031/blanks-around-fences
   2 MD047/single-trailing-newline
   2 MD040/fenced-code-language
   2 MD014/commands-show-output
   2 MD012/no-multiple-blanks
   1 MD036/no-emphasis-as-heading/no-emphasis-as-header
   1 MD026/no-trailing-punctuation
pull request

pdelre pull request thephpleague/csv

pdelre
pdelre

Add markdownlint

RE: #437

This adds the .markdownlint.yml configuration from thephpleague/commonmark. I've run the configuration through a smaller subset of the docs/ directory as a sample of the likely changes in the larger directories (docs/7.0/, docs/8.0/, & docs/9.0/).

The most common violation is the code fense style (``` vs ~~~). Backticks were preferred for thephpleague/commonmark, but if this project would rather use tilde, I will adjust the configuration.

If this sample looks good, please let me know if you'd prefer one large PR or several medium sized PRs. Below are a breakdown of the remaining violations that can be addressed.

docs/9.0/

$ markdownlint 9.0 2>&1 | awk '{print $2}' | sort | uniq -c | sort -r
 188 MD048/code-fence-style
  13 MD012/no-multiple-blanks
  13 MD010/no-hard-tabs
  10 MD004/ul-style
   9 MD024/no-duplicate-heading/no-duplicate-header
   5 MD009/no-trailing-spaces
   3 MD047/single-trailing-newline
   2 MD040/fenced-code-language
   2 MD031/blanks-around-fences
   2 MD007/ul-indent
   1 MD046/code-block-style
   1 MD038/no-space-in-code
   1 MD026/no-trailing-punctuation
   1 MD014/commands-show-output
   1 MD001/heading-increment/header-increment

docs/8.0/

$ markdownlint 8.0 2>&1 | awk '{print $2}' | sort | uniq -c | sort -r
 128 MD048/code-fence-style
  47 MD004/ul-style
  35 MD010/no-hard-tabs
  18 MD024/no-duplicate-heading/no-duplicate-header
   8 MD012/no-multiple-blanks
   7 MD007/ul-indent
   2 MD047/single-trailing-newline
   2 MD040/fenced-code-language
   2 MD026/no-trailing-punctuation
   2 MD014/commands-show-output

docs/7.0/

$ markdownlint 7.0 2>&1 | awk '{print $2}' | sort | uniq -c | sort -r
  71 MD048/code-fence-style
  64 MD004/ul-style
  29 MD010/no-hard-tabs
   9 MD007/ul-indent
   5 MD031/blanks-around-fences
   2 MD047/single-trailing-newline
   2 MD040/fenced-code-language
   2 MD014/commands-show-output
   2 MD012/no-multiple-blanks
   1 MD036/no-emphasis-as-heading/no-emphasis-as-header
   1 MD026/no-trailing-punctuation
pull request

pdelre pull request thephpleague/csv

pdelre
pdelre

Add Lint Docs GitHub Action

Adds running markdownlint on pushes/PRs to ensure markdown is consistent across contributors.

An example failure can be seen here (errors already resolved in previous PRs): https://github.com/pdelre/csv/runs/3908903455?check_suite_focus=true

image

Activity icon
issue

nyamsprod issue comment thephpleague/csv

nyamsprod
nyamsprod

Add markdownlint

RE: #437

This adds the .markdownlint.yml configuration from thephpleague/commonmark. I've run the configuration through a smaller subset of the docs/ directory as a sample of the likely changes in the larger directories (docs/7.0/, docs/8.0/, & docs/9.0/).

The most common violation is the code fense style (``` vs ~~~). Backticks were preferred for thephpleague/commonmark, but if this project would rather use tilde, I will adjust the configuration.

If this sample looks good, please let me know if you'd prefer one large PR or several medium sized PRs. Below are a breakdown of the remaining violations that can be addressed.

docs/9.0/

$ markdownlint 9.0 2>&1 | awk '{print $2}' | sort | uniq -c | sort -r
 188 MD048/code-fence-style
  13 MD012/no-multiple-blanks
  13 MD010/no-hard-tabs
  10 MD004/ul-style
   9 MD024/no-duplicate-heading/no-duplicate-header
   5 MD009/no-trailing-spaces
   3 MD047/single-trailing-newline
   2 MD040/fenced-code-language
   2 MD031/blanks-around-fences
   2 MD007/ul-indent
   1 MD046/code-block-style
   1 MD038/no-space-in-code
   1 MD026/no-trailing-punctuation
   1 MD014/commands-show-output
   1 MD001/heading-increment/header-increment

docs/8.0/

$ markdownlint 8.0 2>&1 | awk '{print $2}' | sort | uniq -c | sort -r
 128 MD048/code-fence-style
  47 MD004/ul-style
  35 MD010/no-hard-tabs
  18 MD024/no-duplicate-heading/no-duplicate-header
   8 MD012/no-multiple-blanks
   7 MD007/ul-indent
   2 MD047/single-trailing-newline
   2 MD040/fenced-code-language
   2 MD026/no-trailing-punctuation
   2 MD014/commands-show-output

docs/7.0/

$ markdownlint 7.0 2>&1 | awk '{print $2}' | sort | uniq -c | sort -r
  71 MD048/code-fence-style
  64 MD004/ul-style
  29 MD010/no-hard-tabs
   9 MD007/ul-indent
   5 MD031/blanks-around-fences
   2 MD047/single-trailing-newline
   2 MD040/fenced-code-language
   2 MD014/commands-show-output
   2 MD012/no-multiple-blanks
   1 MD036/no-emphasis-as-heading/no-emphasis-as-header
   1 MD026/no-trailing-punctuation
nyamsprod
nyamsprod

All is merged can we then close this PR then ?

push

nyamsprod push thephpleague/csv

nyamsprod
nyamsprod
nyamsprod
nyamsprod

consistency pass - remove PHP open tags

nyamsprod
nyamsprod

Merge pull request #445 from pdelre/pdelre_pr_issue-437-fix-docs-9.0-markdownlint-errors

Fix docs/9.0/ markdownlint errors

commit sha: 3a84918b73607e418895b33c726d7e1a249fae73

push time in 8 hours ago
pull request

nyamsprod pull request thephpleague/csv

nyamsprod
nyamsprod

Fix `docs/9.0/` markdownlint errors

Follow up to https://github.com/thephpleague/csv/pull/441#issuecomment-944160708 and https://github.com/thephpleague/csv/pull/442, this fixes the markdownlint violations in docs/9.0/.

Previous