valtism/resume
valtism/valtism.github.io
valtism/music-list
valtism/ultimate-tic-tac-toe
valtism/advent-of-code-2021
valtism/dotfiles
valtism issue comment yt-dlp/yt-dlp
As you can see from the actual output listed above, there already is string padding implemented, it is just done so in a broken way. Percentage downloaded is also padded.
I think that it would also be reasonable to limit the size of the speeds (convert 1000.00KiB/s to 1.00MiB/s) to save a character so the spacing doesn't look too big / awkward
valtism issue comment yt-dlp/yt-dlp
Encountered while downloading this video: https://www.youtube.com/watch?v=8qP2H1d8XXI
The download indicator in the terminal would jitter horizontally because the speed indicator seems to not be padded to a single size.
You can look at how the issue works in this REPL: https://replit.com/@DanielWood2/yt-dlp-console-speed?v=1 (uses functions from common.py and utils.py)
Actual output
- 0.00B/s -
- 1023.00B/s -
- 1.00KiB/s -
- 999.99KiB/s -
- 1000.00KiB/s -
- 1.91MiB/s -
Expected output
- 0.00B/s -
- 1023.00B/s -
- 1.00KiB/s -
- 999.99KiB/s -
- 1000.00KiB/s -
- 1.91MiB/s -
You can see how the current format_speed implementation does not properly pad the output string and leads to jitter on the download output.
[debug] Command-line config: ['-vU', 'https://www.youtube.com/watch?v=8qP2H1d8XXI&t=1810s']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.05.18 [b14d52355]
[debug] Python version 3.10.4 (CPython 64bit) - macOS-12.3.1-x86_64-i386-64bit
[debug] Checking exe version: ffprobe -bsfs
[debug] Checking exe version: ffmpeg -bsfs
[debug] exe versions: ffmpeg 5.0.1 (setts), ffprobe 5.0.1
[debug] Optional libraries: Cryptodome-3.14.1, brotli-1.0.9, certifi-2021.10.08, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
Latest version: 2022.05.18, Current version: 2022.05.18
yt-dlp is up to date (2022.05.18)
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=8qP2H1d8XXI&t=1810s
[youtube] 8qP2H1d8XXI: Downloading webpage
[youtube] 8qP2H1d8XXI: Downloading android player API JSON
[youtube] 8qP2H1d8XXI: Downloading m3u8 information
[youtube] 8qP2H1d8XXI: Downloading MPD manifest
[youtube] 8qP2H1d8XXI: Downloading m3u8 information
[youtube] 8qP2H1d8XXI: Downloading MPD manifest
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, codec:vp9.2, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] 8qP2H1d8XXI: Downloading 1 format(s): 301
[debug] Invoking hlsnative downloader on "https://manifest.googlevideo.com/api/manifest/hls_playlist/expire/1652956343/ei/V8iFYvyxN7DnrtoPtauDwAY/ip/2406:3400:209:420:a57d:e93b:ef18:a595/id/8qP2H1d8XXI.1/itag/301/source/yt_live_broadcast/requiressl/yes/ratebypass/yes/live/1/sgoap/gir%3Dyes%3Bitag%3D140/sgovp/gir%3Dyes%3Bitag%3D299/hls_chunk_host/rr2---sn-xmxuxa-ntql.googlevideo.com/force_finished/1/vprv/1/playlist_type/CLEAN/initcwndbps/11860/mh/mW/mm/44/mn/sn-xmxuxa-ntql/ms/lva/mv/m/mvi/2/pl/40/dover/11/pacing/0/keepalive/yes/fexp/24001373,24007246/beids/24153469/mt/1652934272/sparams/expire,ei,ip,id,itag,source,requiressl,ratebypass,live,sgoap,sgovp,force_finished,vprv,playlist_type/sig/AOq0QJ8wRAIgArr3kDOQGMI-yTBV6uZgFg4yozmd1GRJpkVv62sL0YYCIDewBDypkO3N8NvOf_KqXT7ldX0eFBt9VgMyZDs8h78I/lsparams/hls_chunk_host,initcwndbps,mh,mm,mn,ms,mv,mvi,pl/lsig/AG3C_xAwRQIhAIehiD1qGcbPe-MCMIA3AuEz34oaBpU-9prwHDpr4BGtAiBRBNbhy7-evaExp9I3ae-8yHTVgSHS4CiG6pljwNu00w%3D%3D/playlist/index.m3u8"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 2312
[download] Destination: STOP USING CREATE REACT APP - Web Dev Wednesday VOD [8qP2H1d8XXI].mp4
[download] 1.1% of ~530.35MiB at 442.41KiB/s ETA 20:18 (frag 25/2312)
Yes, the floating point moves, and the rest of the string (in this case ETA 20:18 (frag 25/2312)) moves back and forth because the length of the string behind it keeps changing.
valtism issue yt-dlp/yt-dlp
Encountered while downloading this video: https://www.youtube.com/watch?v=8qP2H1d8XXI
The download indicator in the terminal would jitter horizontally because the speed indicator seems to not be padded to a single size.
You can look at how the issue works in this REPL: https://replit.com/@DanielWood2/yt-dlp-console-speed?v=1 (uses functions from common.py and utils.py)
[debug] Command-line config: ['-vU', 'https://www.youtube.com/watch?v=8qP2H1d8XXI&t=1810s']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.05.18 [b14d52355]
[debug] Python version 3.10.4 (CPython 64bit) - macOS-12.3.1-x86_64-i386-64bit
[debug] Checking exe version: ffprobe -bsfs
[debug] Checking exe version: ffmpeg -bsfs
[debug] exe versions: ffmpeg 5.0.1 (setts), ffprobe 5.0.1
[debug] Optional libraries: Cryptodome-3.14.1, brotli-1.0.9, certifi-2021.10.08, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
Latest version: 2022.05.18, Current version: 2022.05.18
yt-dlp is up to date (2022.05.18)
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=8qP2H1d8XXI&t=1810s
[youtube] 8qP2H1d8XXI: Downloading webpage
[youtube] 8qP2H1d8XXI: Downloading android player API JSON
[youtube] 8qP2H1d8XXI: Downloading m3u8 information
[youtube] 8qP2H1d8XXI: Downloading MPD manifest
[youtube] 8qP2H1d8XXI: Downloading m3u8 information
[youtube] 8qP2H1d8XXI: Downloading MPD manifest
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, codec:vp9.2, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] 8qP2H1d8XXI: Downloading 1 format(s): 301
[debug] Invoking hlsnative downloader on "https://manifest.googlevideo.com/api/manifest/hls_playlist/expire/1652956343/ei/V8iFYvyxN7DnrtoPtauDwAY/ip/2406:3400:209:420:a57d:e93b:ef18:a595/id/8qP2H1d8XXI.1/itag/301/source/yt_live_broadcast/requiressl/yes/ratebypass/yes/live/1/sgoap/gir%3Dyes%3Bitag%3D140/sgovp/gir%3Dyes%3Bitag%3D299/hls_chunk_host/rr2---sn-xmxuxa-ntql.googlevideo.com/force_finished/1/vprv/1/playlist_type/CLEAN/initcwndbps/11860/mh/mW/mm/44/mn/sn-xmxuxa-ntql/ms/lva/mv/m/mvi/2/pl/40/dover/11/pacing/0/keepalive/yes/fexp/24001373,24007246/beids/24153469/mt/1652934272/sparams/expire,ei,ip,id,itag,source,requiressl,ratebypass,live,sgoap,sgovp,force_finished,vprv,playlist_type/sig/AOq0QJ8wRAIgArr3kDOQGMI-yTBV6uZgFg4yozmd1GRJpkVv62sL0YYCIDewBDypkO3N8NvOf_KqXT7ldX0eFBt9VgMyZDs8h78I/lsparams/hls_chunk_host,initcwndbps,mh,mm,mn,ms,mv,mvi,pl/lsig/AG3C_xAwRQIhAIehiD1qGcbPe-MCMIA3AuEz34oaBpU-9prwHDpr4BGtAiBRBNbhy7-evaExp9I3ae-8yHTVgSHS4CiG6pljwNu00w%3D%3D/playlist/index.m3u8"
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 2312
[download] Destination: STOP USING CREATE REACT APP - Web Dev Wednesday VOD [8qP2H1d8XXI].mp4
[download] 1.1% of ~530.35MiB at 442.41KiB/s ETA 20:18 (frag 25/2312)
valtism push valtism/unsong-contentlayer
Add font size buttons
Add padding for mobile
commit sha： d791879a167fb12e0cd946c244ee3fab95772cb1
push time in 4 days ago
valtism issue comment pd4d10/vite-plugin-svgr
I'd like to know what has changed in recent versions, to decide whether I should update.
Agreed. Especially concerning with major version updates and not knowing what the breaking changes are.
valtism issue contentlayerdev/website
Tested in MacOS Safari and Chrome. Returns the error Couldn't parse context 'https:/github.com/contentlayerdev/next-contentlayer-example'.
valtism issue comment contentlayerdev/contentlayer
Tested in MacOS Safari and Chrome. Returns the error Couldn't parse context 'https:/github.com/contentlayerdev/next-contentlayer-example'.
This at the top of the Getting Started page: https://www.contentlayer.dev/docs/getting-started in the "Try It Now" box
valtism push valtism/tailwindcss.com
Update divide color examples
Update divide opacity examples
Update divide style example
home page hero responsive
Merge branch 'next' of github.com:tailwindlabs/tailwindcss.com-next into next
tweak "ready-made components" animation
Update background color examples
Update background opacity examples
Update background clip examples
Update background image examples
Update gradient color stops examples
Merge branch 'next' of github.com:tailwindlabs/tailwindcss.com-next into next
Add compatibility build docs
Update search and progress styles
Make version switch to v1 work, link home page tiles
Remove TuiBanner
Update box shadow examples
Update opacity examples
Update fill examples
Update stroke examples
commit sha： d0a2da7695ce08ac658bb056f3104904600f8a13
push time in 1 week ago
valtism issue contentlayerdev/contentlayer
Tested in MacOS Safari and Chrome. Returns the error Couldn't parse context 'https:/github.com/contentlayerdev/next-contentlayer-example'.
valtism push valtism/tailwindcss.com
Fix new code line highlight
commit sha： fc46afbb48625a638fe449bee2c48808b32b5b87
push time in 2 weeks agovaltism push valtism/tailwindcss.com
Actually make the code change
commit sha： ed10d21419d36cbbdc093c0f59a3b60b498d41b5
push time in 2 weeks agovaltism pull request tailwindlabs/tailwindcss.com
As someone who is not familiar with glob patterns, I just spent a good chunk of time trying to figure out if excluding patterns was possible. It doesn't mention it anywhere in the tailwind documentation, so I thought it would be a good idea to add it here as a small note for posterity.
valtism push valtism/tailwindcss.com
Add note on exclusion glob patterns
As someone who is not familiar with glob patterns, I just spent a good chunk of time trying to figure out if excluding patterns was possible. It doesn't mention it anywhere in the tailwind documentation, so I thought it would be a good idea to add it here as a small note for posterity.
commit sha： 78cf7a9cd17e71847e715599a002f7c3a0a5df89
push time in 2 weeks agovaltism push valtism/unsong-markdown
Add readme
commit sha： 5cd5cd724fa1cd571633a93379f9b42e19266116
push time in 2 weeks ago
valtism issue comment tailwindlabs/headlessui
What package within Headless UI are you using?
@headlessui/react
What version of that package are you using?
v1.5.0
What browser are you using?
N/A
Reproduction URL
N/A
Describe your issue
In React + Typescript, a common pattern I follow is to wrap a library component for styling or custom behaviour before exposing it to the rest of the codebase. I like to mirror the underlying component props so that Typescript intellisense can provide the same prop hints to for the wrapper component as the underlying library component.
Here is an example of what I want:
// Wrapping a tab for custom styling. TabProps, however, does not exist;
function TemplateLibraryTab({ children, ...props }: TabProps) {
return (
<Tab
{...props}
className={({ selected }) =>
clsx("p-2 rounded", selected ? "text-gray-900" : "text-gray-500")
}
>
{children}
</Tab>
)
}
HeadlessUI does not seem to expose these props, or at least I could not find them. Would it be possible to export these prop types for this purpose? I think it is a strong use-case.
I should point out that there is a workaround for this. You can use React.ComponentProps to pull out the type from the component.
function TemplateLibraryTab({ children, ...props }: React.ComponentProps<typeof Tab>) {
return (
<Tab
{...props}
className={({ selected }) =>
clsx("p-2 rounded", selected ? "text-gray-900" : "text-gray-500")
}
>
{children}
</Tab>
)
}
This works in this use-case, but I have run into issues with it in the past. I still think that exporting prop types like other libraries is a good thing to have.
valtism issue tailwindlabs/headlessui
What package within Headless UI are you using?
@headlessui/react
What version of that package are you using?
v1.5.0
What browser are you using?
N/A
Reproduction URL
N/A
Describe your issue
In React + Typescript, a common pattern I follow is to wrap a library component for styling or custom behaviour before exposing it to the rest of the codebase. I like to mirror the underlying component props so that Typescript intellisense can provide the same prop hints to for the wrapper component as the underlying library component.
Here is an example of what I want:
// Wrapping a tab for custom styling.
// TabProps, however, does not exist. I would have to write out each prop manually for typing this component.
function TemplateLibraryTab({ children, ...props }: TabProps) {
return (
<Tab
{...props}
className={({ selected }) =>
clsx("p-2 rounded font-medium", selected ? "text-gray-900 bg-gray-200" : "text-gray-500")
}
>
{children}
</Tab>
)
}
HeadlessUI does not seem to expose these props, or at least I could not find them. Would it be possible to export these prop types for this purpose? I think it is a strong use-case.
valtism push valtism/votey
Add prisma
Change file structure
commit sha： ebc08ea0760b9b66054ab6f3993a793f956d6895
push time in 2 weeks agovaltism push valtism/climb-tags
Change local dev port
commit sha： 68828d5b1ce3bb62f2f19478230b3fd5a66d5a44
push time in 1 month agovaltism push valtism/climb-tags
Update README.md
commit sha： 054053aebd3c22656f2a9ee022c156e43497522e
push time in 1 month agovaltism push valtism/climb-tags
Update README.md
commit sha： 66d9632ddf4278dca51adf9b9ca3b8b0fa1ac6be
push time in 1 month agovaltism push valtism/climb-tags
Update README.md
commit sha： 561438f9559fb8b55029ad76479ff97fc0aa44ff
push time in 1 month agovaltism push valtism/climb-tags
Show comparison images
commit sha： dc2085cf233110eb21b654c3091c64135bebe1e5
push time in 1 month agovaltism push valtism/climb-tags
Turn off spellcheck for text inputs
commit sha： 7726bad8832e73c99b268acd2b22f785f95da34b
push time in 1 month ago
Download speed causes jitter in terminal output
Checklist
Description
Encountered while downloading this video: https://www.youtube.com/watch?v=8qP2H1d8XXI
The download indicator in the terminal would jitter horizontally because the speed indicator seems to not be padded to a single size.
You can look at how the issue works in this REPL: https://replit.com/@DanielWood2/yt-dlp-console-speed?v=1 (uses functions from
common.pyandutils.py)You can see how the current
format_speedimplementation does not properly pad the output string and leads to jitter on the download output.Verbose log