vishesh

vishesh

Member Since 11 years ago

Apple, Cupertino, CA

Experience Points
71
follower
Lessons Completed
4
follow
Lessons Completed
307
stars
Best Reply Awards
37
repos

580 contributions in the last year

Pinned
⚡ FoundationDB - the open source, distributed, transactional key-value store
⚡ Racket to JavaScript Compiler
⚡ FoundationDB - the open source, distributed, transactional key-value store
Activity
Jan
24
3 days ago
pull request

vishesh pull request apple/foundationdb

vishesh
vishesh

ptxn: Create one team for seed servers

With key-splits, we had single storage server per team, and each seed-server had its own team. This reverts back to previous behaviour of having single seed shard.

ref: https://github.com/apple/foundationdb/pull/5964.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)
push

vishesh push vishesh/foundationdb

vishesh
vishesh

check the single page vs multi page in upper readPage function call

vishesh
vishesh

Fixed a few bugs and added a backup popping mechanism

vishesh
vishesh

Replaced clear() with krmSetRangeCoalescing().

vishesh
vishesh

Add missing wait around deleteFile invocations.

vishesh
vishesh

Add metrics for blob worker.

We want to add metrics for the blob worker to evaluate its performance more concretely. We decided to track the following information:

  • s3 put requests
  • s3 get requests
  • S3 delete requests
  • Delta files written
  • Snapshot files written
  • Delta bytes written
  • Snapshot bytes written
  • Number of current ranges assigned
  • Bytes read from FDB (initial snapshot)
  • Bytes read from S3 (compaction)
  • Read requests count
  • Read files returned
  • Read deltas returned
  • Read delta bytes returned
  • Ranges assigned
  • Ranges revoked
  • Number of current ranges assigned
  • Total mutation bytes buffered across all ranges // current or accumulated
  • Range feed bytes input
  • Range feed mutations input
  • Wrong Shard Server count
vishesh
vishesh

check the thoroughput without the keeping the size

vishesh
vishesh

Add BlobWorkerCommon to CMakeLists.

vishesh
vishesh

filter mutations in change feeds to the requested range

vishesh
vishesh

Merge pull request #10 from sfc-gh-sgupta/blob-worker-metrics

Add metrics to blob worker

vishesh
vishesh

added a workload to test change feeds

vishesh
vishesh

Delete CycleTestRestart-1.txt

vishesh
vishesh

Delete CycleTestRestart-2.txt

vishesh
vishesh

fixed problems with the change feed workload

vishesh
vishesh

fixes that allow change feeds to pass correctness in tests with no failures

vishesh
vishesh

Fixed a number of bugs, change feeds are correctness clean with the current workload

vishesh
vishesh

fixed a few bugs related to change feed fetches

vishesh
vishesh

fix: handle the case where I change feed is added while a fetch is in progress

commit sha: c3cf20a59db1d0dcb66678ec34ffb580c714aa99

push time in 2 days ago
pull request

vishesh pull request apple/foundationdb

vishesh
vishesh

ptxn: Create one team for seed servers

With key-splits, we had single storage server per team, and each seed-server had its own team. This reverts back to previous behaviour of having single seed shard.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)
Activity icon
created branch

vishesh in vishesh/foundationdb create branch task/seed-server-team

createdAt 2 days ago
Jan
19
1 week ago
started
started time in 1 week ago
push

vishesh push racketscript/racketscript

vishesh
vishesh

badges badges badges!

just some pretty badges.

vishesh
vishesh

Merge pull request #295 from spdegabrielle/patch-1

badges badges badges!

commit sha: d865e8d2e33900bd3e64c3f867cf8440ff581638

push time in 1 week ago
pull request

vishesh pull request racketscript/racketscript

vishesh
vishesh

badges badges badges!

just some pretty badges.

Jan
18
1 week ago
started
started time in 1 week ago
Jan
13
2 weeks ago
push

vishesh push vishesh/foundationdb

vishesh
vishesh

Don't count same SS twice because of multiple team

commit sha: bf0e89f9dd488763f30beb19f1c271a9ccfe87a0

push time in 2 weeks ago
Jan
8
2 weeks ago
started
started time in 2 weeks ago
Jan
7
2 weeks ago
open pull request

vishesh wants to merge racketscript/racketscript

vishesh
vishesh

add $/async and $/await to racketscript/interop

vishesh
vishesh

So if I'm understanding this correctly, this won't be using async/await. And I can see why this may not work, as when we render, the image may not be ready as its getting downloaded in background. I think this is HTMLImageElement and maybe you can add an assert for complete field in render() to see if we render once image is loaded.

open pull request

vishesh wants to merge racketscript/racketscript

vishesh
vishesh

add $/async and $/await to racketscript/interop

vishesh
vishesh

This is probably what we need to be doing, except I think bitmap/url is supposed to be a synchronous function, so this being async, will return aPromise object instead of Bitmap, and probably that's why it gives render is not a function error (since the contract is broken by it being a Promise).

Not sure what would be right way atm. Practically, its bad idea to put bitmap/url function in game-loop. It will block the frame until image is loaded in Racket too.

Jan
6
3 weeks ago
started
started time in 2 weeks ago
Jan
5
3 weeks ago
push

vishesh push racketscript/racketscript

vishesh
vishesh

racks: set current-source-file with --il option; closes #291

vishesh
vishesh

Merge pull request #292 from stchang/racks

racks: set current-source-file with --il option; closes #291

commit sha: d2dc0ba5f613e59af862d08152170a23f63637c6

push time in 3 weeks ago
Activity icon
issue

vishesh issue racketscript/racketscript

vishesh
vishesh

racks with --il option errors

current-source-file parameter not set

$ cat test.rkt
#lang racket
(+ 1 2)
$ racks --il test.rkt
    .... snipped ....
module->relative-import: current-source-file is #f
pull request

vishesh pull request racketscript/racketscript

vishesh
vishesh

racks: set current-source-file with --il option; closes #291

Jan
1
3 weeks ago
started
started time in 3 weeks ago
Dec
31
3 weeks ago
started
started time in 3 weeks ago
push

vishesh push racketscript/racketscript

vishesh
vishesh

interop: add shorthand for testing undefined or null

vishesh
vishesh

Merge pull request #289 from stchang/interop

interop: add shorthand for testing undefined or null

commit sha: 23d3be9c76d798bee53509a3c7cfb2292e6babdf

push time in 3 weeks ago
pull request

vishesh pull request racketscript/racketscript

vishesh
vishesh

interop: add shorthand for testing undefined or null

pull request

vishesh merge to racketscript/racketscript

vishesh
vishesh

interop: add shorthand for testing undefined or null

push

vishesh push racketscript/racketscript

vishesh
vishesh

Merge pull request #290 from stchang/data

add vector-copy

commit sha: 1b4770452f39abd639befbb193583d37ac41ac8f

push time in 3 weeks ago
Dec
24
1 month ago
Activity icon
issue

vishesh issue comment apple/foundationdb

vishesh
vishesh

Merge master into PTXN branch

Correctness passed:

Merge master HEAD (failed one is timeout of SnapCycleRestart-1.toml, probably unrelated): 20211221-223335-jzhou-d5ab3c04a2fa45c7 compressed=True data_size=29916913 duration=5351039 ended=100000 fail=1 fail_fast=10 max_runs=100000 pass=99999 priority=100 remaining=0 runtime=0:55:34 sanity=False started=100191 stopped=20211221-232909 submitted=20211221-223335 timeout=5400 username=jzhou

Merge up to PR 6076: 20211221-213053-jzhou-5897c95efbea8726 compressed=True data_size=29858178 duration=5497145 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=1:01:13 sanity=False started=100599 stopped=20211221-223206 submitted=20211221-213053 timeout=5400 username=jzhou

Merge up to PR 5327: 20211221-180213-jzhou-59e5c26b33fb7e34 compressed=True data_size=29132021 duration=5107049 ended=100001 fail_fast=10 max_runs=100000 pass=100001 priority=100 remaining=0 runtime=0:47:58 sanity=False started=100230 stopped=20211221-185011 submitted=20211221-180213 timeout=5400 username=jzhou

Merge up to PR 5740:. 20211221-053518-jzhou-2b1c8d8666d1f206 compressed=True data_size=20569519 duration=3610553 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=0:46:35 sanity=False started=100246 stopped=20211221-062153 submitted=20211221-053518 timeout=5400 username=jzhou

PTXN test passed (with/without proxy-to-tlog group broadcast):

-r simulation --crash --logsize 1024MB --knob_tlog_new_interface 1 -fi off -f src/foundationdb/tests/ptxn/CycleTest.toml -b off -s 101

-r simulation --crash --logsize 1024MB --knob_tlog_new_interface 1 -fi off -f src/foundationdb/tests/ptxn/CycleTest.toml -b off -s 101 --knob_broadcast_tlog_groups 0

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)
vishesh
vishesh

LGTM. I believe the CI failure is because master was broken earlier too?

Previous