wintercounter

wintercounter

Ex-full-stack, now front-end focused dev, doing some OSS projects for fun, with love.

Member Since 10 years ago

@DoclerLabs , Luxembourg & Trier

Experience Points
30
follower
Lessons Completed
19
follow
Lessons Completed
204
stars
Best Reply Awards
62
repos

567 contributions in the last year

Pinned
⚡ 🧩 A zero-config, out-of-the-box, multi-purpose toolbox and development environment
⚡ 🔡🔁🎨 CrypticCSS - A companion on the journey to your next CSS-in-JS and/or design system solution.
⚡ A new generation jQuery Tooltip plugin
⚡ 0kb footprint, modular, configurable SASS framework to be used with CSS modules (or not).
⚡ React `useBreakpoint` hook to have different values for a variable based on a breakpoints.
Activity
Nov
29
4 days ago
Activity icon
created tag
createdAt 3 days ago
push

wintercounter push wintercounter/ccss

wintercounter
wintercounter

feat(props): add padding-, margin-block, line-clamp, content-visibility, contain-intrinsic-size

commit sha: 1b5782d33f016590896a82f86013cad361031fab

push time in 3 days ago
pull request

wintercounter pull request wintercounter/ccss

wintercounter
wintercounter

feat(props): adding padding-, margin-block, line-clamp, content-visibility, contain-intrinsic-size, inset

Adding:

  • padding-block
  • margin-block
  • line-clamp
  • content-visibility
  • contain-intrinsic-size
  • inset
Nov
25
1 week ago
Nov
11
3 weeks ago
Activity icon
issue

wintercounter issue thumbor/thumbor

wintercounter
wintercounter

High memory usage while using `thumbor.result_storages.no_storage`

Expected behaviour

No high memory usage when using thumbor.result_storages.no_storage.

Actual behaviour

My thumbor processes take up 2-3.5GB RAM each. No caching is done anywhere, so there should be no reason for this memory usage. This is achieved by running the processes for a while (days, weeks), so seems like it's probably a memory leak. I'm using nginx-proxy-cache in front of it, that's why I don't really need the storage.

Operating system

Docker, Alpine base

Your thumbor.conf

I'm using minimalcompact/thumbor, pasting my env vars here:

environment:
    - VIRTUAL_HOST=0.0.0.0
    - VIRTUAL_PORT=8888
    - THUMBOR_NUM_PROCESSES=4
    - CORS_ALLOW_ORIGIN=*
    - AUTO_WEBP=True
    - RESULT_STORAGE=thumbor.result_storages.no_storage
    - RESULT_STORAGE_STORES_UNSAFE=True
    - LOADER=thumbor.loaders.file_loader_http_fallback
    - FILE_LOADER_ROOT_PATH=/files
    - THUMBOR_PORT=8888
    - SECURITY_KEY=****
    - ALLOW_UNSAFE_URL=False
Activity icon
issue

wintercounter issue comment thumbor/thumbor

wintercounter
wintercounter

High memory usage while using `thumbor.result_storages.no_storage`

Expected behaviour

No high memory usage when using thumbor.result_storages.no_storage.

Actual behaviour

My thumbor processes take up 2-3.5GB RAM each. No caching is done anywhere, so there should be no reason for this memory usage. This is achieved by running the processes for a while (days, weeks), so seems like it's probably a memory leak. I'm using nginx-proxy-cache in front of it, that's why I don't really need the storage.

Operating system

Docker, Alpine base

Your thumbor.conf

I'm using minimalcompact/thumbor, pasting my env vars here:

environment:
    - VIRTUAL_HOST=0.0.0.0
    - VIRTUAL_PORT=8888
    - THUMBOR_NUM_PROCESSES=4
    - CORS_ALLOW_ORIGIN=*
    - AUTO_WEBP=True
    - RESULT_STORAGE=thumbor.result_storages.no_storage
    - RESULT_STORAGE_STORES_UNSAFE=True
    - LOADER=thumbor.loaders.file_loader_http_fallback
    - FILE_LOADER_ROOT_PATH=/files
    - THUMBOR_PORT=8888
    - SECURITY_KEY=****
    - ALLOW_UNSAFE_URL=False
wintercounter
wintercounter

I think once it reaches ~4GB it's not growing further. Seems like this normal/expected then, I'm closing the thread. I guess my only option on a low RAM machine is to use fewer workers then. Thanks for the info.

Activity icon
issue

wintercounter issue comment remix-run/react-router

wintercounter
wintercounter

allow more regex for paths instead of the defaults [Feature]:

What is the new or updated feature that you are suggesting?

update current route.path to allow more conditional regex paths for multiple conditions like in v5.

v5 route: /(wines|whiskeys|sakes|beers)/:id/:productName?

Why should this feature be included?

current v6 doesnt include this anymore. only allow strict routes.

wintercounter
wintercounter

I was also about to open a feature request for a similar case. In my codebase, I heavily rely on path-to-regexp features. The upgrade docs say to move such logic at the component level, but for me, that's not possible, paths are set by users from an admin interface where components don't (and can't) include such logic.

I was thinking if we can have a plugin-like solution where we can supply a pathParser prop to Router. This would allow using any custom solution we need, keeping the base library small and dependency-free, but allowing people to create 3rd party community packages to add support back to path-to-regexp for example. I think this could be a win-win solution for all parties.

Activity icon
issue

wintercounter issue comment remix-run/react-router

wintercounter
wintercounter

allow more regex for paths instead of the defaults [Feature]:

What is the new or updated feature that you are suggesting?

update current route.path to allow more conditional regex paths for multiple conditions like in v5.

v5 route: /(wines|whiskeys|sakes|beers)/:id/:productName?

Why should this feature be included?

current v6 doesnt include this anymore. only allow strict routes.

wintercounter
wintercounter

I was also about to open a feature request for a similar case. In my codebase, I heavily rely on path-to-regexp features. The upgrade docs say to move such logic at the component level, but for me, that's not possible, paths are set by users from an admin interface where components don't (and can't) include such logic.

I was thinking if we can have a plugin-like solution where we can supply a pathParser prop to Router. This would allow using any custom solution we need, keeping the base library small and dependency-free, but allowing people to create 3rd party community packages to add support back to path-to-regexp for example. I think this could be a win-win situation for all parties.

Nov
10
3 weeks ago
Activity icon
issue

wintercounter issue thumbor/thumbor

wintercounter
wintercounter

High memory usage while using `thumbor.result_storages.no_storage`

Expected behaviour

No high memory usage when using thumbor.result_storages.no_storage.

Actual behaviour

My thumbor processes take up 2-3.5GB RAM each. No caching is done anywhere, so there should be no reason for this memory usage. This is achieved by running the processes for a while (days, weeks), so seems like it's probably a memory leak. I'm using nginx-proxy-cache in front of it, that's why I don't really need the storage.

Operating system

Docker, Alpine base

Your thumbor.conf

I'm using minimalcompact/thumbor, pasting my env vars here:

environment:
    - VIRTUAL_HOST=0.0.0.0
    - VIRTUAL_PORT=8888
    - THUMBOR_NUM_PROCESSES=4
    - CORS_ALLOW_ORIGIN=*
    - AUTO_WEBP=True
    - RESULT_STORAGE=thumbor.result_storages.no_storage
    - RESULT_STORAGE_STORES_UNSAFE=True
    - LOADER=thumbor.loaders.file_loader_http_fallback
    - FILE_LOADER_ROOT_PATH=/files
    - THUMBOR_PORT=8888
    - SECURITY_KEY=****
    - ALLOW_UNSAFE_URL=False
Nov
4
4 weeks ago
started
started time in 4 weeks ago
Nov
1
1 month ago
started
started time in 1 month ago
Oct
31
1 month ago
Oct
27
1 month ago
started
started time in 1 month ago
Activity icon
issue

wintercounter issue comment styled-components/styled-components

wintercounter
wintercounter

createGlobalStyle adds stylings to the <head> twice in 5.0.1

Environment

⬇️ see codesandbox example.

Reproduction

Steps to reproduce

Open the provided codesandbox and inspect the styling of either of the headlines. The h1 (or h2) styling is applied twice because it was added twice to the document.

If you downgrade styled-components (see codesandbox) to the latest 4.x.x version and inspect the elements again, everything is fine.

Expected Behavior

Global style is added only once.

Actual Behavior

Global style is added twice to the document (also in a SSR scenario, which happens in one of our apps right now).

Screenshots

Bug with version 5.0.1

image

Working w/ version 4.4.1

image

wintercounter
wintercounter

I have the same problem. What's even worse is that for some reason my global styles are added to the end of the style tag. Using 5.3.3 with SSR and getDataFromTree from @apollo/client.

Oct
23
1 month ago
Activity icon
issue

wintercounter issue wintercounter/eslint-global-patch

wintercounter
wintercounter

Suggestion: use version numbers synchronize with ESLint's

For example, if the current version of eslint-global-patch suits [email protected], then mark it as [email protected].

Then users will be confident to use [email protected] with [email protected], or simply use [email protected] with [email protected] in their package.json files.

In case ESLint upgrades to v7, version numbers could remind users that they should wait for [email protected].


Thanks to this tool which saves our CI program. 👍

Activity icon
issue

wintercounter issue wintercounter/eslint-global-patch

wintercounter
wintercounter

eslint-global-patch doesn't support Eslint 8

Looks like it can't work with Eslint 8

Activity icon
issue

wintercounter issue comment wintercounter/eslint-global-patch

wintercounter
wintercounter

eslint-global-patch doesn't support Eslint 8

Looks like it can't work with Eslint 8

wintercounter
wintercounter
Activity icon
issue

wintercounter issue wintercounter/eslint-global-patch

wintercounter
wintercounter

Regarding [email protected]

The file needed to modify is now eslint/node_modules/@eslint/eslintrc/dist/eslintrc.js

Activity icon
issue

wintercounter issue comment wintercounter/eslint-global-patch

wintercounter
wintercounter

Regarding [email protected]

The file needed to modify is now eslint/node_modules/@eslint/eslintrc/dist/eslintrc.js

wintercounter
wintercounter

I added the file to the list. I myself couldn't test ESLint 8 completely, the ecosystem is just not there yet, for example, v8 support from @eslint/babel-parser is a must for me to work. Let's hope it'll work for you guys in your case. Version is 8.1.1.

Oct
22
1 month ago
Previous