wschwab

wschwab

eipnft: wschwab.eth

Member Since 4 years ago

Experience Points
17
follower
Lessons Completed
6
follow
Lessons Completed
38
stars
Best Reply Awards
76
repos

182 contributions in the last year

Pinned
⚡ ERC721 With Permits
Activity
Jan
24
17 hours ago
open pull request

wschwab wants to merge ethereum/EIPs

wschwab
wschwab

move 2612 to Review

This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.

pull request

wschwab merge to ethereum/EIPs

wschwab
wschwab

move 2612 to Review

This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.

open pull request

wschwab wants to merge ethereum/EIPs

wschwab
wschwab

move 2612 to Review

This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.

wschwab
wschwab

updated (removed hash, made all links relative)

pull request

wschwab merge to ethereum/EIPs

wschwab
wschwab

move 2612 to Review

This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.

open pull request

wschwab wants to merge ethereum/EIPs

wschwab
wschwab

move 2612 to Review

This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.

pull request

wschwab merge to ethereum/EIPs

wschwab
wschwab

move 2612 to Review

This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.

push

wschwab push wschwab/EIPs

wschwab
wschwab

commit sha: 7391996b2ef79006e9da317772f69a1c925b023a

push time in 40 minutes ago
Jan
23
1 day ago
Activity icon
issue

wschwab issue comment ethereum/EIPs

wschwab
wschwab

Described transactions

Adding an EIP for described transactions, splitting EIP-3224 into multiple EIPs as discussed on the discussions to.

(the EIP number in the draft will be updated once this PR has been assigned a number and this PR updated)

wschwab
wschwab

sorry, I'd missed this - will take a look (prolly not today, but within the next couple/few)

Activity icon
issue

wschwab issue comment ethereum/EIPs

wschwab
wschwab

move 2612 to Review

This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.

wschwab
wschwab

@lightclient I've pushed a commit that implements your suggestions

Activity icon
issue

wschwab issue comment ethereum/EIPs

wschwab
wschwab

Mark EIP1967 as Last Call with deadline 2022-01-16

Moving EIP1967 to last call. Let me know if there are any other changes needed before we can do this!

wschwab
wschwab

@fulldecent I'm not sure I understand what you would need to see changed here - could you be a bit more specific?

Activity icon
issue

wschwab issue andrecronje/solidly

wschwab
wschwab

Potential Double Spend on Chain Split

From the Security Considerations section of EIP-2612:

If the DOMAIN_SEPARATOR contains the chainId and is defined at contract deployment instead of reconstructed for every signature, there is a risk of possible replay attacks between chains in the event of a future chain split.

This means that if Fantom were to have a chain split (into Fantom and Fantom Classic, let's say), then messages signed on Fantom (same chainId would still be able to be used on Solidly on Fantom Classic since the chainId was hardcoded on deployment.

This is certainly not the biggest concern in the world.

ofc, we'd all still like to not need to compute the DOMAIN_SEPARATOR every time there's a permit being made. Solmate has a nice trick in their stock ERC20 token where they make sure the current chainId is the same as it was at launch, and uses the DOMAIN_SEPARATOR from deployment, and only recomputes if it's different. Source

I could make a PR with this if you'd like - I figured opening an issue was better since it might not be such an issue.

Jan
18
6 days ago
push

wschwab push wschwab/sway

wschwab
wschwab

Update docs/src/getting-started/forc_project.md

Co-authored-by: John Adler [email protected]

commit sha: 2a794ff57b806a7ae220c021127c242726233a54

push time in 6 days ago
pull request

wschwab pull request FuelLabs/sway

wschwab
wschwab

Add details in "A Forc Project"

adds forc abi-json and details about entry in Forc.toml` to the "A Forc Project" page, fixing #658 and #659

push

wschwab push wschwab/sway

wschwab
wschwab

Add details in "A Forc Project"

adds forc abi-json and details about entry in Forc.toml` to the "A Forc Project" page, fixing #658 and #659

commit sha: 1ae4a944e7b80e73ccb2d258aea73e4007021e37

push time in 6 days ago
Activity icon
fork

wschwab forked FuelLabs/sway

⚡ 🌴 Sway, a DSL for the FuelVM.
wschwab Apache License 2.0 Updated
fork time in 6 days ago
Jan
11
1 week ago
open pull request

wschwab wants to merge ethereum/EIPs

wschwab
wschwab

EIP-4610

eip-draft_title_abbrev

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.
wschwab
wschwab

I think there should probably be a view function returning a bool or address to see who's a delegator on a particular NFT.

open pull request

wschwab wants to merge ethereum/EIPs

wschwab
wschwab

EIP-4610

eip-draft_title_abbrev

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.
wschwab
wschwab

While you outline a new safeTransferFrom function here which has a bool for determining if a delegator is carried over from a transfer, this would not do away with the transfer or safeTransfer functions in the ERC-721 specification. (In other words, since the arguments are different, it wouldn't override those functions, it wouls just overload safeTransferFrom another time, as it's already overloaded in the 721 spec.)

What should happen when a user transfers using transferFrom or the original safeTransferFroms?

pull request

wschwab merge to ethereum/EIPs

wschwab
wschwab

EIP-4610

eip-draft_title_abbrev

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.
wschwab
wschwab

HI! Thanks for your submission. There are a couple of things I'd like to point out:

  1. What is the intended function of being a delegator? It looks like the delegator doesn't have the ability to transfer the asset, for example. imho the intent should be clarified in the EIP
  2. There have been other EIPs that have introduced a class of addresses that can consume an NFT in some form without owning it - EIP-4400 is merged as a Draft, and I would recommend seeing if it might suit your needs, and collaborating with the author there if it does.
pull request

wschwab merge to ethereum/EIPs

wschwab
wschwab

EIP-4610

eip-draft_title_abbrev

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.
wschwab
wschwab

HI! Thanks for your submission. There are a couple of things I'd like to point out:

  1. What is the intended function of being a delegator? It looks like the delegator doesn't have the ability to transfer the asset, for example. imho the intent should be clarified in the EIP
  2. There have been other EIPs that have introduced a class of addresses that can consume an NFT in some form without owning it - EIP-4400 is merged as a Draft, and I would recommend seeing if it might suit your needs, and collaborating with the author there if it does.
Jan
9
2 weeks ago
Activity icon
issue

wschwab issue Rari-Capital/solmate

wschwab
wschwab

include interfaces

Hi!

I'd like to encourage Solmate to include interfaces for ERC20, 721, and 1155. This is especially helpful when building contracts that need to interact with these standards. There may be a rationale that you'd prefer people to custom-make interfaces that include only the specific functions they're consuming (probably don't need name() from 20 or 721 in there, for example), but I'd argue that having interfaces there makes the library as a whole more versatile and useful.

I'd be happy to contribute this myself, if you're interested in having it - it's obviously not that much work.

Activity icon
fork

wschwab forked Rari-Capital/solmate

⚡ Modern, opinionated, and gas optimized building blocks for smart contract development.
wschwab GNU Affero General Public License v3.0 Updated
fork time in 2 weeks ago
pull request

wschwab pull request ethereum/EIPs

wschwab
wschwab

move 2612 to Review

This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.

push

wschwab push wschwab/EIPs

wschwab
wschwab

Uupdate "discussion to" place & status case (#4498)

wschwab
wschwab

Bump addressable from 2.7.0 to 2.8.0 (#3650)

Bumps addressable from 2.7.0 to 2.8.0.


updated-dependencies:

  • dependency-name: addressable dependency-type: indirect ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

wschwab
wschwab

Bump nokogiri from 1.11.4 to 1.12.5 (#4332)

Bumps nokogiri from 1.11.4 to 1.12.5.


updated-dependencies:

  • dependency-name: nokogiri dependency-type: indirect ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

wschwab
wschwab

better new submission error messages

wschwab
wschwab

updates name of block to change behavior on to TRANSITION_BLOCK per EIP-3675 (#4507)

Signed-off-by: Justin Florentine [email protected]

wschwab
wschwab

Major update for EIP-3525 (#4510)

  • Create eip-vnft

  • Create EIP-3525.md

  • Delete eip-vnft

  • Rename EIPS/EIP-3525.md to eip-3525.md

  • Update and rename eip-3525.md to EIPs/eip-3525.md

  • Delete EIPs directory

  • Create eip-3525.md

  • Update eip-3525.md

  • Update eip-3525.md

  • Update eip-3525.md

  • Update eip-3525.md

  • Rename eip-3525.md to eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Complete contents for first time.

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • update EIP-VNFT

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Rename eip-vnft.md to eip-3525.md

  • Update eip-3525.md

  • Update eip-3525.md

  • Apply suggestions from code review

Co-authored-by: lightclient [email protected]

  • Update eip-3525.md

Refinement of summary, abstract and motivation sections, from both will wang and mike meng.

  • Update eip-3525.md

  • Update eip-3525.md

  • Solv-vouchers implementation made open-source

also remove the the source as reference implementation, since it is not currently the suggested reference implementation yet.

  • Update eip-3525.md

  • correction on email

Co-authored-by: lightclient [email protected]

  • Remove the References section

  • partially change VNFT to ERC3525/ERC-3525

  • change decimals to unitDecimals

and other small fixes

  • completely replace VNFT with ERC-3525

and some other small fixes

  • Update eip-3525.md

add contractURI()

  • Update eip-3525.md

add slotURI()

  • completion of some descriptions

  • Update eip-3525.md

fix typo

  • Update eip-3525.md

  • Update EIPS/eip-3525.md

Co-authored-by: Micah Zoltu [email protected]

Co-authored-by: Ethan Y. Tsai [email protected] Co-authored-by: du [email protected] Co-authored-by: lightclient [email protected] Co-authored-by: Micah Zoltu [email protected]

wschwab
wschwab

The issue was in the YAML syntax with multi-line strings. (#4517)

  • The issue was in the YAML syntax with strings.

YAML syntax suggests using multiline string with pipe character (|). Suggested not to use double/single quotes with escape chars inside.

Signed-off-by: mr.yalamanchi [email protected]

  • Added a newline on reviewing micah's comment.

Signed-off-by: mr.yalamanchi [email protected]

wschwab
wschwab
wschwab
wschwab

Move 4345 to Last Call (#4518)

Signed-off-by: Tim Beiko [email protected]

wschwab
wschwab

(bot 1272989785) moving EIPS/eip-3561.md to stagnant (#4472)

PR 4472 with changes to EIPS/eip-3561.md was created on ([email protected]) which is before the cutoff date of ([email protected]) i.e. 2 weeks ago

wschwab
wschwab

(bot 1272989785) moving EIPS/eip-3386.md to stagnant (#4471)

PR 4471 with changes to EIPS/eip-3386.md was created on ([email protected]) which is before the cutoff date of ([email protected]) i.e. 2 weeks ago

wschwab
wschwab

(bot 1272989785) moving EIPS/eip-3440.md to stagnant (#4454)

PR 4454 with changes to EIPS/eip-3440.md was created on ([email protected]) which is before the cutoff date of ([email protected]) i.e. 2 weeks ago

wschwab
wschwab

(bot 1272989785) moving EIPS/eip-2938.md to stagnant (#4453)

PR 4453 with changes to EIPS/eip-2938.md was created on ([email protected]) which is before the cutoff date of ([email protected]) i.e. 2 weeks ago

wschwab
wschwab

(bot 1272989785) moving EIPS/eip-2255.md to stagnant (#4452)

PR 4452 with changes to EIPS/eip-2255.md was created on ([email protected]) which is before the cutoff date of ([email protected]) i.e. 2 weeks ago

wschwab
wschwab

Unstagnant eip 634 (#4429)

  • Updated EIP-2098 compact representation with suggestions and moved to review.

  • Move EIP-634 from Stagnant to Draft.

  • Updated fields to be up-to-date with current EIP standards.

  • Updated function style.

  • Updated per suggestions.

  • Update EIPS/eip-634.md

Co-authored-by: Alex Beregszaszi [email protected]

wschwab
wschwab

Transaction calldata gas cost reduction with total calldata limit (#4488)

  • Transaction calldata gas cost reduction with total calldata limit

Decrease transaction calldata gas cost, and add a limit of how much total transaction calldata can be in a block.

  • Minor edits

  • Fixed parameter name

  • Update EIPS/eip-4488.md

Co-authored-by: Alex Beregszaszi [email protected]

  • Update EIPS/eip-4488.md

Co-authored-by: Alex Beregszaszi [email protected]

  • Apply suggestions from code review

Co-authored-by: Micah Zoltu [email protected] Co-authored-by: Alex Beregszaszi [email protected]

  • remove wikipedia link

  • bring csv into eip assets

Co-authored-by: Alex Beregszaszi [email protected] Co-authored-by: Micah Zoltu [email protected] Co-authored-by: [email protected] [email protected]

wschwab
wschwab

Link to hardfork specs (#3696)

  • Link to hardfork specs

  • point to pm repo instead

Co-authored-by: lightclient [email protected]

wschwab
wschwab

EIP-2569: move from "stagnant" to "draft" (#4385)

  • EIP-2569: move from stagnant to draft

  • EIP-2569: Update the structure based on the feedback

  • EIP-2569: Update the structure based on the feedback

  • remove trailing comment

Co-authored-by: lightclient [email protected]

commit sha: 812866c2bfd0d34588740e5c89d6137da7e9281c

push time in 2 weeks ago
push

wschwab push wschwab/EIPs

wschwab
wschwab

Uupdate "discussion to" place & status case (#4498)

wschwab
wschwab

Bump addressable from 2.7.0 to 2.8.0 (#3650)

Bumps addressable from 2.7.0 to 2.8.0.


updated-dependencies:

  • dependency-name: addressable dependency-type: indirect ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

wschwab
wschwab

Bump nokogiri from 1.11.4 to 1.12.5 (#4332)

Bumps nokogiri from 1.11.4 to 1.12.5.


updated-dependencies:

  • dependency-name: nokogiri dependency-type: indirect ...

Signed-off-by: dependabot[bot] [email protected]

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

wschwab
wschwab

better new submission error messages

wschwab
wschwab

updates name of block to change behavior on to TRANSITION_BLOCK per EIP-3675 (#4507)

Signed-off-by: Justin Florentine [email protected]

wschwab
wschwab

Major update for EIP-3525 (#4510)

  • Create eip-vnft

  • Create EIP-3525.md

  • Delete eip-vnft

  • Rename EIPS/EIP-3525.md to eip-3525.md

  • Update and rename eip-3525.md to EIPs/eip-3525.md

  • Delete EIPs directory

  • Create eip-3525.md

  • Update eip-3525.md

  • Update eip-3525.md

  • Update eip-3525.md

  • Update eip-3525.md

  • Rename eip-3525.md to eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Complete contents for first time.

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Update eip-vnft.md

  • update EIP-VNFT

  • Update eip-vnft.md

  • Update eip-vnft.md

  • Rename eip-vnft.md to eip-3525.md

  • Update eip-3525.md

  • Update eip-3525.md

  • Apply suggestions from code review

Co-authored-by: lightclient [email protected]

  • Update eip-3525.md

Refinement of summary, abstract and motivation sections, from both will wang and mike meng.

  • Update eip-3525.md

  • Update eip-3525.md

  • Solv-vouchers implementation made open-source

also remove the the source as reference implementation, since it is not currently the suggested reference implementation yet.

  • Update eip-3525.md

  • correction on email

Co-authored-by: lightclient [email protected]

  • Remove the References section

  • partially change VNFT to ERC3525/ERC-3525

  • change decimals to unitDecimals

and other small fixes

  • completely replace VNFT with ERC-3525

and some other small fixes

  • Update eip-3525.md

add contractURI()

  • Update eip-3525.md

add slotURI()

  • completion of some descriptions

  • Update eip-3525.md

fix typo

  • Update eip-3525.md

  • Update EIPS/eip-3525.md

Co-authored-by: Micah Zoltu [email protected]

Co-authored-by: Ethan Y. Tsai [email protected] Co-authored-by: du [email protected] Co-authored-by: lightclient [email protected] Co-authored-by: Micah Zoltu [email protected]

wschwab
wschwab

The issue was in the YAML syntax with multi-line strings. (#4517)

  • The issue was in the YAML syntax with strings.

YAML syntax suggests using multiline string with pipe character (|). Suggested not to use double/single quotes with escape chars inside.

Signed-off-by: mr.yalamanchi [email protected]

  • Added a newline on reviewing micah's comment.

Signed-off-by: mr.yalamanchi [email protected]

wschwab
wschwab
wschwab
wschwab

Move 4345 to Last Call (#4518)

Signed-off-by: Tim Beiko [email protected]

wschwab
wschwab

(bot 1272989785) moving EIPS/eip-3561.md to stagnant (#4472)

PR 4472 with changes to EIPS/eip-3561.md was created on ([email protected]) which is before the cutoff date of ([email protected]) i.e. 2 weeks ago

wschwab
wschwab

(bot 1272989785) moving EIPS/eip-3386.md to stagnant (#4471)

PR 4471 with changes to EIPS/eip-3386.md was created on ([email protected]) which is before the cutoff date of ([email protected]) i.e. 2 weeks ago

wschwab
wschwab

(bot 1272989785) moving EIPS/eip-3440.md to stagnant (#4454)

PR 4454 with changes to EIPS/eip-3440.md was created on ([email protected]) which is before the cutoff date of ([email protected]) i.e. 2 weeks ago

wschwab
wschwab

(bot 1272989785) moving EIPS/eip-2938.md to stagnant (#4453)

PR 4453 with changes to EIPS/eip-2938.md was created on ([email protected]) which is before the cutoff date of ([email protected]) i.e. 2 weeks ago

wschwab
wschwab

(bot 1272989785) moving EIPS/eip-2255.md to stagnant (#4452)

PR 4452 with changes to EIPS/eip-2255.md was created on ([email protected]) which is before the cutoff date of ([email protected]) i.e. 2 weeks ago

wschwab
wschwab

Unstagnant eip 634 (#4429)

  • Updated EIP-2098 compact representation with suggestions and moved to review.

  • Move EIP-634 from Stagnant to Draft.

  • Updated fields to be up-to-date with current EIP standards.

  • Updated function style.

  • Updated per suggestions.

  • Update EIPS/eip-634.md

Co-authored-by: Alex Beregszaszi [email protected]

wschwab
wschwab

Transaction calldata gas cost reduction with total calldata limit (#4488)

  • Transaction calldata gas cost reduction with total calldata limit

Decrease transaction calldata gas cost, and add a limit of how much total transaction calldata can be in a block.

  • Minor edits

  • Fixed parameter name

  • Update EIPS/eip-4488.md

Co-authored-by: Alex Beregszaszi [email protected]

  • Update EIPS/eip-4488.md

Co-authored-by: Alex Beregszaszi [email protected]

  • Apply suggestions from code review

Co-authored-by: Micah Zoltu [email protected] Co-authored-by: Alex Beregszaszi [email protected]

  • remove wikipedia link

  • bring csv into eip assets

Co-authored-by: Alex Beregszaszi [email protected] Co-authored-by: Micah Zoltu [email protected] Co-authored-by: [email protected] [email protected]

wschwab
wschwab

Link to hardfork specs (#3696)

  • Link to hardfork specs

  • point to pm repo instead

Co-authored-by: lightclient [email protected]

wschwab
wschwab

EIP-2569: move from "stagnant" to "draft" (#4385)

  • EIP-2569: move from stagnant to draft

  • EIP-2569: Update the structure based on the feedback

  • EIP-2569: Update the structure based on the feedback

  • remove trailing comment

Co-authored-by: lightclient [email protected]

commit sha: ca1a74bcf04ed4dba930799bde2d1bc89a6e3039

push time in 2 weeks ago
pull request

wschwab pull request ethereum/EIPs

wschwab
wschwab

Move EIP-2612 to Review

This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.

Activity icon
issue

wschwab issue comment ethereum/EIPs

wschwab
wschwab

Move EIP-2612 to Review

This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.

wschwab
wschwab

I'm closing in order to reopen - this branch seems to have additional content in it.

pull request

wschwab pull request ethereum/EIPs

wschwab
wschwab

Move EIP-2612 to Review

This PR moves EIP-2612 to Review. EIP-2612 enjoys widespread adoption, and imho should be moved forward in the EIP process. I have spoked with the EIP's author, @MrChico , and has told me that he is content with the specification as-is, and would be interested and it seeing it move forward.

Previous