HideSkeleton() does not apply transition within a UITableView

4
open
PlayDevelop
PlayDevelop
Posted 5 months ago

HideSkeleton() does not apply transition within a UITableView #469

Description

The transition is broken when doing HideSkeleton(transition: .crossDisolve(TIME)) when the views is within a UITableView.

Same thing in Example app.

What type of issue is this? (place an x in one of the [ ])

  • [ X ] bug
  • enhancement (feature request)
  • question
  • documentation related
  • discussion

Requirements (place an x in each of the [ ])

  • [ X ] I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • [X ] I've read and agree to the Code of Conduct.
  • [X ] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

SkeletonView Environment:

SkeletonView version: 1.26.0 Xcode version: 13.1 Swift version: 5.5.1

Steps to reproduce:

Please replace this with the steps to reproduce the behavior.

  1. Apply Skeleton views within UITableView cell
  2. Show Skeleton with crossdisolve of 1 sec
  3. Hide Skeleton with crossdisolve of 1 sec

Expected result:

Skeleton shows and hide with expected transition time

Actual result:

Skeleton shows with crossdisolve time of 1, and hide with no transition

Attachments:

Logs, screenshots, sample project, funny gif, etc.

Juanpe
Juanpe
Created 4 months ago

Hi @PlayDevelop 👋🏼

You're right, I'm going to add it to the backlog to fix it asap 👍🏼

Thanks

shipinev
shipinev
Created 4 months ago

Hey @Juanpe. First of all, thank you for this easy-to-use library. Do you have any update on the issue fix?

Juanpe
Juanpe
Created 4 months ago

Thanks, @shipinev. Not yet, sorry :/

JacksonJang
JacksonJang
Created 3 months ago

I fixed! Please check this solution. https://github.com/Juanpe/SkeletonView/pull/484