Nov
25
5 days ago
Activity icon
issue

gwynnarth issue NodeBB/nodebb-theme-persona

gwynnarth
gwynnarth

Categories search dropdown is not touch-friendly

Hi,

the recently introduced feature that allows users to type in a category name in a dropdown (buttons "All categories" and "Mark as Read") while makes perfect sense on desktop, is a bit annoying when operating on a mobile device. The button changes into an input which causes at least two issues:

  1. if there are a lot of categories (like it happens to be so on our forums) then the input will hide underneath the list which does not look good (you can only see a blinking cursor in a seemingly random place on the screen:

IMG_7585

  1. it makes the keyboard to pop up which is especially annoying on devices with smaller screen and/or in landscape. It forces user to close the keyboard because it covers the entire screen or a great portion of it, to make sense of what is actually happening: IMG_7586

All in all, while I think this feature makes perfect sense on a desktop device, this is more of an obstacle when on a small screen device. I wonder if it would be possible to consider the device type (perhaps by looking at the device screen width) and NOT show the input when on mobile?

Thanks!

Nov
22
1 week ago
Activity icon
issue

Yehonatan-Albert issue NodeBB/nodebb-theme-persona

Yehonatan-Albert
Yehonatan-Albert

remove outlines

Would be nice to add this css

* {
    outline: none !important;
}
Activity icon
issue

Yehonatan-Albert issue comment NodeBB/nodebb-theme-persona

Yehonatan-Albert
Yehonatan-Albert

remove outlines

Would be nice to add this css

* {
    outline: none !important;
}
Yehonatan-Albert
Yehonatan-Albert

Outlines are necessary from an accessibiliy standpoint, so unfortunately we cannot remove them for aesthetic reasons.

OK

push

julianlam push NodeBB/nodebb-theme-persona

julianlam
julianlam

chore: update package.json to point to correct repo url

commit sha: 3c6163edb41ef3f908ff06ca0323c9715aa5042b

push time in 1 week ago
Activity icon
issue

julianlam issue comment NodeBB/nodebb-theme-persona

julianlam
julianlam

remove outlines

Would be nice to add this css

* {
    outline: none !important;
}
julianlam
julianlam

Outlines are necessary from an accessibiliy standpoint, so unfortunately we cannot remove them for aesthetic reasons.

Activity icon
issue

julianlam issue comment NodeBB/nodebb-theme-persona

julianlam
julianlam

refactor: header padding calculations [breaking]

  • Rewrote in vanilla js
  • Takes into account the actual vertical height of the header from the top of viewport in addition to the header itself
    • Themes often add stuff above the header, and so theme-related hacks will no longer be necessary
Activity icon
created tag
createdAt 1 week ago
Activity icon
issue

julianlam issue comment NodeBB/nodebb-theme-persona

julianlam
julianlam

refactor: header padding calculations [breaking]

  • Rewrote in vanilla js
  • Takes into account the actual vertical height of the header from the top of viewport in addition to the header itself
    • Themes often add stuff above the header, and so theme-related hacks will no longer be necessary
julianlam
julianlam
Previous