Latest preact update causes Tabs components to be out of order

2
closed
beans42
beans42
Posted 4 months ago

Latest preact update causes Tabs components to be out of order #662

Bug report 🐞

Not sure if this is an issue with preact or geist, but the latest preact releases seem to have broken the Tabs component.

Version & Environment

  • Version of preact: anything past 10.6.2
  • Version of geist-ui/react: latest

Expected Behaviour

Tabs.Items elements to be listed in the order defined in JSX.

Actual results (or Errors)

Tabs.Items are in reverse (?) order.

Minimal working example

How it looks with preact 10.6.2: image How it looks with preact 10.6.3 and 10.6.4: image

The offending preact update The offending geist code (I think?)

Lzumikonata
Lzumikonata
Created 4 months ago

CodeSandbox In the local test of Preact(version: 10.6.2, 10.6.3), The initialization order of child components is incorrect, which seems to be a problem of Preact. Please see the Label printing order of Child in this example.

unix
unix
Created 4 months ago

Thanks @Lzumikonata, I also verified that this is indeed a preact lifecycle issue.