Oct
28
20 hours ago
open pull request

ckadner wants to merge machine-learning-exchange/mlx

ckadner
ckadner

Add developer docs from KT

ckadner
ckadner

should that image live in the MLX repo?

Activity icon
issue

mlx-bot issue comment machine-learning-exchange/mlx

mlx-bot
mlx-bot

Add developer docs from KT

mlx-bot
mlx-bot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drewbutlerbb4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

open pull request

BluThaitanium wants to merge machine-learning-exchange/mlx

BluThaitanium
BluThaitanium

Sed for linux

Fixes updating licensing by running the correct sed command corresponding to Linux and MacOS For readability- Sed commands are in separate functions, called by each xxxx_comment() function in add_license_headers.sh during execution. Throws error statement without exit code, indicating the command isn't working due to OS limitations of sed (i.e. user is using Windows)

@ckadner

BluThaitanium
BluThaitanium
pull request

BluThaitanium merge to machine-learning-exchange/mlx

BluThaitanium
BluThaitanium

Sed for linux

Fixes updating licensing by running the correct sed command corresponding to Linux and MacOS For readability- Sed commands are in separate functions, called by each xxxx_comment() function in add_license_headers.sh during execution. Throws error statement without exit code, indicating the command isn't working due to OS limitations of sed (i.e. user is using Windows)

@ckadner

pull request

BluThaitanium merge to machine-learning-exchange/mlx

BluThaitanium
BluThaitanium

Sed for linux

Fixes updating licensing by running the correct sed command corresponding to Linux and MacOS For readability- Sed commands are in separate functions, called by each xxxx_comment() function in add_license_headers.sh during execution. Throws error statement without exit code, indicating the command isn't working due to OS limitations of sed (i.e. user is using Windows)

@ckadner

open pull request

BluThaitanium wants to merge machine-learning-exchange/mlx

BluThaitanium
BluThaitanium

Sed for linux

Fixes updating licensing by running the correct sed command corresponding to Linux and MacOS For readability- Sed commands are in separate functions, called by each xxxx_comment() function in add_license_headers.sh during execution. Throws error statement without exit code, indicating the command isn't working due to OS limitations of sed (i.e. user is using Windows)

@ckadner

BluThaitanium
BluThaitanium

Aliasing doesn't work without -i, at least for linux if that matters although I think it's universal. -i allows for an interactive shell, which simulates gsed being exported to ~/.bashrc for just this session. In reality we don't want to actually permanently change a user's ~/.bashrc.

Terminal depends on things defined in ~./bashrc. Aliasing in this script only allows for definitions if our terminal is within the script. So without -i you get command not found because our terminal is non-interactive and can't "remember" the alias. The -S portion lets you add arguments to the bash command #!/file/path -S [command] [argv1] [argv2] ...

Previous