Jan
24
15 hours ago
Activity icon
issue

bpasero issue comment microsoft/vscode

bpasero
bpasero

Inlay hints are not folder aware

I use a multi-root workspace:

{
	"folders": [
		{
			"path": "monaco"
		},
		{
			"path": "vscode-docs"
		}
	],
	"settings": {
		"files.associations": {
			"cglicenses.json": "jsonc"
		},
		"typescript.tsdk": "monaco/node_modules/typescript/lib",
		"emmet.excludeLanguages": [],
		"git.ignoreLimitWarning": true,
		"remote.extensionKind": {
			"msjsdiag.debugger-for-chrome": "workspace"
		},
		"typescript.tsc.autoDetect": "off"
	}
}

I do not see inlay hints in vscode (monaco is the vscode repo) even though they are enabled in workspace settings for vscode.

bpasero
bpasero

It seems to only hit this method once when I open an editor and early return:

Recording 2022-01-24 at 16 57 26 (1)

Activity icon
issue

chrisdias issue comment microsoft/vscode

chrisdias
chrisdias

Create My microsoft

This PR fixes #

chrisdias
chrisdias

It looks like you are new to GitHub, welcome! Here's a good place to start if you want to contribute: https://github.com/microsoft/vscode/wiki/How-to-Contribute

Activity icon
wiki
created time in 2 minutes ago
Activity icon
issue

bpasero issue comment microsoft/vscode

bpasero
bpasero

Inlay hints are not folder aware

I use a multi-root workspace:

{
	"folders": [
		{
			"path": "monaco"
		},
		{
			"path": "vscode-docs"
		}
	],
	"settings": {
		"files.associations": {
			"cglicenses.json": "jsonc"
		},
		"typescript.tsdk": "monaco/node_modules/typescript/lib",
		"emmet.excludeLanguages": [],
		"git.ignoreLimitWarning": true,
		"remote.extensionKind": {
			"msjsdiag.debugger-for-chrome": "workspace"
		},
		"typescript.tsc.autoDetect": "off"
	}
}

I do not see inlay hints in vscode (monaco is the vscode repo) even though they are enabled in workspace settings for vscode.

bpasero
bpasero

Btw this reproduces from then on also after a window reload, so it is not related to entering the workspace. Maybe we can debug on my machine.

Activity icon
issue

jrieken issue comment microsoft/vscode

jrieken
jrieken

Inlay hints are not folder aware

I use a multi-root workspace:

{
	"folders": [
		{
			"path": "monaco"
		},
		{
			"path": "vscode-docs"
		}
	],
	"settings": {
		"files.associations": {
			"cglicenses.json": "jsonc"
		},
		"typescript.tsdk": "monaco/node_modules/typescript/lib",
		"emmet.excludeLanguages": [],
		"git.ignoreLimitWarning": true,
		"remote.extensionKind": {
			"msjsdiag.debugger-for-chrome": "workspace"
		},
		"typescript.tsc.autoDetect": "off"
	}
}

I do not see inlay hints in vscode (monaco is the vscode repo) even though they are enabled in workspace settings for vscode.

jrieken
jrieken

This is quite bizarre, I am able to reproduce with a fresh user data dir and fresh extensions dir on insiders even with just 1 folder (called monaco our repo) transitioning into multi root workspace:

And then still going pass that extension point? Maybe extension host configuration object isn't updated properly so that TypeScript inlay hints aren't enabled...

Activity icon
issue

dinushkaherath issue comment microsoft/vscode

dinushkaherath
dinushkaherath

Port forwarding only works with this /usr/sbin/sshd listener 0 of 10-100 startups running

ADD ISSUE DESCRIPTION HERE So I have hausra graphql running on hasura:8080

I cannot access it through my rails server sending requests to it without this running: /usr/sbin/sshd listener 0 of 10-100 startups

Sometimes it does not startup with my codespaces leaving it with connection refused to the server

Currently even with that running, now my codespaces is stuck loading. (wont even load the extensions) and the graphql request is stuck in fetch pending...

Version: 1.63.2 Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3 User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.99 Safari/537.36 Embedder: codespaces

dinushkaherath
dinushkaherath

@alexr00 one issue - workspace stuck loading 1 2 3 other issue - main issue cannot send requests to my hasura server 4 5 6

Activity icon
issue

eamodio issue comment microsoft/vscode

eamodio
eamodio

January 2022 Endgame

  • January 24, 2022 Code freeze for the endgame
  • January 28, 2022 Endgame done
  • February 03, 2022 Expected release date (this may change)
Monday
  • Check that all queries in this issue use the current milestone endgame champion
  • Run OSS tool endgame champion
  • Update links in Endgame issue and Endgame notebooks to point to new milestone endgame champion
  • Code freeze at 5pm PT
  • Ensure we have a green build on all platforms at 5pm PT
  • Create test plan items following the template here by 6pm PT
  • Add verification-needed label to features needed testing and are not tested by TPIs.
  • Update your availability for testing here - https://vscode-tools.azurewebsites.net/team team
    • Update availability of testers in vacation. Double check N/A testers. endgame champion
Tuesday
Wednesday
Thursday
  • Fixing (self-assigned, milestone assigned, no need for PR or review)
    • Increased scrutiny sets in due to testing being completed. Fixes pose a much higher risk
    • Move issues to the next month that can be deferred
  • 🔖Verification needed
  • 🔖Verification
Friday
  • Build a stable build to ensure stable build is green endgame champion
  • Pause scheduled insider builds endgame champion
  • Satellite modules/npm packages ready, version updated, smoke tested
  • Only candidate issues are open and assigned to 🔖milestone
  • All issues 🔖verified
  • Branch code to release/<x.y> after all expected fixes are in (latest 5PM PST) endgame champion
  • Branch distro to release/<x.y> after all expected fixes are in (latest 5PM PST) endgame champion
  • Announce main is open for business endgame champion
  • Fixing (PR + review required once branched - major bugs only - to be discussed in stand-up meeting, labeled as candidate)
  • All release notes updated
  • Acknowledge pull requests in release notes. We acknowledge PRs from outside the team. We have improved the tooling so that the endgame champion can generate the pull request acknowledgment for all repositories at once. endgame champion
    • debug-adapter-protocol, inno-updater, jsonc-parser, language-server-protocol, lsif-node, vscode, vscode-codicons, vscode-css-languageservice, vscode-debugadapter-node, vscode-dev-containers, vscode-docs, vscode-emmet-helper, vscode-eslint, vscode-extension-samples, vscode-generator-code, vscode-hexeditor, vscode-html-languageservice, vscode-js-debug, vscode-js-debug-companion, vscode-js-profile-visualizer, vscode-jshint, vscode-json-languageservice, vscode-languageserver-node, vscode-livepreview, vscode-loader, vscode-lsif-extension, vscode-node-debug, vscode-node-debug2, vscode-pull-request-github, vscode-recipes, vscode-references-view, vscode-textmate, vscode-vsce
  • Acknowledge issue trackers from the community @chrmarti
  • Add notable fixes to the release notes all
  • When done fixing/verifying and there are changes since last build at the end of day PT
    • Build and manually release Insider from release/<x.y> endgame champion
  • Localization: Run Update VS Code Branch in the vscode-loc-drop repo with release/* as the VS Code Branch parameter (it's the default so you shouldn't have to change anything) endgame champion
Friday/Monday
  • Polish release notes redmond
  • Fixing (only critical bugs - no string changes)
Monday - Wednesday

Note: The Insiders build needs to be in the wild for 24 hours before we can enter the last phase of the endgame. endgame champion

Wednesday/Thursday - Expected release day (this may change)
  • Build stable for all platforms endgame champion
  • Sanity check of installable bits (server instructions)
    • Windows 32 bit owner
      • signed installer 32-bit
      • signed user installer 32-bit
      • zip 32-bit
      • server 32-bit
    • Windows 64 bit owner
      • signed installer 64-bit
      • signed user installer 64-bit
      • zip 64-bit
      • server 64-bit
    • Windows ARM64 owner
      • signed installer ARM64
      • signed user installer ARM64
      • zip ARM64
    • macOS
      • Universal owner
      • Intel owner
      • Intel server owner
      • Apple Silicon owner
    • Linux x64
      • deb owner
      • rpm owner
      • archives owner
      • snap (sudo snap install --classic --dangerous <file>.snap) owner
    • Linux server owner
      • x64
      • x64 Alpine
      • ARM32
      • ARM64
  • Publish website @gregvanl
  • Publish to stable endgame champion
  • Create an official release endgame champion
    • Create a tag (make sure you pull the release branch first): git tag <x.y.z>
    • Push the tag: git push origin <x.y.z>
    • Create a GitHub release: Open the GitHub tags, and click far right ... > Create Release. Use the correct title and description from our release notes. Also change the relative links for the key highlight list items to absolute links Example
  • Twitter announcement @chrisdias
  • Enable scheduled insider builds endgame champion
  • Bump up the version in package.json on main - endgame champion
  • Publish @types/vscode endgame champion
eamodio
eamodio

@hediet 👋 I seem to still be assigned items on this 😂

Activity icon
issue

hediet issue microsoft/vscode

hediet
hediet

January 2022 Endgame

  • January 24, 2022 Code freeze for the endgame
  • January 28, 2022 Endgame done
  • February 03, 2022 Expected release date (this may change)
Monday
  • Check that all queries in this issue use the current milestone endgame champion
  • Run OSS tool endgame champion
  • Update links in Endgame issue and Endgame notebooks to point to new milestone endgame champion
  • Code freeze at 5pm PT
  • Ensure we have a green build on all platforms at 5pm PT
  • Create test plan items following the template here by 6pm PT
  • Add verification-needed label to features needed testing and are not tested by TPIs.
  • Update your availability for testing here - https://vscode-tools.azurewebsites.net/team team
    • Update availability of testers in vacation. Double check N/A testers. endgame champion
Tuesday
Wednesday
Thursday
  • Fixing (self-assigned, milestone assigned, no need for PR or review)
    • Increased scrutiny sets in due to testing being completed. Fixes pose a much higher risk
    • Move issues to the next month that can be deferred
  • 🔖Verification needed
  • 🔖Verification
Friday
  • Build a stable build to ensure stable build is green endgame champion
  • Pause scheduled insider builds endgame champion
  • Satellite modules/npm packages ready, version updated, smoke tested
  • Only candidate issues are open and assigned to 🔖milestone
  • All issues 🔖verified
  • Branch code to release/<x.y> after all expected fixes are in (latest 5PM PST) endgame champion
  • Branch distro to release/<x.y> after all expected fixes are in (latest 5PM PST) endgame champion
  • Announce main is open for business endgame champion
  • Fixing (PR + review required once branched - major bugs only - to be discussed in stand-up meeting, labeled as candidate)
  • All release notes updated
  • Acknowledge pull requests in release notes. We acknowledge PRs from outside the team. We have improved the tooling so that the endgame champion can generate the pull request acknowledgment for all repositories at once. endgame champion
    • debug-adapter-protocol, inno-updater, jsonc-parser, language-server-protocol, lsif-node, vscode, vscode-codicons, vscode-css-languageservice, vscode-debugadapter-node, vscode-dev-containers, vscode-docs, vscode-emmet-helper, vscode-eslint, vscode-extension-samples, vscode-generator-code, vscode-hexeditor, vscode-html-languageservice, vscode-js-debug, vscode-js-debug-companion, vscode-js-profile-visualizer, vscode-jshint, vscode-json-languageservice, vscode-languageserver-node, vscode-livepreview, vscode-loader, vscode-lsif-extension, vscode-node-debug, vscode-node-debug2, vscode-pull-request-github, vscode-recipes, vscode-references-view, vscode-textmate, vscode-vsce
  • Acknowledge issue trackers from the community @chrmarti
  • Add notable fixes to the release notes all
  • When done fixing/verifying and there are changes since last build at the end of day PT
    • Build and manually release Insider from release/<x.y> endgame champion
  • Localization: Run Update VS Code Branch in the vscode-loc-drop repo with release/* as the VS Code Branch parameter (it's the default so you shouldn't have to change anything) endgame champion
Friday/Monday
  • Polish release notes redmond
  • Fixing (only critical bugs - no string changes)
Monday - Wednesday

Note: The Insiders build needs to be in the wild for 24 hours before we can enter the last phase of the endgame. endgame champion

Wednesday/Thursday - Expected release day (this may change)
  • Build stable for all platforms endgame champion
  • Sanity check of installable bits (server instructions)
    • Windows 32 bit owner
      • signed installer 32-bit
      • signed user installer 32-bit
      • zip 32-bit
      • server 32-bit
    • Windows 64 bit owner
      • signed installer 64-bit
      • signed user installer 64-bit
      • zip 64-bit
      • server 64-bit
    • Windows ARM64 owner
      • signed installer ARM64
      • signed user installer ARM64
      • zip ARM64
    • macOS
      • Universal owner
      • Intel owner
      • Intel server owner
      • Apple Silicon owner
    • Linux x64
      • deb owner
      • rpm owner
      • archives owner
      • snap (sudo snap install --classic --dangerous <file>.snap) owner
    • Linux server owner
      • x64
      • x64 Alpine
      • ARM32
      • ARM64
  • Publish website @gregvanl
  • Publish to stable endgame champion
  • Create an official release endgame champion
    • Create a tag (make sure you pull the release branch first): git tag <x.y.z>
    • Push the tag: git push origin <x.y.z>
    • Create a GitHub release: Open the GitHub tags, and click far right ... > Create Release. Use the correct title and description from our release notes. Also change the relative links for the key highlight list items to absolute links Example
  • Twitter announcement @chrisdias
  • Enable scheduled insider builds endgame champion
  • Bump up the version in package.json on main - endgame champion
  • Publish @types/vscode endgame champion
Activity icon
issue

github-actions[bot] issue comment microsoft/vscode

github-actions[bot]
github-actions[bot]

VS Code as a Progressive Web App

vscode.dev would benefit greatly from the ability to install as a progressive web app. Benefits include faster load times, smoother interface, and offline access.

github-actions[bot]
github-actions[bot]

Invalid test plan item. See errors below and the test plan item spec for more information. This comment will go away when the issues are resolved.

Error: Test plan item should have header

Previous