Oct
28
20 hours ago
Activity icon
issue

github-actions[bot] issue comment primer/react

github-actions[bot]
github-actions[bot]

Adds a note to docs about using theme instances other than the ThemeContext's theme

Adds a note about a pattern I've seen in a few places.

Screenshots

CleanShot 2021-10-28 at 12 34 57@2x

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

github-actions[bot]
github-actions[bot]

size-limit report 📦

Path Size
dist/browser.esm.js 54.2 KB (0%)
dist/browser.umd.js 54.6 KB (0%)
Activity icon
issue

changeset-bot[bot] issue comment primer/react

changeset-bot[bot]
changeset-bot[bot]

Adds a note to docs about using theme instances other than the ThemeContext's theme

Adds a note about a pattern I've seen in a few places.

Screenshots

CleanShot 2021-10-28 at 12 34 57@2x

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

changeset-bot[bot]
changeset-bot[bot]

⚠️ No Changeset found

Latest commit: 5a50f65a45cbaec7807de2b5d1cefd24e38e745c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pull request

jfuchs pull request primer/react

jfuchs
jfuchs

Adds a note to docs about using theme instances other than the ThemeContext's theme

Adds a note about a pattern I've seen in a few places.

Screenshots

CleanShot 2021-10-28 at 12 34 57@2x

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

push

jfuchs push primer/react

jfuchs
jfuchs

Adds theme keypaths to our sx prop type for better autocomplete (#1544)

  • Adds theme keypaths to our sx prop type for better autocomplete
  • Changeset patch -> minor
jfuchs
jfuchs

Change counter attributes to numbers, not strings (#1533)

Co-authored-by: Cole Bemis [email protected]

jfuchs
jfuchs

Adds a note to docs about using theme instances other than the ThemeContext's theme

commit sha: 5a50f65a45cbaec7807de2b5d1cefd24e38e745c

push time in 32 minutes ago
push

jfuchs push primer/react

jfuchs
jfuchs

Adds a note to docs about using theme instances other than the ThemeContext's theme

commit sha: d74130666c9e4155c0b1a0ef285ef3dbb073dff9

push time in 38 minutes ago
push

primer-css push primer/react

primer-css
primer-css

Change counter attributes to numbers, not strings (#1533)

Co-authored-by: Cole Bemis [email protected]

commit sha: 58429c9f804d86097aedd409719a3ff66a6c1fe3

push time in 55 minutes ago
push

colebemis push primer/react

colebemis
colebemis

Change counter attributes to numbers, not strings (#1533)

Co-authored-by: Cole Bemis [email protected]

commit sha: 13db79e93440b01e7138ac30fe6358b371c894c8

push time in 57 minutes ago
pull request

colebemis pull request primer/react

colebemis
colebemis

Change counter attributes to numbers, not strings

The counter attribute in FilterList.Item is a number, not a string.

No screenshots because this is just a docs change.

Activity icon
issue

colebemis issue comment primer/react

colebemis
colebemis

Change counter attributes to numbers, not strings

The counter attribute in FilterList.Item is a number, not a string.

No screenshots because this is just a docs change.

colebemis
colebemis

@siddharthkp Docs-only changes don't need changesets 👍

Activity icon
issue

github-actions[bot] issue comment primer/react

github-actions[bot]
github-actions[bot]

Release Tracking

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Minor Changes

  • #1544 5b55b0ab Thanks @jfuchs! - The sx prop now has types that will inform autocomplete for color and shadow values that are key paths into the theme.
github-actions[bot]
github-actions[bot]

size-limit report 📦

Path Size
dist/browser.esm.js 54.2 KB (0%)
dist/browser.umd.js 54.6 KB (0%)
Previous