Oct
15
1 day ago
started
started time in 10 hours ago
Activity icon
issue

exrezzo issue comment reactiveui/ReactiveUI

exrezzo
exrezzo

make CompositeDisposable protected

What kind of change does this PR introduce?

resolve #2783

What is the current behavior?

CompositeDisposable was private

What is the new behavior?

CompositeDisposable is now protected

What might this PR break?

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information: Very small changes

exrezzo
exrezzo

Hi, any news on this front? I'm trying to use the WhenActivated pattern, but the ReactiveComponentBase is not able to notify the backing VM. My actual workaround is simply calling

protected override void OnAfterRender(bool firstRender)
    {
        base.OnAfterRender(firstRender);
        if (!firstRender) return;
        FollowUpViewModel.Activator.Activate();
    }

and

protected override void Dispose(bool disposing)
    {
        base.Dispose(disposing);
        FollowUpViewModel.Activator.Deactivate();
    }

Is there something that I can do to contribute? Sorry I'm a newbie, I've never collaborated to an open project and I would really like to do it, I'm loving this ReactiveUI project.

started
started time in 17 hours ago
started
started time in 22 hours ago
Oct
14
2 days ago
started
started time in 1 day ago
Activity icon
fork

clongcc forked reactiveui/ReactiveUI

⚡ An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms that is inspired by functional reactive programming. ReactiveUI allows you to abstract mutable state away from your user interfaces, express the idea around a feature in one readable place and improve the testability of your application.
clongcc MIT License Updated
fork time in 1 day ago
started
started time in 1 day ago
Oct
13
3 days ago
started
started time in 2 days ago
Previous