Oct
28
21 hours ago
pull request

karlhorky pull request reactjs/reactjs.org

karlhorky
karlhorky

New docs: Swap wording

Thanks for the new docs!

It seems like this wording is swapped?

Original comment on the PR:

https://github.com/reactjs/reactjs.org/pull/3965#discussion_r734374242

Activity icon
issue

gaearon issue comment reactjs/reactjs.org

gaearon
gaearon

[Beta] Reference the source of ideas

Hey React Team!

Thanks for your hard work on the new React docs beta site!

While reading the post Referencing Values with Refs I couldn't help but notice that it contains a lot of ideas and examples (slightly modified) from my post The Complete Guide to useRef() and Refs in React (I am the author).

Could you reference my post as a source of examples?

Thank you!

pull request

gaearon pull request reactjs/reactjs.org

gaearon
gaearon

Fix left navigation tree doesn't toggle

Resolved issue #3985](https://github.com/reactjs/reactjs.org/issues/3985)

@rachelnabors I take a slightly different approach to this pull request.

I allow the child sidebar link to let the parent side bar route tree know that it should collapse & I check whether the node is already expanded in the child. This allows the existing implementation logic to remain untouched.

Please do let me know if my approach is not optimal, even if it is not merged I'd like to learn what I could have done better.

Thanks

pull request

gaearon pull request reactjs/reactjs.org

gaearon
gaearon

don't display shortcuts on mobile and use Ctrl on non-macOS or non-iO…

  • don't display shortcut keys on mobile devices (but retain shortcut keys for tablets)
  • display "Ctrl" instead of ⌘ for non-macOS like devices
  • use react-device-detect to detect devices

macOS like devices image

non-macOS like devices image

pull request

gaearon pull request reactjs/reactjs.org

gaearon
gaearon

Add sourcemaps in prod

This should add sourcemaps in prod which will make it easier to see inspect the docs and learn how they're built. Super meta, right?!?!

https://app.replay.io/recording/38961eee-e0e1-4e01-9704-d8f31324b97a?point=14927853477332335529154038892332435&time=9098&hasFrames=false#

pull request

gaearon pull request reactjs/reactjs.org

gaearon
gaearon

next handler sculptureList length control

pull request

gaearon pull request reactjs/reactjs.org

gaearon
gaearon

fix: The tree navigation on the left doesn't toggle

pull request

gaearon pull request reactjs/reactjs.org

gaearon
gaearon

Add click to copy functionality to TerminalBlock

Added a click to copy functionality and hover treatment to the TerminalBlock component to allow quick copying of commands.

Dark mode:

https://user-images.githubusercontent.com/11494384/138415936-ea9ce9ca-f778-4f22-ac27-81eb5150f9c3.mov

Light mode:

https://user-images.githubusercontent.com/11494384/138415826-337daefd-101e-4b3f-b19c-5cd97619fb69.mov

pull request

gaearon pull request reactjs/reactjs.org

gaearon
gaearon

:art: fix lint command and add lint:fix

This PR Fixes #3972 and adds lint:fix command

Previous